Solr
  1. Solr
  2. SOLR-6500

Refactor FileFetcher in SnapPuller, add debug logging

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Labels:
      None

      Description

      I was debugging some replication slowness and felt the need for some debug statements in this code path, which then pointed me to a lot of repeated code between local fs and directory file fetching logic in SnapPuller (for which there was a TODO as well), so went ahead and refactored that as well.

        Activity

        Hide
        ASF GitHub Bot added a comment -

        GitHub user andyetitmoves opened a pull request:

        https://github.com/apache/lucene-solr/pull/93

        Refactor FileFetcher in SnapPuller, add debug logging

        Patch for SOLR-6500

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/bloomberg/lucene-solr trunk-replication-log

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/lucene-solr/pull/93.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #93


        commit 755632ef196c0e7a4177bfe9b5176e3582d42ed0
        Author: Ramkumar Aiyengar <raiyengar@bloomberg.net>
        Date: 2014-09-02T11:06:17Z

        Add debug logging for SnapPuller and ReplicationHandler, refactor *FileFetcher


        Show
        ASF GitHub Bot added a comment - GitHub user andyetitmoves opened a pull request: https://github.com/apache/lucene-solr/pull/93 Refactor FileFetcher in SnapPuller, add debug logging Patch for SOLR-6500 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-replication-log Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/93.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #93 commit 755632ef196c0e7a4177bfe9b5176e3582d42ed0 Author: Ramkumar Aiyengar <raiyengar@bloomberg.net> Date: 2014-09-02T11:06:17Z Add debug logging for SnapPuller and ReplicationHandler, refactor *FileFetcher
        Hide
        Mark Miller added a comment -

        Nice, thanks Ramkumar!

        Show
        Mark Miller added a comment - Nice, thanks Ramkumar!
        Hide
        Varun Thacker added a comment -

        Refactoring looks good!

        Show
        Varun Thacker added a comment - Refactoring looks good!
        Hide
        Mark Miller added a comment -

        Can you bring this up to date as well Ram? I'll commit as soon as it's ready.

        Show
        Mark Miller added a comment - Can you bring this up to date as well Ram? I'll commit as soon as it's ready.
        Hide
        Ramkumar Aiyengar added a comment -

        Done!

        Show
        Ramkumar Aiyengar added a comment - Done!
        Hide
        Ramkumar Aiyengar added a comment -

        Hey Mark Miller, just brought this patch up to date again and resolved conflicts, could this go in? Thanks!

        Show
        Ramkumar Aiyengar added a comment - Hey Mark Miller , just brought this patch up to date again and resolved conflicts, could this go in? Thanks!
        Hide
        ASF subversion and git services added a comment -

        Commit 1654858 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1654858 ]

        SOLR-6500: Refactor FileFetcher in SnapPuller, add debug logging.

        Show
        ASF subversion and git services added a comment - Commit 1654858 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1654858 ] SOLR-6500 : Refactor FileFetcher in SnapPuller, add debug logging.
        Hide
        ASF subversion and git services added a comment -

        Commit 1654910 from Mark Miller in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1654910 ]

        SOLR-6500: Refactor FileFetcher in SnapPuller, add debug logging.

        Show
        ASF subversion and git services added a comment - Commit 1654910 from Mark Miller in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1654910 ] SOLR-6500 : Refactor FileFetcher in SnapPuller, add debug logging.
        Hide
        Erick Erickson added a comment -

        Mark Miller
        Is this closed then? Is there a patch file or just going from the revisions?

        Show
        Erick Erickson added a comment - Mark Miller Is this closed then? Is there a patch file or just going from the revisions?
        Hide
        Ramkumar Aiyengar added a comment -

        This should be resolved. Mark, feel free to reopen if not..

        Show
        Ramkumar Aiyengar added a comment - This should be resolved. Mark, feel free to reopen if not..
        Hide
        Mark Miller added a comment -

        Yeah, this is resolved. The patch file is linked to in the first comment...

        Show
        Mark Miller added a comment - Yeah, this is resolved. The patch file is linked to in the first comment...

          People

          • Assignee:
            Mark Miller
            Reporter:
            Ramkumar Aiyengar
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development