Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6422

DELETEREPLICA exposes an inconsistent param REPLICA_PROP

    XMLWordPrintableJSON

    Details

      Description

      DELETEREPLICA asks for the ZK "shard id" (core_node_###) instead of the same syntax as createNodeSet? I can't recall any other instance in which the ZK "shard id" is exposed via query parameter and I've only ever seen it in clusterstate.json / CLUSTERSTATUS calls.

      For ease of use I humbly suggest that the API be amended to take the same parameters are ADDREPLICA and use either base_url or core_node_name.

      Specifically, instead of REPLICA_PROP here https://github.com/apache/lucene-solr/blob/branch_4x/solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java#L64
      it would be more consistent to request a query param of the form: https://github.com/apache/lucene-solr/blob/branch_4x/solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java#L58
      or: https://github.com/apache/lucene-solr/blob/branch_4x/solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java#L56

      Also it appears DELETEREPLICA is missing from https://github.com/apache/lucene-solr/blob/branch_4x/solr/solrj/src/java/org/apache/solr/common/params/CollectionParams.java

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                ralph.tice Ralph Tice
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - 24h
                  24h
                  Remaining:
                  Remaining Estimate - 24h
                  24h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified