Solr
  1. Solr
  2. SOLR-6390

Remove unnecessary checked exception for CloudSolrServer constructor

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      The CloudSolrServer constructors can be simplified and can remove an unnecessary checked exception for one of the 4 constructors.

      1. SOLR-6390.patch
        10 kB
        Shawn Heisey
      2. SOLR-6390.patch
        10 kB
        Shawn Heisey
      3. SOLR-6390.patch
        9 kB
        Steve Davids
      4. SOLR-6390.patch
        7 kB
        Steve Davids

        Activity

        Hide
        Steve Davids added a comment -

        Added patch

        Show
        Steve Davids added a comment - Added patch
        Hide
        Shawn Heisey added a comment -

        Looks good. The javadoc update made me remember just how incomplete the javadocs for CloudSolrServer constructors are, and I would recommend using the javadocs I created on SOLR-5852. Look at the latest patch on that issue, from 23/Jul/14. That one never got committed, and probably needs to be closed.

        Do you want to make a new patch, or leave it for me?

        Show
        Shawn Heisey added a comment - Looks good. The javadoc update made me remember just how incomplete the javadocs for CloudSolrServer constructors are, and I would recommend using the javadocs I created on SOLR-5852 . Look at the latest patch on that issue, from 23/Jul/14. That one never got committed, and probably needs to be closed. Do you want to make a new patch, or leave it for me?
        Hide
        Steve Davids added a comment -

        I can go ahead and update the patch later this evening.

        Show
        Steve Davids added a comment - I can go ahead and update the patch later this evening.
        Hide
        Steve Davids added a comment -

        Updated patch to add more descriptive javadocs for the CloudSolrServer constructors found in issue SOLR-5852.

        Show
        Steve Davids added a comment - Updated patch to add more descriptive javadocs for the CloudSolrServer constructors found in issue SOLR-5852 .
        Hide
        Shawn Heisey added a comment -

        Updated patch with one tiny change to @see on three of the constructors, plus the CHANGES.txt update. Patch is specific to trunk, but applies with no problem to branch_4x.

        After running precommit and tests, I will commit later today. Reviews welcome.

        Show
        Shawn Heisey added a comment - Updated patch with one tiny change to @see on three of the constructors, plus the CHANGES.txt update. Patch is specific to trunk, but applies with no problem to branch_4x. After running precommit and tests, I will commit later today. Reviews welcome.
        Hide
        Shawn Heisey added a comment -

        A minor update to the minor update.

        Show
        Shawn Heisey added a comment - A minor update to the minor update.
        Hide
        ASF subversion and git services added a comment -

        Commit 1620146 from Shawn Heisey in branch 'dev/trunk'
        [ https://svn.apache.org/r1620146 ]

        SOLR-6390: CloudSolrServer constructor improvements

        Show
        ASF subversion and git services added a comment - Commit 1620146 from Shawn Heisey in branch 'dev/trunk' [ https://svn.apache.org/r1620146 ] SOLR-6390 : CloudSolrServer constructor improvements
        Hide
        Shawn Heisey added a comment -

        Right after I got the trunk commit done, I remembered that although I had started a precommit on trunk, I actually don't recall seeing whether it passed. Running it again before committing branch_4x.

        Show
        Shawn Heisey added a comment - Right after I got the trunk commit done, I remembered that although I had started a precommit on trunk, I actually don't recall seeing whether it passed. Running it again before committing branch_4x.
        Hide
        Shawn Heisey added a comment -

        The precommit turned up another problem, verified as related to LUCENE-5889. I've put a note on that issue.

        Show
        Shawn Heisey added a comment - The precommit turned up another problem, verified as related to LUCENE-5889 . I've put a note on that issue.
        Hide
        ASF subversion and git services added a comment -

        Commit 1620185 from Shawn Heisey in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1620185 ]

        SOLR-6390: CloudSolrServer constructor improvements. (merge trunk r1620146)

        Show
        ASF subversion and git services added a comment - Commit 1620185 from Shawn Heisey in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1620185 ] SOLR-6390 : CloudSolrServer constructor improvements. (merge trunk r1620146)
        Hide
        Shawn Heisey added a comment -

        Thanks, Steve!

        Show
        Shawn Heisey added a comment - Thanks, Steve!
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Shawn Heisey
            Reporter:
            Steve Davids
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development