Solr
  1. Solr
  2. SOLR-6232

Allow cores that have failed to init to be deleted via CoreAdminHandler

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.10, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      If a core fails to init due to index corruption or something similar, it can't currently be removed with an UNLOAD command, you have to go do it manually.

      1. SOLR-6232.patch
        44 kB
        Alan Woodward

        Issue Links

          Activity

          Hide
          Alan Woodward added a comment -

          Patch.

          • Extends the coreInitFailures map to hold CoreDescriptors as well as Exceptions
          • CoreContainer.remove() is replaced by CoreContainer.unload(), which checks the coreInitFailures map first to see if the core has failed to load, and deals with that
          • The actual logic for removing files, etc, is moved into SolrCore. CoreAdminHandler just parses parameters and passes them on to CoreContainer.unload()
          Show
          Alan Woodward added a comment - Patch. Extends the coreInitFailures map to hold CoreDescriptors as well as Exceptions CoreContainer.remove() is replaced by CoreContainer.unload(), which checks the coreInitFailures map first to see if the core has failed to load, and deals with that The actual logic for removing files, etc, is moved into SolrCore. CoreAdminHandler just parses parameters and passes them on to CoreContainer.unload()
          Hide
          Shalin Shekhar Mangar added a comment -

          +1 to the feature/bug-fix

          This is sorely needed.

          Show
          Shalin Shekhar Mangar added a comment - +1 to the feature/bug-fix This is sorely needed.
          Hide
          ASF subversion and git services added a comment -

          Commit 1612896 from hossman@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1612896 ]

          SOLR-6232: fix logging of core init failures

          Show
          ASF subversion and git services added a comment - Commit 1612896 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1612896 ] SOLR-6232 : fix logging of core init failures
          Hide
          ASF subversion and git services added a comment -

          Commit 1612901 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1612901 ]

          SOLR-6232: fix logging of core init failures (merge r1612896)

          Show
          ASF subversion and git services added a comment - Commit 1612901 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1612901 ] SOLR-6232 : fix logging of core init failures (merge r1612896)
          Hide
          ASF subversion and git services added a comment -

          Commit 1612942 from hossman@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1612942 ]

          SOLR-6232: fix stupid accidental commit

          Show
          ASF subversion and git services added a comment - Commit 1612942 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1612942 ] SOLR-6232 : fix stupid accidental commit

            People

            • Assignee:
              Alan Woodward
              Reporter:
              Alan Woodward
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development