[SOLR-6131] Remove deprecated Token class from solr.spelling package

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 4.8.1
• Component/s: spellchecker
• Labels: spellchecker
• Assignee: Unassigned
• Reporter: Spyros Kapnissis
• Created: 03/Jun/14 06:56
• Updated: 04/Jun/14 12:43

Description

The deprecated Token class is used everywhere in the spelling package. I am attaching a patch that refactors/replaces all occurrences with the AttributeSource class. The tests are passing.

Note: the AttributeSource class also replaces Token as a hash key in many places. Having stricter equals/hashCode requirements than Token, I am a bit concerned that it could produce some duplicate suggestions, especially in the case of ConjunctionSolrSpellChecker where merging of the different spell checking suggestions takes place. If this initial approach is fine, I can create some extra checks/unit tests for this.