Solr
  1. Solr
  2. SOLR-6130

solr-cell dependencies weren't fully upgraded with the Tika 1.4->1.5 upgrade

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.8
    • Fix Version/s: 4.8.2, 4.9, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      There are problems with the solr-cell dependency configuration:

      1. Despite the fact that the asm:asm dependency was removed in LUCENE-4263, and re-addition effectively vetoed by Uwe/Robert in SOLR-4209, asm:asm:3.1 was re-added with no apparent discussion by SOLR-1301 in Solr 4.7.
      2. The Tika 1.5 upgrade (SOLR-5763) failed to properly upgrade the asm:asm:3.1 dependency to org.ow2.asm:asm-debug-all:4.1 (see TIKA-1053).
      3. New Tika dependency com.uwyn:jhighlight:1.0 was not added.

      Uwe Schindler, do you have any opinions on the asm issues? In particular, would it make sense to have an additional asm dependency (asm-debug-all in addition to asm)?

        Issue Links

          Activity

          Hide
          Uwe Schindler added a comment - - edited

          In my opinion, support for .class file metadata in an solr idex is not really a use-case. It is an option for TIKA to extract metadata from class files, but for sure not really useful for the average user. Users that need to parse CLASS files can still add ASM to their lib folder.

          I still think: If we bundle TIKA, we should just include those parsers that are usefull for fulltext search. ASM is a very bad dependency, because every major version has significant changes in public classes, which make the jars incompatible to each other. A lot of projects use ASM and so classpath issues are very likely. I had lots of customers complaining that Maven pulled ASM for them in this old version.

          For this reason, forbidden-apis rewrites package names of ASM before bundling. Forbidden uses ASM 5 already, so 4.1 is also outdated (and incompatible to Java 8).

          Show
          Uwe Schindler added a comment - - edited In my opinion, support for .class file metadata in an solr idex is not really a use-case. It is an option for TIKA to extract metadata from class files, but for sure not really useful for the average user. Users that need to parse CLASS files can still add ASM to their lib folder. I still think: If we bundle TIKA, we should just include those parsers that are usefull for fulltext search. ASM is a very bad dependency, because every major version has significant changes in public classes, which make the jars incompatible to each other. A lot of projects use ASM and so classpath issues are very likely. I had lots of customers complaining that Maven pulled ASM for them in this old version. For this reason, forbidden-apis rewrites package names of ASM before bundling. Forbidden uses ASM 5 already, so 4.1 is also outdated (and incompatible to Java 8).
          Hide
          Steve Rowe added a comment - - edited

          This patch removes the extraction contrib's asm:asm dependency and adds com.uwyn:jhighlight. Committing shortly.

          Show
          Steve Rowe added a comment - - edited This patch removes the extraction contrib's asm:asm dependency and adds com.uwyn:jhighlight. Committing shortly.
          Hide
          ASF subversion and git services added a comment -

          Commit 1599663 from Steve Rowe in branch 'dev/trunk'
          [ https://svn.apache.org/r1599663 ]

          SOLR-6130: Added com.uwyn:jhighlight dependency to, and removed asm:asm dependency from the extraction contrib - dependencies weren't fully upgraded with the Tika 1.4->1.5 upgrade (SOLR-5763)

          Show
          ASF subversion and git services added a comment - Commit 1599663 from Steve Rowe in branch 'dev/trunk' [ https://svn.apache.org/r1599663 ] SOLR-6130 : Added com.uwyn:jhighlight dependency to, and removed asm:asm dependency from the extraction contrib - dependencies weren't fully upgraded with the Tika 1.4->1.5 upgrade ( SOLR-5763 )
          Hide
          ASF subversion and git services added a comment -

          Commit 1599672 from Steve Rowe in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1599672 ]

          SOLR-6130: Added com.uwyn:jhighlight dependency to, and removed asm:asm dependency from the extraction contrib - dependencies weren't fully upgraded with the Tika 1.4->1.5 upgrade (SOLR-5763) (merged trunk r1599663)

          Show
          ASF subversion and git services added a comment - Commit 1599672 from Steve Rowe in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1599672 ] SOLR-6130 : Added com.uwyn:jhighlight dependency to, and removed asm:asm dependency from the extraction contrib - dependencies weren't fully upgraded with the Tika 1.4->1.5 upgrade ( SOLR-5763 ) (merged trunk r1599663)
          Hide
          ASF subversion and git services added a comment -

          Commit 1600544 from Steve Rowe in branch 'dev/branches/lucene_solr_4_8'
          [ https://svn.apache.org/r1600544 ]

          SOLR-6130: Added com.uwyn:jhighlight dependency to, and removed asm:asm dependency from the extraction contrib - dependencies weren't fully upgraded with the Tika 1.4->1.5 upgrade (SOLR-5763) (merged trunk r1599663)

          Show
          ASF subversion and git services added a comment - Commit 1600544 from Steve Rowe in branch 'dev/branches/lucene_solr_4_8' [ https://svn.apache.org/r1600544 ] SOLR-6130 : Added com.uwyn:jhighlight dependency to, and removed asm:asm dependency from the extraction contrib - dependencies weren't fully upgraded with the Tika 1.4->1.5 upgrade ( SOLR-5763 ) (merged trunk r1599663)
          Hide
          Steve Rowe added a comment -

          Committed to trunk, branch_4x, and the lucene_solr_4_8 branch (in case there is a 4.8.2 release)

          Show
          Steve Rowe added a comment - Committed to trunk, branch_4x, and the lucene_solr_4_8 branch (in case there is a 4.8.2 release)

            People

            • Assignee:
              Steve Rowe
              Reporter:
              Steve Rowe
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development