Solr
  1. Solr
  2. SOLR-6129

DateFormatTransformer doesn't resolve dateTimeFormat

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.8.1
    • Fix Version/s: 4.9, 6.0
    • Labels:
      None

      Description

      The DateFormatTransformer doesn't use a VariableResolver to resolve the format, which could potentially be passed in via a dataimport request parameter. The attached patch is tested and working. Please include in 4.9.

      Thanks.

      1. SOLR-6129.patch
        2 kB
        Shalin Shekhar Mangar
      2. SOLR-6129.patch
        1 kB
        Aaron LaBella

        Activity

        Hide
        Aaron LaBella added a comment -

        Can someone have a look at this patch and hopefully commit it? I'm looking to get it in for the 4.9 release.
        Thanks.

        Show
        Aaron LaBella added a comment - Can someone have a look at this patch and hopefully commit it? I'm looking to get it in for the 4.9 release. Thanks.
        Hide
        Aaron LaBella added a comment -

        Anyone out there? This patch is ready to go – just needs someone to approve/accept/commit.
        Thanks.

        Show
        Aaron LaBella added a comment - Anyone out there? This patch is ready to go – just needs someone to approve/accept/commit. Thanks.
        Hide
        Shalin Shekhar Mangar added a comment -

        I have added a simple test.

        Show
        Shalin Shekhar Mangar added a comment - I have added a simple test.
        Hide
        ASF subversion and git services added a comment -

        Commit 1603209 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1603209 ]

        SOLR-6129: DateFormatTransformer doesn't resolve dateTimeFormat

        Show
        ASF subversion and git services added a comment - Commit 1603209 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1603209 ] SOLR-6129 : DateFormatTransformer doesn't resolve dateTimeFormat
        Hide
        ASF subversion and git services added a comment -

        Commit 1603210 from shalin@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1603210 ]

        SOLR-6129: DateFormatTransformer doesn't resolve dateTimeFormat

        Show
        ASF subversion and git services added a comment - Commit 1603210 from shalin@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1603210 ] SOLR-6129 : DateFormatTransformer doesn't resolve dateTimeFormat
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks for the reminder and the patch, Aaron!

        Show
        Shalin Shekhar Mangar added a comment - Thanks for the reminder and the patch, Aaron!
        Hide
        Aaron LaBella added a comment -

        excellent. thanks!!

        Show
        Aaron LaBella added a comment - excellent. thanks!!

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Aaron LaBella
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development