Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6129

DateFormatTransformer doesn't resolve dateTimeFormat

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 4.8.1
        • Fix Version/s: 4.9, 6.0
        • Component/s: contrib - DataImportHandler
        • Labels:
          None

          Description

          The DateFormatTransformer doesn't use a VariableResolver to resolve the format, which could potentially be passed in via a dataimport request parameter. The attached patch is tested and working. Please include in 4.9.

          Thanks.

          1. Text File
            SOLR-6129.patch
            2 kB
            Shalin Shekhar Mangar
          2. Text File
            SOLR-6129.patch
            1 kB
            Aaron LaBella

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            aaronlab Aaron LaBella added a comment -

            Can someone have a look at this patch and hopefully commit it? I'm looking to get it in for the 4.9 release.
            Thanks.

            Show
            aaronlab Aaron LaBella added a comment - Can someone have a look at this patch and hopefully commit it? I'm looking to get it in for the 4.9 release. Thanks.
            Hide
            Permalink
            aaronlab Aaron LaBella added a comment -

            Anyone out there? This patch is ready to go – just needs someone to approve/accept/commit.
            Thanks.

            Show
            aaronlab Aaron LaBella added a comment - Anyone out there? This patch is ready to go – just needs someone to approve/accept/commit. Thanks.
            Hide
            Permalink
            shalinmangar Shalin Shekhar Mangar added a comment -

            I have added a simple test.

            Show
            shalinmangar Shalin Shekhar Mangar added a comment - I have added a simple test.
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit 1603209 from shalin@apache.org in branch 'dev/trunk'
            [ https://svn.apache.org/r1603209 ]

            SOLR-6129: DateFormatTransformer doesn't resolve dateTimeFormat

            Show
            jira-bot ASF subversion and git services added a comment - Commit 1603209 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1603209 ] SOLR-6129 : DateFormatTransformer doesn't resolve dateTimeFormat
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit 1603210 from shalin@apache.org in branch 'dev/branches/branch_4x'
            [ https://svn.apache.org/r1603210 ]

            SOLR-6129: DateFormatTransformer doesn't resolve dateTimeFormat

            Show
            jira-bot ASF subversion and git services added a comment - Commit 1603210 from shalin@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1603210 ] SOLR-6129 : DateFormatTransformer doesn't resolve dateTimeFormat
            Hide
            Permalink
            shalinmangar Shalin Shekhar Mangar added a comment -

            Thanks for the reminder and the patch, Aaron!

            Show
            shalinmangar Shalin Shekhar Mangar added a comment - Thanks for the reminder and the patch, Aaron!
            Hide
            Permalink
            aaronlab Aaron LaBella added a comment -

            excellent. thanks!!

            Show
            aaronlab Aaron LaBella added a comment - excellent. thanks!!

              People

              • Assignee:
                shalinmangar Shalin Shekhar Mangar
                Reporter:
                aaronlab Aaron LaBella
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 1h
                  1h
                  Remaining:
                  Remaining Estimate - 1h
                  1h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified

                    Development