Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6013

Fix method visibility of Evaluator, refactor DateFormatEvaluator for extensibility

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 4.7
    • 4.9, 6.0
    • None

    Description

      This is similar to issue 5981, the Evaluator class is declared as abstract, yet the parseParams method is package private? Surely this is an oversight, as I wouldn't expect everyone writing their own evaluators to have to deal with parsing the parameters.

      Similarly, I needed to refactor DateFormatEvaluator because I need to do some custom date math/parsing and it wasn't written in a way that I can extend it.

      Please review/apply my attached patch to the next version of Solr, ie: 4.8 or 4.9 if I must wait.

      Thanks!

      Attachments

        1. SOLR-6013.patch
          10 kB
          Shalin Shekhar Mangar
        2. 0001-change-method-access-to-protected.patch
          4 kB
          Aaron LaBella
        3. 0001-add-getters-for-datemathparser.patch
          2 kB
          Aaron LaBella
        4. 0001-change-method-variable-visibility-and-refactor-for-extensibility.patch
          9 kB
          Aaron LaBella

        Activity

          People

            shalin Shalin Shekhar Mangar
            aaronlab Aaron LaBella
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified