Solr
  1. Solr
  2. SOLR-5914

Almost all Solr tests no longer cleanup their temp dirs on Windows

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 4.8
    • Fix Version/s: 4.8, 6.0
    • Component/s: Tests
    • Labels:
      None

      Description

      Recently the Windows Jenkins Build server has the problem of all-the time running out of disk space. This machine runs 2 workspaces (4.x and trunk) and has initially 8 Gigabytes of free SSD disk space.

      Because of the recently all-the time failing tests, the test framework does not forcefully clean up the "J0" working folders after running tests. This leads to the fact, that the workspace is filled with tons of Solr Home dirs. I tried this on my local machine:

      • run ant test
      • go to build/.../test/J0 and watch folders appearing: Almost every test no longer cleans up after shutting down, leaving a million of files there. This is approx 3 to 4 Gigabytes!!!

      In Lucene the folders are correctly removed. This has happened recently, so i think we have some code like (Erick Erickson !!!):
      new Properties().load(new FileInputStream(...)) that does not close the files. Because of this, the test's afterClass cannot clean up folders anymore. If you look in the test log, you see messages like "!!!! WARNING: best effort to remove C:\Users\JenkinsSlave\workspace\Lucene-Solr-4.x-Windows\solr\build\solr-core\test\J0\.\org.apache.solr.cloud.TestShortCircuitedRequests-1395693845226 FAILED !!!!!" all the time.

      So if anybody committed some changes that might not close files correctly, please fix! Otherwise I have to disable testing on windows - and I will no longer run solr, tests, too: My local computer also uses gigabytes of temp space after running tests!

      1. branch4x-jenkins.png
        152 kB
        Uwe Schindler
      2. build-plugin.jpg
        79 kB
        Uwe Schindler
      3. SOLR-5914 .patch
        16 kB
        Mark Miller
      4. SOLR-5914 .patch
        17 kB
        Mark Miller
      5. trunk-jenkins.png
        154 kB
        Uwe Schindler

        Issue Links

          Activity

          Hide
          Uwe Schindler added a comment -

          Screenshots from the Windows Jenkins VM after out of disk space.

          Show
          Uwe Schindler added a comment - Screenshots from the Windows Jenkins VM after out of disk space.
          Hide
          Dawid Weiss added a comment -

          Perhaps we should change and instead of a warning throw a regular failure if something cannot be cleaned up?

          Show
          Dawid Weiss added a comment - Perhaps we should change and instead of a warning throw a regular failure if something cannot be cleaned up?
          Hide
          Erick Erickson added a comment -

          Uwe Schindler Wait, are you saying this is something I recently committed? Or just referencing one of my more stellar moments?

          Show
          Erick Erickson added a comment - Uwe Schindler Wait, are you saying this is something I recently committed? Or just referencing one of my more stellar moments?
          Hide
          Dawid Weiss added a comment -

          No fingerpointing

          Let's try to make the tests better and life easier. I believe tests should clean up after they're done. When a test is successful, it should remove any directories or files it's created, simple. There is some infrastructure we could utilize for creating temp files and resources, such as:

          https://github.com/carrotsearch/randomizedtesting/blob/master/randomized-runner/src/main/java/com/carrotsearch/randomizedtesting/RandomizedTest.java#L371

          Specifically, after a suite class completes (successfully), this File should be removable:

          https://github.com/carrotsearch/randomizedtesting/blob/master/randomized-runner/src/main/java/com/carrotsearch/randomizedtesting/RandomizedTest.java#L266

          Show
          Dawid Weiss added a comment - No fingerpointing Let's try to make the tests better and life easier. I believe tests should clean up after they're done. When a test is successful, it should remove any directories or files it's created, simple. There is some infrastructure we could utilize for creating temp files and resources, such as: https://github.com/carrotsearch/randomizedtesting/blob/master/randomized-runner/src/main/java/com/carrotsearch/randomizedtesting/RandomizedTest.java#L371 Specifically, after a suite class completes (successfully), this File should be removable: https://github.com/carrotsearch/randomizedtesting/blob/master/randomized-runner/src/main/java/com/carrotsearch/randomizedtesting/RandomizedTest.java#L266
          Hide
          Uwe Schindler added a comment -

          Or just referencing one of my more stellar moments?

          That one

          Show
          Uwe Schindler added a comment - Or just referencing one of my more stellar moments? That one
          Hide
          Mark Miller added a comment -

          Dawid Weiss added a comment - Today 10:32
          Perhaps we should change and instead of a warning throw a regular failure if something cannot be cleaned up?

          +1

          Show
          Mark Miller added a comment - Dawid Weiss added a comment - Today 10:32 Perhaps we should change and instead of a warning throw a regular failure if something cannot be cleaned up? +1
          Hide
          Yonik Seeley added a comment -

          Perhaps we should change and instead of a warning throw a regular failure if something cannot be cleaned up?

          +1, failure to clean up on windows can often be indicative of a real bug.

          Show
          Yonik Seeley added a comment - Perhaps we should change and instead of a warning throw a regular failure if something cannot be cleaned up? +1, failure to clean up on windows can often be indicative of a real bug.
          Hide
          Dawid Weiss added a comment -

          I'll try to look into it.

          Show
          Dawid Weiss added a comment - I'll try to look into it.
          Hide
          Uwe Schindler added a comment -

          I think we just have to change the warning printed all the time (see issue description) to be a failure?

          Show
          Uwe Schindler added a comment - I think we just have to change the warning printed all the time (see issue description) to be a failure?
          Hide
          Mark Miller added a comment -

          Looking at a couple tests real quick, I've seen ZooKeeper files not cleaned up and tlog files not cleaned up.

          Show
          Mark Miller added a comment - Looking at a couple tests real quick, I've seen ZooKeeper files not cleaned up and tlog files not cleaned up.
          Hide
          Mark Miller added a comment -

          Looking at a couple tests real quick, I've seen ZooKeeper files not cleaned up and tlog files not cleaned up.

          That mostly looks like it's because our clean up code is a bit of a mess - I'll straighten it up.

          Show
          Mark Miller added a comment - Looking at a couple tests real quick, I've seen ZooKeeper files not cleaned up and tlog files not cleaned up. That mostly looks like it's because our clean up code is a bit of a mess - I'll straighten it up.
          Hide
          Uwe Schindler added a comment -

          As a workaround I added the following post-build set on the windows Jenkins machines. This means that the test working folder are nuked when the build is done. This is not ideal, because we can no longer check what happened on windows builds, but this is the only possibility to work around this issue until the test bugs are fixed.

          Show
          Uwe Schindler added a comment - As a workaround I added the following post-build set on the windows Jenkins machines. This means that the test working folder are nuked when the build is done. This is not ideal, because we can no longer check what happened on windows builds, but this is the only possibility to work around this issue until the test bugs are fixed.
          Hide
          Mark Miller added a comment -

          Here is a patch that cleans up the clean up code.

          Show
          Mark Miller added a comment - Here is a patch that cleans up the clean up code.
          Hide
          Mark Miller added a comment -

          Fixes TestSolrEntityProcessorEndToEnd.

          Show
          Mark Miller added a comment - Fixes TestSolrEntityProcessorEndToEnd.
          Hide
          ASF subversion and git services added a comment -

          Commit 1582038 from Mark Miller in branch 'dev/trunk'
          [ https://svn.apache.org/r1582038 ]

          SOLR-5914: Cleanup and fix Solr's test cleanup code.

          Show
          ASF subversion and git services added a comment - Commit 1582038 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1582038 ] SOLR-5914 : Cleanup and fix Solr's test cleanup code.
          Hide
          ASF subversion and git services added a comment -

          Commit 1582042 from Mark Miller in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1582042 ]

          SOLR-5914: Cleanup and fix Solr's test cleanup code.

          Show
          ASF subversion and git services added a comment - Commit 1582042 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1582042 ] SOLR-5914 : Cleanup and fix Solr's test cleanup code.
          Hide
          Mark Miller added a comment -

          That's a good start - my Windows VM likes it so far.

          Show
          Mark Miller added a comment - That's a good start - my Windows VM likes it so far.
          Hide
          Uwe Schindler added a comment -

          Thanks Mark.

          Is it ok to remove the forceful cleanup after the Jenkins build? Means: We no longer create 3 Gigabytes of data per test run?

          Show
          Uwe Schindler added a comment - Thanks Mark. Is it ok to remove the forceful cleanup after the Jenkins build? Means: We no longer create 3 Gigabytes of data per test run?
          Hide
          Mark Miller added a comment -

          Yeah, we should have proper cleanup, except for the spellcheck tests. Let's see how it pans out.

          Show
          Mark Miller added a comment - Yeah, we should have proper cleanup, except for the spellcheck tests. Let's see how it pans out.
          Hide
          Uwe Schindler added a comment - - edited

          Hi Mark,

          thanks. I started a new build. It looks better now, but its still generating > 2 GB data while running solr-core tests, so not everything is covered by the cleanup. Here is a live "dir" shortly before the tests succeeded:

          C:\Users\JenkinsSlave\workspace\Lucene-Solr-trunk-Windows\solr\build\solr-core\test>dir J0
           Volume in drive C is HARDDISK
           Volume Serial Number is 58F1-5382
          
           Directory of C:\Users\JenkinsSlave\workspace\Lucene-Solr-trunk-Windows\solr\build\solr-core\test\J0
          
          2014-03-26  23:03    <DIR>          .
          2014-03-26  23:03    <DIR>          ..
          2014-03-26  22:14    <DIR>          1395872092623-0
          2014-03-26  22:51    <DIR>          alternateIdx1395874264370
          2014-03-26  23:02    <DIR>          badConfigSet
          2014-03-26  22:22    <DIR>          ChangedSchemaMergeTest
          2014-03-26  23:02    <DIR>          core-reload
          2014-03-26  22:15    <DIR>          data
          2014-03-26  23:02    <DIR>          findsConfigSets
          2014-03-26  22:14    <DIR>          managed
          2014-03-26  22:18    <DIR>          org.apache.solr.cloud.AliasIntegrationTest-1395872282539
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.AliasIntegrationTest-controljetty-1395872282776
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.AliasIntegrationTest-jetty1-1395872286276
          2014-03-26  22:18    <DIR>          org.apache.solr.cloud.AliasIntegrationTest-jetty2-1395872290964
          2014-03-26  22:18    <DIR>          org.apache.solr.cloud.AliasIntegrationTest-jetty3-1395872295741
          2014-03-26  22:36    <DIR>          org.apache.solr.cloud.AsyncMigrateRouteKeyTest-1395873396484
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.AsyncMigrateRouteKeyTest-controljetty-1395873396662
          2014-03-26  22:37    <DIR>          org.apache.solr.cloud.AsyncMigrateRouteKeyTest-jetty1-1395873399601
          2014-03-26  22:37    <DIR>          org.apache.solr.cloud.AsyncMigrateRouteKeyTest-jetty2-1395873403459
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.AsyncMigrateRouteKeyTest-jetty3-1395873407351
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.AsyncMigrateRouteKeyTest-jetty4-1395873411574
          2014-03-26  22:25    <DIR>          org.apache.solr.cloud.BasicDistributedZk2Test-1395872669978
          2014-03-26  22:25    <DIR>          org.apache.solr.cloud.BasicDistributedZk2Test-backupdir-1395872721159
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.BasicDistributedZk2Test-controljetty-1395872670179
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.BasicDistributedZk2Test-jetty1-1395872673905
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.BasicDistributedZk2Test-jetty2-1395872677749
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.BasicDistributedZk2Test-jetty3-1395872681517
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.BasicDistributedZk2Test-jetty4-1395872685545
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.BasicDistributedZk2Test-jetty5-1395872721863
          2014-03-26  22:39    <DIR>          org.apache.solr.cloud.BasicDistributedZkTest-1395873576104
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.BasicDistributedZkTest-controljetty-1395873576286
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.BasicDistributedZkTest-jetty1-1395873579528
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.BasicDistributedZkTest-jetty2-1395873583401
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.BasicDistributedZkTest-jetty3-1395873586925
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.BasicDistributedZkTest-jetty4-1395873590539
          2014-03-26  22:52    <DIR>          org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-1395874307115
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-controljetty-1395874307338
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-jetty1-1395874311142
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-jetty2-1395874315747
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-jetty3-1395874320123
          2014-03-26  22:52    <DIR>          org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-jetty4-1395874324288
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-jetty5-1395874328202
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-jetty6-1395874332189
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-jetty7-1395874336606
          2014-03-26  22:53    <DIR>          org.apache.solr.cloud.CollectionsAPIAsyncDistributedZkTest-1395874432351
          2014-03-26  22:54    <DIR>          org.apache.solr.cloud.CollectionsAPIAsyncDistributedZkTest-controljetty-1395874432556
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.CollectionsAPIAsyncDistributedZkTest-jetty1-1395874436525
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.CollectionsAPIAsyncDistributedZkTest-jetty2-1395874441514
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.CollectionsAPIAsyncDistributedZkTest-jetty3-1395874446349
          2014-03-26  22:54    <DIR>          org.apache.solr.cloud.CollectionsAPIAsyncDistributedZkTest-jetty4-1395874450968
          2014-03-26  22:26    <DIR>          org.apache.solr.cloud.CollectionsAPIDistributedZkTest-1395872769742
          2014-03-26  22:28    <DIR>          org.apache.solr.cloud.CollectionsAPIDistributedZkTest-controljetty-1395872769991
          2014-03-26  22:28    <DIR>          org.apache.solr.cloud.CollectionsAPIDistributedZkTest-jetty1-1395872773183
          2014-03-26  22:28    <DIR>          org.apache.solr.cloud.CollectionsAPIDistributedZkTest-jetty2-1395872777010
          2014-03-26  22:28    <DIR>          org.apache.solr.cloud.CollectionsAPIDistributedZkTest-jetty3-1395872780620
          2014-03-26  22:28    <DIR>          org.apache.solr.cloud.CollectionsAPIDistributedZkTest-jetty4-1395872784271
          2014-03-26  22:32    <DIR>          org.apache.solr.cloud.CustomCollectionTest-1395873153259
          2014-03-26  22:33    <DIR>          org.apache.solr.cloud.CustomCollectionTest-controljetty-1395873153469
          2014-03-26  22:33    <DIR>          org.apache.solr.cloud.CustomCollectionTest-jetty1-1395873157398
          2014-03-26  22:33    <DIR>          org.apache.solr.cloud.CustomCollectionTest-jetty2-1395873162252
          2014-03-26  22:33    <DIR>          org.apache.solr.cloud.CustomCollectionTest-jetty3-1395873167251
          2014-03-26  22:33    <DIR>          org.apache.solr.cloud.CustomCollectionTest-jetty4-1395873172036
          2014-03-26  22:37    <DIR>          org.apache.solr.cloud.DeleteInactiveReplicaTest-1395873465635
          2014-03-26  22:38    <DIR>          org.apache.solr.cloud.DeleteInactiveReplicaTest-controljetty-1395873465859
          2014-03-26  22:38    <DIR>          org.apache.solr.cloud.DeleteInactiveReplicaTest-jetty1-1395873469262
          2014-03-26  22:38    <DIR>          org.apache.solr.cloud.DeleteInactiveReplicaTest-jetty2-1395873473633
          2014-03-26  22:38    <DIR>          org.apache.solr.cloud.DeleteInactiveReplicaTest-jetty3-1395873477736
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.DeleteInactiveReplicaTest-jetty4-1395873481815
          2014-03-26  22:16    <DIR>          org.apache.solr.cloud.DeleteReplicaTest-1395872184784
          2014-03-26  22:16    <DIR>          org.apache.solr.cloud.DeleteReplicaTest-controljetty-1395872185090
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.DeleteReplicaTest-jetty1-1395872190049
          2014-03-26  22:16    <DIR>          org.apache.solr.cloud.DeleteReplicaTest-jetty2-1395872195139
          2014-03-26  22:16    <DIR>          org.apache.solr.cloud.DeleteReplicaTest-jetty3-1395872200076
          2014-03-26  22:16    <DIR>          org.apache.solr.cloud.DeleteReplicaTest-jetty4-1395872204810
          2014-03-26  22:34    <DIR>          org.apache.solr.cloud.DeleteShardTest-1395873269920
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.DeleteShardTest-controljetty-1395873270159
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.DeleteShardTest-jetty1-1395873273799
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.DeleteShardTest-jetty2-1395873278330
          2014-03-26  22:54    <DIR>          org.apache.solr.cloud.DistribCursorPagingTest-1395874470943
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.DistribCursorPagingTest-controljetty-1395874471153
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.DistribCursorPagingTest-jetty1-1395874474981
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.DistribCursorPagingTest-jetty2-1395874479793
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.DistribCursorPagingTest-jetty3-1395874484627
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.DistribCursorPagingTest-jetty4-1395874489820
          2014-03-26  22:31    <DIR>          org.apache.solr.cloud.FullSolrCloudDistribCmdsTest-1395873081563
          2014-03-26  22:32    <DIR>          org.apache.solr.cloud.FullSolrCloudDistribCmdsTest-controljetty-1395873081829
          2014-03-26  22:32    <DIR>          org.apache.solr.cloud.FullSolrCloudDistribCmdsTest-jetty1-1395873085733
          2014-03-26  22:32    <DIR>          org.apache.solr.cloud.FullSolrCloudDistribCmdsTest-jetty2-1395873090044
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.FullSolrCloudDistribCmdsTest-jetty3-1395873094283
          2014-03-26  22:32    <DIR>          org.apache.solr.cloud.FullSolrCloudDistribCmdsTest-jetty4-1395873098475
          2014-03-26  22:32    <DIR>          org.apache.solr.cloud.FullSolrCloudDistribCmdsTest-jetty5-1395873102796
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.FullSolrCloudDistribCmdsTest-jetty6-1395873107325
          2014-03-26  22:55    <DIR>          org.apache.solr.cloud.MigrateRouteKeyTest-1395874516302
          2014-03-26  22:55    <DIR>          org.apache.solr.cloud.MigrateRouteKeyTest-controljetty-1395874516484
          2014-03-26  22:55    <DIR>          org.apache.solr.cloud.MigrateRouteKeyTest-jetty1-1395874519611
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.MigrateRouteKeyTest-jetty2-1395874523732
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.MigrateRouteKeyTest-jetty3-1395874527584
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.MigrateRouteKeyTest-jetty4-1395874531206
          2014-03-26  22:57    <DIR>          org.apache.solr.cloud.OverseerRolesTest-1395874575057
          2014-03-26  22:56    <DIR>          org.apache.solr.cloud.OverseerRolesTest-controljetty-1395874575320
          2014-03-26  22:56    <DIR>          org.apache.solr.cloud.OverseerRolesTest-jetty1-1395874579843
          2014-03-26  22:56    <DIR>          org.apache.solr.cloud.OverseerRolesTest-jetty2-1395874585458
          2014-03-26  22:56    <DIR>          org.apache.solr.cloud.OverseerRolesTest-jetty3-1395874591401
          2014-03-26  22:56    <DIR>          org.apache.solr.cloud.OverseerRolesTest-jetty4-1395874597692
          2014-03-26  22:56    <DIR>          org.apache.solr.cloud.OverseerRolesTest-jetty5-1395874603870
          2014-03-26  22:56    <DIR>          org.apache.solr.cloud.OverseerRolesTest-jetty6-1395874609504
          2014-03-26  22:23    <DIR>          org.apache.solr.cloud.OverseerStatusTest-1395872580782
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.OverseerStatusTest-controljetty-1395872580999
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.OverseerStatusTest-jetty1-1395872584409
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.OverseerStatusTest-jetty2-1395872588669
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.OverseerStatusTest-jetty3-1395872592777
          2014-03-26  22:23    <DIR>          org.apache.solr.cloud.OverseerStatusTest-jetty4-1395872596435
          2014-03-26  22:42    <DIR>          org.apache.solr.cloud.RecoveryZkTest-1395873762003
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.RecoveryZkTest-controljetty-1395873762283
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.RecoveryZkTest-jetty1-1395873766994
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.RecoveryZkTest-jetty2-1395873772754
          2014-03-26  22:24    <DIR>          org.apache.solr.cloud.RemoteQueryErrorTest-1395872621201
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.RemoteQueryErrorTest-controljetty-1395872621447
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.RemoteQueryErrorTest-jetty1-1395872625507
          2014-03-26  22:24    <DIR>          org.apache.solr.cloud.RemoteQueryErrorTest-jetty2-1395872630507
          2014-03-26  22:24    <DIR>          org.apache.solr.cloud.RemoteQueryErrorTest-jetty3-1395872636158
          2014-03-26  22:19    <DIR>          org.apache.solr.cloud.ShardRoutingCustomTest-1395872358405
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ShardRoutingCustomTest-controljetty-1395872358648
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ShardRoutingCustomTest-jetty1-1395872362534
          2014-03-26  22:29    <DIR>          org.apache.solr.cloud.ShardRoutingTest-1395872906293
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ShardRoutingTest-controljetty-1395872906517
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ShardRoutingTest-jetty1-1395872910026
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ShardRoutingTest-jetty2-1395872914490
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ShardRoutingTest-jetty3-1395872919050
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ShardRoutingTest-jetty4-1395872923562
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ShardRoutingTest-jetty5-1395872928627
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ShardRoutingTest-jetty6-1395872933434
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ShardRoutingTest-jetty7-1395872938064
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.ShardRoutingTest-jetty8-1395872942440
          2014-03-26  22:58    <DIR>          org.apache.solr.cloud.ShardSplitTest-1395874669896
          2014-03-26  22:59    <DIR>          org.apache.solr.cloud.ShardSplitTest-controljetty-1395874670069
          2014-03-26  22:58    <DIR>          org.apache.solr.cloud.ShardSplitTest-jetty1-1395874673104
          2014-03-26  22:59    <DIR>          org.apache.solr.cloud.ShardSplitTest-jetty2-1395874677188
          2014-03-26  22:58    <DIR>          org.apache.solr.cloud.ShardSplitTest-jetty3-1395874681049
          2014-03-26  22:59    <DIR>          org.apache.solr.cloud.ShardSplitTest-jetty4-1395874685037
          2014-03-26  22:57    <DIR>          org.apache.solr.cloud.SSLMigrationTest-1395874630695
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.SSLMigrationTest-controljetty-1395874630907
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.SSLMigrationTest-jetty1-1395874634153
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.SSLMigrationTest-jetty2-1395874638133
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.SSLMigrationTest-jetty3-1395874642015
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.SSLMigrationTest-jetty4-1395874645693
          2014-03-26  22:35    <DIR>          org.apache.solr.cloud.SyncSliceTest-1395873298880
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.SyncSliceTest-controljetty-1395873299093
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.SyncSliceTest-jetty1-1395873302366
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.SyncSliceTest-jetty2-1395873306431
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.SyncSliceTest-jetty3-1395873310382
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.SyncSliceTest-jetty4-1395873314162
          2014-03-26  23:00    <DIR>          org.apache.solr.cloud.TestDistribDocBasedVersion-1395874782399
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestDistribDocBasedVersion-controljetty-1395874782652
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestDistribDocBasedVersion-jetty1-1395874786890
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestDistribDocBasedVersion-jetty2-1395874791637
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestDistribDocBasedVersion-jetty3-1395874796422
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestDistribDocBasedVersion-jetty4-1395874800888
          2014-03-26  22:20    <DIR>          org.apache.solr.cloud.TestModifyConfFiles-1395872429293
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestModifyConfFiles-controljetty-1395872429555
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestModifyConfFiles-jetty1-1395872433940
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestModifyConfFiles-jetty2-1395872439551
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestModifyConfFiles-jetty3-1395872444054
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestModifyConfFiles-jetty4-1395872448716
          2014-03-26  22:36    <DIR>          org.apache.solr.cloud.TestRequestStatusCollectionAPI-1395873369032
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestRequestStatusCollectionAPI-controljetty-1395873369293
          2014-03-26  22:36    <DIR>          org.apache.solr.cloud.TestRequestStatusCollectionAPI-jetty1-1395873373119
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestRequestStatusCollectionAPI-jetty2-1395873377467
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestRequestStatusCollectionAPI-jetty3-1395873381763
          2014-03-26  22:36    <DIR>          org.apache.solr.cloud.TestRequestStatusCollectionAPI-jetty4-1395873385686
          2014-03-26  22:17    <DIR>          org.apache.solr.cloud.TestShortCircuitedRequests-1395872233140
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestShortCircuitedRequests-controljetty-1395872233358
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestShortCircuitedRequests-jetty1-1395872236934
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestShortCircuitedRequests-jetty2-1395872241635
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestShortCircuitedRequests-jetty3-1395872246453
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TestShortCircuitedRequests-jetty4-1395872251632
          2014-03-26  23:01    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-1395874815901
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-controljetty-1395874816084
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty1-1395874818914
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty10-1395874846280
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty11-1395874849202
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty12-1395874852320
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty13-1395874855705
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty14-1395874859035
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty15-1395874862723
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty16-1395874867046
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty17-1395874871870
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty18-1395874876210
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty19-1395874880819
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty2-1395874822466
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty20-1395874885941
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty21-1395874891003
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty22-1395874896108
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty23-1395874901734
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty24-1395874907454
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty3-1395874825873
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty4-1395874829053
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty5-1395874832242
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty6-1395874835169
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty7-1395874838032
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty8-1395874840695
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty9-1395874843398
          2014-03-26  22:41    <DIR>          org.apache.solr.cloud.UnloadDistributedZkTest-1395873668638
          2014-03-26  01:25    <DIR>          org.apache.solr.cloud.UnloadDistributedZkTest-controljetty-1395873668829
          2014-03-26  22:42    <DIR>          org.apache.solr.cloud.UnloadDistributedZkTest-jetty1-1395873671999
          2014-03-26  22:41    <DIR>          org.apache.solr.cloud.UnloadDistributedZkTest-jetty2-1395873676015
          2014-03-26  22:41    <DIR>          org.apache.solr.cloud.UnloadDistributedZkTest-jetty3-1395873679981
          2014-03-26  22:41    <DIR>          org.apache.solr.cloud.UnloadDistributedZkTest-jetty4-1395873683716
          2014-03-26  22:51    <DIR>          org.apache.solr.core.TestArbitraryIndexDir-1395874280112
          2014-03-26  01:25    <DIR>          org.apache.solr.core.TestCoreContainer_classLoaderHierarchy
          2014-03-26  01:25    <DIR>          org.apache.solr.core.TestCoreContainer_reloadSequential
          2014-03-26  01:25    <DIR>          org.apache.solr.core.TestCoreContainer_reloadThreaded
          2014-03-26  01:25    <DIR>          org.apache.solr.core.TestCoreContainer_shareSchema
          2014-03-26  22:50    <DIR>          org.apache.solr.core.TestCoreDiscovery
          2014-03-26  23:02    <DIR>          org.apache.solr.core.TestSolrXml
          2014-03-26  22:50    <DIR>          org.apache.solr.handler.admin.CoreAdminHandlerTest-corex-1395874238332
          2014-03-26  23:02    <DIR>          org.apache.solr.handler.admin.CoreAdminRequestStatusTest
          2014-03-26  23:02    <DIR>          org.apache.solr.handler.component.DistributedExpandComponentTest-1395874957439
          2014-03-26  22:37    <DIR>          org.apache.solr.handler.component.DistributedQueryComponentCustomSortTest-1395873461156
          2014-03-26  23:02    <DIR>          org.apache.solr.handler.component.DistributedQueryComponentOptimizationTest-1395874964419
          2014-03-26  22:17    <DIR>          org.apache.solr.handler.component.DistributedQueryElevationComponentTest-1395872262687
          2014-03-26  22:46    <DIR>          org.apache.solr.handler.component.DistributedSpellCheckComponentTest-1395873972866
          2014-03-26  23:02    <DIR>          org.apache.solr.handler.component.DistributedSuggestComponentTest-1395874967878
          2014-03-26  22:48    <DIR>          org.apache.solr.handler.component.DistributedTermsComponentTest-1395874121982
          2014-03-26  22:46    <DIR>          org.apache.solr.handler.component.TermVectorComponentDistributedTest-1395873985101
          2014-03-26  22:18    <DIR>          org.apache.solr.schema.TestCloudManagedSchema-1395872325756
          2014-03-26  01:25    <DIR>          org.apache.solr.schema.TestCloudManagedSchema-controljetty-1395872325952
          2014-03-26  01:25    <DIR>          org.apache.solr.schema.TestCloudManagedSchema-jetty1-1395872329525
          2014-03-26  01:25    <DIR>          org.apache.solr.schema.TestCloudManagedSchema-jetty2-1395872334206
          2014-03-26  01:25    <DIR>          org.apache.solr.schema.TestCloudManagedSchema-jetty3-1395872338940
          2014-03-26  01:25    <DIR>          org.apache.solr.schema.TestCloudManagedSchema-jetty4-1395872344228
          2014-03-26  22:29    <DIR>          org.apache.solr.schema.TestCloudManagedSchemaAddField-1395872965843
          2014-03-26  01:25    <DIR>          org.apache.solr.schema.TestCloudManagedSchemaAddField-controljetty-1395872966121
          2014-03-26  01:25    <DIR>          org.apache.solr.schema.TestCloudManagedSchemaAddField-jetty1-1395872969983
          2014-03-26  01:25    <DIR>          org.apache.solr.schema.TestCloudManagedSchemaAddField-jetty2-1395872974755
          2014-03-26  01:25    <DIR>          org.apache.solr.schema.TestCloudManagedSchemaAddField-jetty3-1395872980253
          2014-03-26  01:25    <DIR>          org.apache.solr.schema.TestCloudManagedSchemaAddField-jetty4-1395872986370
          2014-03-26  01:25    <DIR>          org.apache.solr.schema.TestCloudManagedSchemaAddField-jetty5-1395872991156
          2014-03-26  01:25    <DIR>          org.apache.solr.schema.TestCloudManagedSchemaAddField-jetty6-1395872995862
          2014-03-26  01:25    <DIR>          org.apache.solr.schema.TestCloudManagedSchemaAddField-jetty7-1395873000361
          2014-03-26  01:25    <DIR>          org.apache.solr.schema.TestCloudManagedSchemaAddField-jetty8-1395873004604
          2014-03-26  22:45    <DIR>          org.apache.solr.TestDistributedGrouping-1395873933434
          2014-03-26  22:53    <DIR>          org.apache.solr.TestDistributedMissingSort-1395874378367
          2014-03-26  22:45    <DIR>          org.apache.solr.TestDistributedSearch-1395873900301
          2014-03-26  22:53    <DIR>          org.apache.solr.TestHighlightDedupGrouping-1395874387200
          2014-03-26  22:21    <DIR>          org.apache.solr.update.PeerSyncTest-1395872507319
          2014-03-26  22:49    <DIR>          org.apache.solr.update.SolrCmdDistributorTest-1395874180178
          2014-03-26  22:34    <DIR>          org.apache.solr.update.SolrIndexSplitterTesttestSplitByRouteKey
          2014-03-26  22:34    <DIR>          org.apache.solr.update.SolrIndexSplitterTest_testSplit1
          2014-03-26  22:34    <DIR>          org.apache.solr.update.SolrIndexSplitterTest_testSplit2
          2014-03-26  22:34    <DIR>          org.apache.solr.update.SolrIndexSplitterTest_testSplit3
          2014-03-26  22:21    <DIR>          solrHome
          2014-03-26  23:03    <DIR>          solrtest-BJQParserTest-1395875032523
          2014-03-26  22:21    <DIR>          solrtest-confdropspot-org.apache.solr.cloud.ZkCLITest-1395872486763
          2014-03-26  22:15    <DIR>          solrtest-DirectSolrSpellCheckerTest-1395872150183
          2014-03-26  22:21                16 solrtest-getfile-org.apache.solr.cloud.ZkCLITest-1395872466806
          2014-03-26  22:38    <DIR>          solrtest-LeaderElectionIntegrationTest-1395873511273
          2014-03-26  22:49    <DIR>          solrtest-QueryElevationComponentTest-1395874186376
          2014-03-26  22:49    <DIR>          solrtest-QueryElevationComponentTest-1395874186956
          2014-03-26  22:49    <DIR>          solrtest-QueryElevationComponentTest-1395874187677
          2014-03-26  22:49    <DIR>          solrtest-QueryElevationComponentTest-1395874188395
          2014-03-26  22:49    <DIR>          solrtest-QueryElevationComponentTest-1395874189158
          2014-03-26  22:49    <DIR>          solrtest-QueryElevationComponentTest-1395874189563
          2014-03-26  22:49    <DIR>          solrtest-QueryElevationComponentTest-1395874190215
          2014-03-26  22:50    <DIR>          solrtest-SolrCoreCheckLockOnStartupTest-1395874251121
          2014-03-26  22:59    <DIR>          solrtest-SolrXmlInZkTest-1395874762339
          2014-03-26  22:59    <DIR>          solrtest-SolrXmlInZkTest-1395874765727
          2014-03-26  22:59    <DIR>          solrtest-SolrXmlInZkTest-1395874769144
          2014-03-26  22:59    <DIR>          solrtest-SolrXmlInZkTest-1395874772554
          2014-03-26  22:59    <DIR>          solrtest-SolrXmlInZkTest-1395874775852
          2014-03-26  22:50    <DIR>          solrtest-SpellCheckCollatorTest-1395874233679
          2014-03-26  22:31    <DIR>          solrtest-SpellCheckComponentTest-1395873075489
          2014-03-26  22:51    <DIR>          solrtest-TestBinaryField-1395874298057
          2014-03-26  22:34    <DIR>          solrtest-TestManagedSchema-1395873255904
          2014-03-26  22:34    <DIR>          solrtest-TestManagedSchema-1395873256355
          2014-03-26  22:34    <DIR>          solrtest-TestManagedSchema-1395873256836
          2014-03-26  22:34    <DIR>          solrtest-TestManagedSchema-1395873257356
          2014-03-26  22:34    <DIR>          solrtest-TestManagedSchema-1395873257803
          2014-03-26  22:34    <DIR>          solrtest-TestManagedSchema-1395873258330
          2014-03-26  22:34    <DIR>          solrtest-TestManagedSchema-1395873258908
          2014-03-26  22:34    <DIR>          solrtest-TestManagedSchema-1395873259187
          2014-03-26  22:34    <DIR>          solrtest-TestManagedSchema-1395873259693
          2014-03-26  22:34    <DIR>          solrtest-TestManagedSchema-1395873260202
          2014-03-26  22:34    <DIR>          solrtest-TestManagedSchema-1395873260698
          2014-03-26  22:34    <DIR>          solrtest-TestManagedSchema-1395873260969
          2014-03-26  22:34    <DIR>          solrtest-TestManagedSchema-1395873261644
          2014-03-26  23:03    <DIR>          solrtest-TestManagedSchemaFieldResource-1395874989522
          2014-03-26  23:03    <DIR>          solrtest-TestManagedSchemaFieldResource-1395874992882
          2014-03-26  23:03    <DIR>          solrtest-TestManagedSchemaFieldResource-1395874995751
          2014-03-26  23:03    <DIR>          solrtest-TestManagedSchemaFieldResource-1395874998489
          2014-03-26  23:03    <DIR>          solrtest-TestManagedSchemaFieldResource-1395875001264
          2014-03-26  23:03    <DIR>          solrtest-TestManagedSchemaFieldResource-1395875004013
          2014-03-26  23:03    <DIR>          solrtest-TestManagedSchemaFieldResource-1395875006771
          2014-03-26  23:03    <DIR>          solrtest-TestManagedSchemaFieldResource-1395875009382
          2014-03-26  23:03    <DIR>          solrtest-TestManagedSchemaFieldResource-1395875011983
          2014-03-26  22:36    <DIR>          solrtest-TestSolrCoreProperties-1395873363377
          2014-03-26  22:14    <DIR>          solrtest-TestSolrXmlPersistence-1395872078098
          2014-03-26  22:44    <DIR>          solrtest-TestZkChroot-1395873858625
          2014-03-26  22:44    <DIR>          solrtest-TestZkChroot-1395873863542
          2014-03-26  22:44    <DIR>          solrtest-TestZkChroot-1395873865854
          2014-03-26  22:17    <DIR>          solrtest-WordBreakSolrSpellCheckerTest-1395872222378
          2014-03-26  22:21    <DIR>          solrtest-ZkCLITest-1395872459648
          2014-03-26  22:21    <DIR>          solrtest-ZkCLITest-1395872463281
          2014-03-26  22:21    <DIR>          solrtest-ZkCLITest-1395872466680
          2014-03-26  22:21    <DIR>          solrtest-ZkCLITest-1395872469063
          2014-03-26  22:21    <DIR>          solrtest-ZkCLITest-1395872472217
          2014-03-26  22:21    <DIR>          solrtest-ZkCLITest-1395872474359
          2014-03-26  22:21    <DIR>          solrtest-ZkCLITest-1395872476496
          2014-03-26  22:21    <DIR>          solrtest-ZkCLITest-1395872479370
          2014-03-26  22:21    <DIR>          solrtest-ZkCLITest-1395872482653
          2014-03-26  22:21    <DIR>          solrtest-ZkCLITest-1395872485943
          2014-03-26  22:21    <DIR>          solrtest-ZkCLITest-1395872489827
          2014-03-26  22:23    <DIR>          spellingIdx1395872620614
          2014-03-26  22:23    <DIR>          spellingIdx1395872620691
          2014-03-26  22:51    <DIR>          spellingIdx1395874264146
          2014-03-26  22:51    <DIR>          spellingIdx1395874264226
          2014-03-26  22:51    <DIR>          spellingIdx1395874264297
          2014-03-26  22:51    <DIR>          spellingIdx1395874264370
          2014-03-26  23:03    <DIR>          TestManagedSchema1395875022011
          2014-03-26  01:25    <DIR>          TestManagedSchemaFieldResource1395874989524
          2014-03-26  01:25    <DIR>          TestManagedSchemaFieldResource1395874992886
          2014-03-26  01:25    <DIR>          TestManagedSchemaFieldResource1395874995752
          2014-03-26  01:25    <DIR>          TestManagedSchemaFieldResource1395874998491
          2014-03-26  01:25    <DIR>          TestManagedSchemaFieldResource1395875001266
          2014-03-26  01:25    <DIR>          TestManagedSchemaFieldResource1395875004015
          2014-03-26  01:25    <DIR>          TestManagedSchemaFieldResource1395875006772
          2014-03-26  01:25    <DIR>          TestManagedSchemaFieldResource1395875009384
          2014-03-26  01:25    <DIR>          TestManagedSchemaFieldResource1395875011983
          2014-03-26  01:25    <DIR>          TestManagedSchemaFieldResource1395875014545
          2014-03-26  22:48    <DIR>          TestMultiCoreConfBootstrap-core1-1395874085663
                         1 File(s)             16 bytes
                       329 Dir(s)   2,512,564,224 bytes free
          

          As the tests passed, the test framework was nuking that folder J0, but if tests would have failed it would have been a lot of data left over.

          Show
          Uwe Schindler added a comment - - edited Hi Mark, thanks. I started a new build. It looks better now, but its still generating > 2 GB data while running solr-core tests, so not everything is covered by the cleanup. Here is a live "dir" shortly before the tests succeeded: C:\Users\JenkinsSlave\workspace\Lucene-Solr-trunk-Windows\solr\build\solr-core\test>dir J0 Volume in drive C is HARDDISK Volume Serial Number is 58F1-5382 Directory of C:\Users\JenkinsSlave\workspace\Lucene-Solr-trunk-Windows\solr\build\solr-core\test\J0 2014-03-26 23:03 <DIR> . 2014-03-26 23:03 <DIR> .. 2014-03-26 22:14 <DIR> 1395872092623-0 2014-03-26 22:51 <DIR> alternateIdx1395874264370 2014-03-26 23:02 <DIR> badConfigSet 2014-03-26 22:22 <DIR> ChangedSchemaMergeTest 2014-03-26 23:02 <DIR> core-reload 2014-03-26 22:15 <DIR> data 2014-03-26 23:02 <DIR> findsConfigSets 2014-03-26 22:14 <DIR> managed 2014-03-26 22:18 <DIR> org.apache.solr.cloud.AliasIntegrationTest-1395872282539 2014-03-26 01:25 <DIR> org.apache.solr.cloud.AliasIntegrationTest-controljetty-1395872282776 2014-03-26 01:25 <DIR> org.apache.solr.cloud.AliasIntegrationTest-jetty1-1395872286276 2014-03-26 22:18 <DIR> org.apache.solr.cloud.AliasIntegrationTest-jetty2-1395872290964 2014-03-26 22:18 <DIR> org.apache.solr.cloud.AliasIntegrationTest-jetty3-1395872295741 2014-03-26 22:36 <DIR> org.apache.solr.cloud.AsyncMigrateRouteKeyTest-1395873396484 2014-03-26 01:25 <DIR> org.apache.solr.cloud.AsyncMigrateRouteKeyTest-controljetty-1395873396662 2014-03-26 22:37 <DIR> org.apache.solr.cloud.AsyncMigrateRouteKeyTest-jetty1-1395873399601 2014-03-26 22:37 <DIR> org.apache.solr.cloud.AsyncMigrateRouteKeyTest-jetty2-1395873403459 2014-03-26 01:25 <DIR> org.apache.solr.cloud.AsyncMigrateRouteKeyTest-jetty3-1395873407351 2014-03-26 01:25 <DIR> org.apache.solr.cloud.AsyncMigrateRouteKeyTest-jetty4-1395873411574 2014-03-26 22:25 <DIR> org.apache.solr.cloud.BasicDistributedZk2Test-1395872669978 2014-03-26 22:25 <DIR> org.apache.solr.cloud.BasicDistributedZk2Test-backupdir-1395872721159 2014-03-26 01:25 <DIR> org.apache.solr.cloud.BasicDistributedZk2Test-controljetty-1395872670179 2014-03-26 01:25 <DIR> org.apache.solr.cloud.BasicDistributedZk2Test-jetty1-1395872673905 2014-03-26 01:25 <DIR> org.apache.solr.cloud.BasicDistributedZk2Test-jetty2-1395872677749 2014-03-26 01:25 <DIR> org.apache.solr.cloud.BasicDistributedZk2Test-jetty3-1395872681517 2014-03-26 01:25 <DIR> org.apache.solr.cloud.BasicDistributedZk2Test-jetty4-1395872685545 2014-03-26 01:25 <DIR> org.apache.solr.cloud.BasicDistributedZk2Test-jetty5-1395872721863 2014-03-26 22:39 <DIR> org.apache.solr.cloud.BasicDistributedZkTest-1395873576104 2014-03-26 01:25 <DIR> org.apache.solr.cloud.BasicDistributedZkTest-controljetty-1395873576286 2014-03-26 01:25 <DIR> org.apache.solr.cloud.BasicDistributedZkTest-jetty1-1395873579528 2014-03-26 01:25 <DIR> org.apache.solr.cloud.BasicDistributedZkTest-jetty2-1395873583401 2014-03-26 01:25 <DIR> org.apache.solr.cloud.BasicDistributedZkTest-jetty3-1395873586925 2014-03-26 01:25 <DIR> org.apache.solr.cloud.BasicDistributedZkTest-jetty4-1395873590539 2014-03-26 22:52 <DIR> org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-1395874307115 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-controljetty-1395874307338 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-jetty1-1395874311142 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-jetty2-1395874315747 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-jetty3-1395874320123 2014-03-26 22:52 <DIR> org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-jetty4-1395874324288 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-jetty5-1395874328202 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-jetty6-1395874332189 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest-jetty7-1395874336606 2014-03-26 22:53 <DIR> org.apache.solr.cloud.CollectionsAPIAsyncDistributedZkTest-1395874432351 2014-03-26 22:54 <DIR> org.apache.solr.cloud.CollectionsAPIAsyncDistributedZkTest-controljetty-1395874432556 2014-03-26 01:25 <DIR> org.apache.solr.cloud.CollectionsAPIAsyncDistributedZkTest-jetty1-1395874436525 2014-03-26 01:25 <DIR> org.apache.solr.cloud.CollectionsAPIAsyncDistributedZkTest-jetty2-1395874441514 2014-03-26 01:25 <DIR> org.apache.solr.cloud.CollectionsAPIAsyncDistributedZkTest-jetty3-1395874446349 2014-03-26 22:54 <DIR> org.apache.solr.cloud.CollectionsAPIAsyncDistributedZkTest-jetty4-1395874450968 2014-03-26 22:26 <DIR> org.apache.solr.cloud.CollectionsAPIDistributedZkTest-1395872769742 2014-03-26 22:28 <DIR> org.apache.solr.cloud.CollectionsAPIDistributedZkTest-controljetty-1395872769991 2014-03-26 22:28 <DIR> org.apache.solr.cloud.CollectionsAPIDistributedZkTest-jetty1-1395872773183 2014-03-26 22:28 <DIR> org.apache.solr.cloud.CollectionsAPIDistributedZkTest-jetty2-1395872777010 2014-03-26 22:28 <DIR> org.apache.solr.cloud.CollectionsAPIDistributedZkTest-jetty3-1395872780620 2014-03-26 22:28 <DIR> org.apache.solr.cloud.CollectionsAPIDistributedZkTest-jetty4-1395872784271 2014-03-26 22:32 <DIR> org.apache.solr.cloud.CustomCollectionTest-1395873153259 2014-03-26 22:33 <DIR> org.apache.solr.cloud.CustomCollectionTest-controljetty-1395873153469 2014-03-26 22:33 <DIR> org.apache.solr.cloud.CustomCollectionTest-jetty1-1395873157398 2014-03-26 22:33 <DIR> org.apache.solr.cloud.CustomCollectionTest-jetty2-1395873162252 2014-03-26 22:33 <DIR> org.apache.solr.cloud.CustomCollectionTest-jetty3-1395873167251 2014-03-26 22:33 <DIR> org.apache.solr.cloud.CustomCollectionTest-jetty4-1395873172036 2014-03-26 22:37 <DIR> org.apache.solr.cloud.DeleteInactiveReplicaTest-1395873465635 2014-03-26 22:38 <DIR> org.apache.solr.cloud.DeleteInactiveReplicaTest-controljetty-1395873465859 2014-03-26 22:38 <DIR> org.apache.solr.cloud.DeleteInactiveReplicaTest-jetty1-1395873469262 2014-03-26 22:38 <DIR> org.apache.solr.cloud.DeleteInactiveReplicaTest-jetty2-1395873473633 2014-03-26 22:38 <DIR> org.apache.solr.cloud.DeleteInactiveReplicaTest-jetty3-1395873477736 2014-03-26 01:25 <DIR> org.apache.solr.cloud.DeleteInactiveReplicaTest-jetty4-1395873481815 2014-03-26 22:16 <DIR> org.apache.solr.cloud.DeleteReplicaTest-1395872184784 2014-03-26 22:16 <DIR> org.apache.solr.cloud.DeleteReplicaTest-controljetty-1395872185090 2014-03-26 01:25 <DIR> org.apache.solr.cloud.DeleteReplicaTest-jetty1-1395872190049 2014-03-26 22:16 <DIR> org.apache.solr.cloud.DeleteReplicaTest-jetty2-1395872195139 2014-03-26 22:16 <DIR> org.apache.solr.cloud.DeleteReplicaTest-jetty3-1395872200076 2014-03-26 22:16 <DIR> org.apache.solr.cloud.DeleteReplicaTest-jetty4-1395872204810 2014-03-26 22:34 <DIR> org.apache.solr.cloud.DeleteShardTest-1395873269920 2014-03-26 01:25 <DIR> org.apache.solr.cloud.DeleteShardTest-controljetty-1395873270159 2014-03-26 01:25 <DIR> org.apache.solr.cloud.DeleteShardTest-jetty1-1395873273799 2014-03-26 01:25 <DIR> org.apache.solr.cloud.DeleteShardTest-jetty2-1395873278330 2014-03-26 22:54 <DIR> org.apache.solr.cloud.DistribCursorPagingTest-1395874470943 2014-03-26 01:25 <DIR> org.apache.solr.cloud.DistribCursorPagingTest-controljetty-1395874471153 2014-03-26 01:25 <DIR> org.apache.solr.cloud.DistribCursorPagingTest-jetty1-1395874474981 2014-03-26 01:25 <DIR> org.apache.solr.cloud.DistribCursorPagingTest-jetty2-1395874479793 2014-03-26 01:25 <DIR> org.apache.solr.cloud.DistribCursorPagingTest-jetty3-1395874484627 2014-03-26 01:25 <DIR> org.apache.solr.cloud.DistribCursorPagingTest-jetty4-1395874489820 2014-03-26 22:31 <DIR> org.apache.solr.cloud.FullSolrCloudDistribCmdsTest-1395873081563 2014-03-26 22:32 <DIR> org.apache.solr.cloud.FullSolrCloudDistribCmdsTest-controljetty-1395873081829 2014-03-26 22:32 <DIR> org.apache.solr.cloud.FullSolrCloudDistribCmdsTest-jetty1-1395873085733 2014-03-26 22:32 <DIR> org.apache.solr.cloud.FullSolrCloudDistribCmdsTest-jetty2-1395873090044 2014-03-26 01:25 <DIR> org.apache.solr.cloud.FullSolrCloudDistribCmdsTest-jetty3-1395873094283 2014-03-26 22:32 <DIR> org.apache.solr.cloud.FullSolrCloudDistribCmdsTest-jetty4-1395873098475 2014-03-26 22:32 <DIR> org.apache.solr.cloud.FullSolrCloudDistribCmdsTest-jetty5-1395873102796 2014-03-26 01:25 <DIR> org.apache.solr.cloud.FullSolrCloudDistribCmdsTest-jetty6-1395873107325 2014-03-26 22:55 <DIR> org.apache.solr.cloud.MigrateRouteKeyTest-1395874516302 2014-03-26 22:55 <DIR> org.apache.solr.cloud.MigrateRouteKeyTest-controljetty-1395874516484 2014-03-26 22:55 <DIR> org.apache.solr.cloud.MigrateRouteKeyTest-jetty1-1395874519611 2014-03-26 01:25 <DIR> org.apache.solr.cloud.MigrateRouteKeyTest-jetty2-1395874523732 2014-03-26 01:25 <DIR> org.apache.solr.cloud.MigrateRouteKeyTest-jetty3-1395874527584 2014-03-26 01:25 <DIR> org.apache.solr.cloud.MigrateRouteKeyTest-jetty4-1395874531206 2014-03-26 22:57 <DIR> org.apache.solr.cloud.OverseerRolesTest-1395874575057 2014-03-26 22:56 <DIR> org.apache.solr.cloud.OverseerRolesTest-controljetty-1395874575320 2014-03-26 22:56 <DIR> org.apache.solr.cloud.OverseerRolesTest-jetty1-1395874579843 2014-03-26 22:56 <DIR> org.apache.solr.cloud.OverseerRolesTest-jetty2-1395874585458 2014-03-26 22:56 <DIR> org.apache.solr.cloud.OverseerRolesTest-jetty3-1395874591401 2014-03-26 22:56 <DIR> org.apache.solr.cloud.OverseerRolesTest-jetty4-1395874597692 2014-03-26 22:56 <DIR> org.apache.solr.cloud.OverseerRolesTest-jetty5-1395874603870 2014-03-26 22:56 <DIR> org.apache.solr.cloud.OverseerRolesTest-jetty6-1395874609504 2014-03-26 22:23 <DIR> org.apache.solr.cloud.OverseerStatusTest-1395872580782 2014-03-26 01:25 <DIR> org.apache.solr.cloud.OverseerStatusTest-controljetty-1395872580999 2014-03-26 01:25 <DIR> org.apache.solr.cloud.OverseerStatusTest-jetty1-1395872584409 2014-03-26 01:25 <DIR> org.apache.solr.cloud.OverseerStatusTest-jetty2-1395872588669 2014-03-26 01:25 <DIR> org.apache.solr.cloud.OverseerStatusTest-jetty3-1395872592777 2014-03-26 22:23 <DIR> org.apache.solr.cloud.OverseerStatusTest-jetty4-1395872596435 2014-03-26 22:42 <DIR> org.apache.solr.cloud.RecoveryZkTest-1395873762003 2014-03-26 01:25 <DIR> org.apache.solr.cloud.RecoveryZkTest-controljetty-1395873762283 2014-03-26 01:25 <DIR> org.apache.solr.cloud.RecoveryZkTest-jetty1-1395873766994 2014-03-26 01:25 <DIR> org.apache.solr.cloud.RecoveryZkTest-jetty2-1395873772754 2014-03-26 22:24 <DIR> org.apache.solr.cloud.RemoteQueryErrorTest-1395872621201 2014-03-26 01:25 <DIR> org.apache.solr.cloud.RemoteQueryErrorTest-controljetty-1395872621447 2014-03-26 01:25 <DIR> org.apache.solr.cloud.RemoteQueryErrorTest-jetty1-1395872625507 2014-03-26 22:24 <DIR> org.apache.solr.cloud.RemoteQueryErrorTest-jetty2-1395872630507 2014-03-26 22:24 <DIR> org.apache.solr.cloud.RemoteQueryErrorTest-jetty3-1395872636158 2014-03-26 22:19 <DIR> org.apache.solr.cloud.ShardRoutingCustomTest-1395872358405 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ShardRoutingCustomTest-controljetty-1395872358648 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ShardRoutingCustomTest-jetty1-1395872362534 2014-03-26 22:29 <DIR> org.apache.solr.cloud.ShardRoutingTest-1395872906293 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ShardRoutingTest-controljetty-1395872906517 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ShardRoutingTest-jetty1-1395872910026 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ShardRoutingTest-jetty2-1395872914490 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ShardRoutingTest-jetty3-1395872919050 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ShardRoutingTest-jetty4-1395872923562 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ShardRoutingTest-jetty5-1395872928627 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ShardRoutingTest-jetty6-1395872933434 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ShardRoutingTest-jetty7-1395872938064 2014-03-26 01:25 <DIR> org.apache.solr.cloud.ShardRoutingTest-jetty8-1395872942440 2014-03-26 22:58 <DIR> org.apache.solr.cloud.ShardSplitTest-1395874669896 2014-03-26 22:59 <DIR> org.apache.solr.cloud.ShardSplitTest-controljetty-1395874670069 2014-03-26 22:58 <DIR> org.apache.solr.cloud.ShardSplitTest-jetty1-1395874673104 2014-03-26 22:59 <DIR> org.apache.solr.cloud.ShardSplitTest-jetty2-1395874677188 2014-03-26 22:58 <DIR> org.apache.solr.cloud.ShardSplitTest-jetty3-1395874681049 2014-03-26 22:59 <DIR> org.apache.solr.cloud.ShardSplitTest-jetty4-1395874685037 2014-03-26 22:57 <DIR> org.apache.solr.cloud.SSLMigrationTest-1395874630695 2014-03-26 01:25 <DIR> org.apache.solr.cloud.SSLMigrationTest-controljetty-1395874630907 2014-03-26 01:25 <DIR> org.apache.solr.cloud.SSLMigrationTest-jetty1-1395874634153 2014-03-26 01:25 <DIR> org.apache.solr.cloud.SSLMigrationTest-jetty2-1395874638133 2014-03-26 01:25 <DIR> org.apache.solr.cloud.SSLMigrationTest-jetty3-1395874642015 2014-03-26 01:25 <DIR> org.apache.solr.cloud.SSLMigrationTest-jetty4-1395874645693 2014-03-26 22:35 <DIR> org.apache.solr.cloud.SyncSliceTest-1395873298880 2014-03-26 01:25 <DIR> org.apache.solr.cloud.SyncSliceTest-controljetty-1395873299093 2014-03-26 01:25 <DIR> org.apache.solr.cloud.SyncSliceTest-jetty1-1395873302366 2014-03-26 01:25 <DIR> org.apache.solr.cloud.SyncSliceTest-jetty2-1395873306431 2014-03-26 01:25 <DIR> org.apache.solr.cloud.SyncSliceTest-jetty3-1395873310382 2014-03-26 01:25 <DIR> org.apache.solr.cloud.SyncSliceTest-jetty4-1395873314162 2014-03-26 23:00 <DIR> org.apache.solr.cloud.TestDistribDocBasedVersion-1395874782399 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestDistribDocBasedVersion-controljetty-1395874782652 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestDistribDocBasedVersion-jetty1-1395874786890 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestDistribDocBasedVersion-jetty2-1395874791637 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestDistribDocBasedVersion-jetty3-1395874796422 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestDistribDocBasedVersion-jetty4-1395874800888 2014-03-26 22:20 <DIR> org.apache.solr.cloud.TestModifyConfFiles-1395872429293 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestModifyConfFiles-controljetty-1395872429555 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestModifyConfFiles-jetty1-1395872433940 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestModifyConfFiles-jetty2-1395872439551 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestModifyConfFiles-jetty3-1395872444054 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestModifyConfFiles-jetty4-1395872448716 2014-03-26 22:36 <DIR> org.apache.solr.cloud.TestRequestStatusCollectionAPI-1395873369032 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestRequestStatusCollectionAPI-controljetty-1395873369293 2014-03-26 22:36 <DIR> org.apache.solr.cloud.TestRequestStatusCollectionAPI-jetty1-1395873373119 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestRequestStatusCollectionAPI-jetty2-1395873377467 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestRequestStatusCollectionAPI-jetty3-1395873381763 2014-03-26 22:36 <DIR> org.apache.solr.cloud.TestRequestStatusCollectionAPI-jetty4-1395873385686 2014-03-26 22:17 <DIR> org.apache.solr.cloud.TestShortCircuitedRequests-1395872233140 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestShortCircuitedRequests-controljetty-1395872233358 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestShortCircuitedRequests-jetty1-1395872236934 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestShortCircuitedRequests-jetty2-1395872241635 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestShortCircuitedRequests-jetty3-1395872246453 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TestShortCircuitedRequests-jetty4-1395872251632 2014-03-26 23:01 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-1395874815901 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-controljetty-1395874816084 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty1-1395874818914 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty10-1395874846280 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty11-1395874849202 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty12-1395874852320 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty13-1395874855705 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty14-1395874859035 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty15-1395874862723 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty16-1395874867046 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty17-1395874871870 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty18-1395874876210 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty19-1395874880819 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty2-1395874822466 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty20-1395874885941 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty21-1395874891003 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty22-1395874896108 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty23-1395874901734 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty24-1395874907454 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty3-1395874825873 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty4-1395874829053 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty5-1395874832242 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty6-1395874835169 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty7-1395874838032 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty8-1395874840695 2014-03-26 01:25 <DIR> org.apache.solr.cloud.TriLevelCompositeIdRoutingTest-jetty9-1395874843398 2014-03-26 22:41 <DIR> org.apache.solr.cloud.UnloadDistributedZkTest-1395873668638 2014-03-26 01:25 <DIR> org.apache.solr.cloud.UnloadDistributedZkTest-controljetty-1395873668829 2014-03-26 22:42 <DIR> org.apache.solr.cloud.UnloadDistributedZkTest-jetty1-1395873671999 2014-03-26 22:41 <DIR> org.apache.solr.cloud.UnloadDistributedZkTest-jetty2-1395873676015 2014-03-26 22:41 <DIR> org.apache.solr.cloud.UnloadDistributedZkTest-jetty3-1395873679981 2014-03-26 22:41 <DIR> org.apache.solr.cloud.UnloadDistributedZkTest-jetty4-1395873683716 2014-03-26 22:51 <DIR> org.apache.solr.core.TestArbitraryIndexDir-1395874280112 2014-03-26 01:25 <DIR> org.apache.solr.core.TestCoreContainer_classLoaderHierarchy 2014-03-26 01:25 <DIR> org.apache.solr.core.TestCoreContainer_reloadSequential 2014-03-26 01:25 <DIR> org.apache.solr.core.TestCoreContainer_reloadThreaded 2014-03-26 01:25 <DIR> org.apache.solr.core.TestCoreContainer_shareSchema 2014-03-26 22:50 <DIR> org.apache.solr.core.TestCoreDiscovery 2014-03-26 23:02 <DIR> org.apache.solr.core.TestSolrXml 2014-03-26 22:50 <DIR> org.apache.solr.handler.admin.CoreAdminHandlerTest-corex-1395874238332 2014-03-26 23:02 <DIR> org.apache.solr.handler.admin.CoreAdminRequestStatusTest 2014-03-26 23:02 <DIR> org.apache.solr.handler.component.DistributedExpandComponentTest-1395874957439 2014-03-26 22:37 <DIR> org.apache.solr.handler.component.DistributedQueryComponentCustomSortTest-1395873461156 2014-03-26 23:02 <DIR> org.apache.solr.handler.component.DistributedQueryComponentOptimizationTest-1395874964419 2014-03-26 22:17 <DIR> org.apache.solr.handler.component.DistributedQueryElevationComponentTest-1395872262687 2014-03-26 22:46 <DIR> org.apache.solr.handler.component.DistributedSpellCheckComponentTest-1395873972866 2014-03-26 23:02 <DIR> org.apache.solr.handler.component.DistributedSuggestComponentTest-1395874967878 2014-03-26 22:48 <DIR> org.apache.solr.handler.component.DistributedTermsComponentTest-1395874121982 2014-03-26 22:46 <DIR> org.apache.solr.handler.component.TermVectorComponentDistributedTest-1395873985101 2014-03-26 22:18 <DIR> org.apache.solr.schema.TestCloudManagedSchema-1395872325756 2014-03-26 01:25 <DIR> org.apache.solr.schema.TestCloudManagedSchema-controljetty-1395872325952 2014-03-26 01:25 <DIR> org.apache.solr.schema.TestCloudManagedSchema-jetty1-1395872329525 2014-03-26 01:25 <DIR> org.apache.solr.schema.TestCloudManagedSchema-jetty2-1395872334206 2014-03-26 01:25 <DIR> org.apache.solr.schema.TestCloudManagedSchema-jetty3-1395872338940 2014-03-26 01:25 <DIR> org.apache.solr.schema.TestCloudManagedSchema-jetty4-1395872344228 2014-03-26 22:29 <DIR> org.apache.solr.schema.TestCloudManagedSchemaAddField-1395872965843 2014-03-26 01:25 <DIR> org.apache.solr.schema.TestCloudManagedSchemaAddField-controljetty-1395872966121 2014-03-26 01:25 <DIR> org.apache.solr.schema.TestCloudManagedSchemaAddField-jetty1-1395872969983 2014-03-26 01:25 <DIR> org.apache.solr.schema.TestCloudManagedSchemaAddField-jetty2-1395872974755 2014-03-26 01:25 <DIR> org.apache.solr.schema.TestCloudManagedSchemaAddField-jetty3-1395872980253 2014-03-26 01:25 <DIR> org.apache.solr.schema.TestCloudManagedSchemaAddField-jetty4-1395872986370 2014-03-26 01:25 <DIR> org.apache.solr.schema.TestCloudManagedSchemaAddField-jetty5-1395872991156 2014-03-26 01:25 <DIR> org.apache.solr.schema.TestCloudManagedSchemaAddField-jetty6-1395872995862 2014-03-26 01:25 <DIR> org.apache.solr.schema.TestCloudManagedSchemaAddField-jetty7-1395873000361 2014-03-26 01:25 <DIR> org.apache.solr.schema.TestCloudManagedSchemaAddField-jetty8-1395873004604 2014-03-26 22:45 <DIR> org.apache.solr.TestDistributedGrouping-1395873933434 2014-03-26 22:53 <DIR> org.apache.solr.TestDistributedMissingSort-1395874378367 2014-03-26 22:45 <DIR> org.apache.solr.TestDistributedSearch-1395873900301 2014-03-26 22:53 <DIR> org.apache.solr.TestHighlightDedupGrouping-1395874387200 2014-03-26 22:21 <DIR> org.apache.solr.update.PeerSyncTest-1395872507319 2014-03-26 22:49 <DIR> org.apache.solr.update.SolrCmdDistributorTest-1395874180178 2014-03-26 22:34 <DIR> org.apache.solr.update.SolrIndexSplitterTesttestSplitByRouteKey 2014-03-26 22:34 <DIR> org.apache.solr.update.SolrIndexSplitterTest_testSplit1 2014-03-26 22:34 <DIR> org.apache.solr.update.SolrIndexSplitterTest_testSplit2 2014-03-26 22:34 <DIR> org.apache.solr.update.SolrIndexSplitterTest_testSplit3 2014-03-26 22:21 <DIR> solrHome 2014-03-26 23:03 <DIR> solrtest-BJQParserTest-1395875032523 2014-03-26 22:21 <DIR> solrtest-confdropspot-org.apache.solr.cloud.ZkCLITest-1395872486763 2014-03-26 22:15 <DIR> solrtest-DirectSolrSpellCheckerTest-1395872150183 2014-03-26 22:21 16 solrtest-getfile-org.apache.solr.cloud.ZkCLITest-1395872466806 2014-03-26 22:38 <DIR> solrtest-LeaderElectionIntegrationTest-1395873511273 2014-03-26 22:49 <DIR> solrtest-QueryElevationComponentTest-1395874186376 2014-03-26 22:49 <DIR> solrtest-QueryElevationComponentTest-1395874186956 2014-03-26 22:49 <DIR> solrtest-QueryElevationComponentTest-1395874187677 2014-03-26 22:49 <DIR> solrtest-QueryElevationComponentTest-1395874188395 2014-03-26 22:49 <DIR> solrtest-QueryElevationComponentTest-1395874189158 2014-03-26 22:49 <DIR> solrtest-QueryElevationComponentTest-1395874189563 2014-03-26 22:49 <DIR> solrtest-QueryElevationComponentTest-1395874190215 2014-03-26 22:50 <DIR> solrtest-SolrCoreCheckLockOnStartupTest-1395874251121 2014-03-26 22:59 <DIR> solrtest-SolrXmlInZkTest-1395874762339 2014-03-26 22:59 <DIR> solrtest-SolrXmlInZkTest-1395874765727 2014-03-26 22:59 <DIR> solrtest-SolrXmlInZkTest-1395874769144 2014-03-26 22:59 <DIR> solrtest-SolrXmlInZkTest-1395874772554 2014-03-26 22:59 <DIR> solrtest-SolrXmlInZkTest-1395874775852 2014-03-26 22:50 <DIR> solrtest-SpellCheckCollatorTest-1395874233679 2014-03-26 22:31 <DIR> solrtest-SpellCheckComponentTest-1395873075489 2014-03-26 22:51 <DIR> solrtest-TestBinaryField-1395874298057 2014-03-26 22:34 <DIR> solrtest-TestManagedSchema-1395873255904 2014-03-26 22:34 <DIR> solrtest-TestManagedSchema-1395873256355 2014-03-26 22:34 <DIR> solrtest-TestManagedSchema-1395873256836 2014-03-26 22:34 <DIR> solrtest-TestManagedSchema-1395873257356 2014-03-26 22:34 <DIR> solrtest-TestManagedSchema-1395873257803 2014-03-26 22:34 <DIR> solrtest-TestManagedSchema-1395873258330 2014-03-26 22:34 <DIR> solrtest-TestManagedSchema-1395873258908 2014-03-26 22:34 <DIR> solrtest-TestManagedSchema-1395873259187 2014-03-26 22:34 <DIR> solrtest-TestManagedSchema-1395873259693 2014-03-26 22:34 <DIR> solrtest-TestManagedSchema-1395873260202 2014-03-26 22:34 <DIR> solrtest-TestManagedSchema-1395873260698 2014-03-26 22:34 <DIR> solrtest-TestManagedSchema-1395873260969 2014-03-26 22:34 <DIR> solrtest-TestManagedSchema-1395873261644 2014-03-26 23:03 <DIR> solrtest-TestManagedSchemaFieldResource-1395874989522 2014-03-26 23:03 <DIR> solrtest-TestManagedSchemaFieldResource-1395874992882 2014-03-26 23:03 <DIR> solrtest-TestManagedSchemaFieldResource-1395874995751 2014-03-26 23:03 <DIR> solrtest-TestManagedSchemaFieldResource-1395874998489 2014-03-26 23:03 <DIR> solrtest-TestManagedSchemaFieldResource-1395875001264 2014-03-26 23:03 <DIR> solrtest-TestManagedSchemaFieldResource-1395875004013 2014-03-26 23:03 <DIR> solrtest-TestManagedSchemaFieldResource-1395875006771 2014-03-26 23:03 <DIR> solrtest-TestManagedSchemaFieldResource-1395875009382 2014-03-26 23:03 <DIR> solrtest-TestManagedSchemaFieldResource-1395875011983 2014-03-26 22:36 <DIR> solrtest-TestSolrCoreProperties-1395873363377 2014-03-26 22:14 <DIR> solrtest-TestSolrXmlPersistence-1395872078098 2014-03-26 22:44 <DIR> solrtest-TestZkChroot-1395873858625 2014-03-26 22:44 <DIR> solrtest-TestZkChroot-1395873863542 2014-03-26 22:44 <DIR> solrtest-TestZkChroot-1395873865854 2014-03-26 22:17 <DIR> solrtest-WordBreakSolrSpellCheckerTest-1395872222378 2014-03-26 22:21 <DIR> solrtest-ZkCLITest-1395872459648 2014-03-26 22:21 <DIR> solrtest-ZkCLITest-1395872463281 2014-03-26 22:21 <DIR> solrtest-ZkCLITest-1395872466680 2014-03-26 22:21 <DIR> solrtest-ZkCLITest-1395872469063 2014-03-26 22:21 <DIR> solrtest-ZkCLITest-1395872472217 2014-03-26 22:21 <DIR> solrtest-ZkCLITest-1395872474359 2014-03-26 22:21 <DIR> solrtest-ZkCLITest-1395872476496 2014-03-26 22:21 <DIR> solrtest-ZkCLITest-1395872479370 2014-03-26 22:21 <DIR> solrtest-ZkCLITest-1395872482653 2014-03-26 22:21 <DIR> solrtest-ZkCLITest-1395872485943 2014-03-26 22:21 <DIR> solrtest-ZkCLITest-1395872489827 2014-03-26 22:23 <DIR> spellingIdx1395872620614 2014-03-26 22:23 <DIR> spellingIdx1395872620691 2014-03-26 22:51 <DIR> spellingIdx1395874264146 2014-03-26 22:51 <DIR> spellingIdx1395874264226 2014-03-26 22:51 <DIR> spellingIdx1395874264297 2014-03-26 22:51 <DIR> spellingIdx1395874264370 2014-03-26 23:03 <DIR> TestManagedSchema1395875022011 2014-03-26 01:25 <DIR> TestManagedSchemaFieldResource1395874989524 2014-03-26 01:25 <DIR> TestManagedSchemaFieldResource1395874992886 2014-03-26 01:25 <DIR> TestManagedSchemaFieldResource1395874995752 2014-03-26 01:25 <DIR> TestManagedSchemaFieldResource1395874998491 2014-03-26 01:25 <DIR> TestManagedSchemaFieldResource1395875001266 2014-03-26 01:25 <DIR> TestManagedSchemaFieldResource1395875004015 2014-03-26 01:25 <DIR> TestManagedSchemaFieldResource1395875006772 2014-03-26 01:25 <DIR> TestManagedSchemaFieldResource1395875009384 2014-03-26 01:25 <DIR> TestManagedSchemaFieldResource1395875011983 2014-03-26 01:25 <DIR> TestManagedSchemaFieldResource1395875014545 2014-03-26 22:48 <DIR> TestMultiCoreConfBootstrap-core1-1395874085663 1 File(s) 16 bytes 329 Dir(s) 2,512,564,224 bytes free As the tests passed, the test framework was nuking that folder J0, but if tests would have failed it would have been a lot of data left over.
          Hide
          Uwe Schindler added a comment - - edited

          After cleanup: 6,854,742,016 bytes free

          This means the solr-core tests used 4.3 Gigabytes of disk space shortly before cleanup!

          Show
          Uwe Schindler added a comment - - edited After cleanup: 6,854,742,016 bytes free This means the solr-core tests used 4.3 Gigabytes of disk space shortly before cleanup!
          Hide
          Dawid Weiss added a comment -

          I've looked at refactoring it a bit. The temporary folder and file creation in tests is very, very hairy. And time-consuming to fix. My conclusions so far:

          • we should add deleteOnExit to forbidden APIs; most of its use is laziness, and potentially bugs like this one:
                if (!success) {
                  try {
                    file.deleteOnExit();
                  } catch (Exception e) {
                    log.error("Error deleting file on exit: " + file, e);
                  }
                }
            
          • asserting on a 'clean' temporary folder state may be impossible given how much code would have to be fixed (unless somebody can lend a hand here).
          • global TEMP_DIR is evil. Use TestUtil.createTempFile and TestUtil.getTempDir (which I will rename to createTempDir).

          A patch will follow once I run the tests and ensure I didn't break anything. The patch removes refs to TEMP_DIR and cleans a lot of junk code. By calling TestUtil.* methods the temporary folders/ files are removed after a test class completes. Failure to remove a folder or a directory will cause a test suite failure.

          Show
          Dawid Weiss added a comment - I've looked at refactoring it a bit. The temporary folder and file creation in tests is very, very hairy. And time-consuming to fix. My conclusions so far: we should add deleteOnExit to forbidden APIs; most of its use is laziness, and potentially bugs like this one: if (!success) { try { file.deleteOnExit(); } catch (Exception e) { log.error( "Error deleting file on exit: " + file, e); } } asserting on a 'clean' temporary folder state may be impossible given how much code would have to be fixed (unless somebody can lend a hand here). global TEMP_DIR is evil. Use TestUtil.createTempFile and TestUtil.getTempDir (which I will rename to createTempDir). A patch will follow once I run the tests and ensure I didn't break anything. The patch removes refs to TEMP_DIR and cleans a lot of junk code. By calling TestUtil.* methods the temporary folders/ files are removed after a test class completes. Failure to remove a folder or a directory will cause a test suite failure.
          Hide
          Dawid Weiss added a comment -

          I've created a branch at https://svn.apache.org/repos/asf/lucene/dev/branches/solr5914. A number of Solr tests fail on this branch (Windows):

          Tests with failures (first 3 out of 11):
            - org.apache.solr.handler.component.DistributedSpellCheckComponentTest (suite)
            - org.apache.solr.spelling.IndexBasedSpellCheckerTest (suite)
            - org.apache.solr.spelling.SpellCheckCollatorTest (suite)
          

          I have to switch to other things, it's taken me quite longer than I expected. If somebody wants to take over and try to fix those tests, go ahead.

          Show
          Dawid Weiss added a comment - I've created a branch at https://svn.apache.org/repos/asf/lucene/dev/branches/solr5914 . A number of Solr tests fail on this branch (Windows): Tests with failures (first 3 out of 11): - org.apache.solr.handler.component.DistributedSpellCheckComponentTest (suite) - org.apache.solr.spelling.IndexBasedSpellCheckerTest (suite) - org.apache.solr.spelling.SpellCheckCollatorTest (suite) I have to switch to other things, it's taken me quite longer than I expected. If somebody wants to take over and try to fix those tests, go ahead.
          Hide
          Mark Miller added a comment -

          You can't fix them easily - that's why I created the annotation for them to not fail on cleanup.

          Show
          Mark Miller added a comment - You can't fix them easily - that's why I created the annotation for them to not fail on cleanup.
          Hide
          Mark Miller added a comment -

          (At least the spellcheck ones - I don't know what others are in that list)

          Show
          Mark Miller added a comment - (At least the spellcheck ones - I don't know what others are in that list)
          Hide
          Dawid Weiss added a comment -

          They won't pass on the branch – the criterion of being able to release temp. resources is now strict. It'd have to be a (disabled by default) test group so that these tests are not run at all.

          Show
          Dawid Weiss added a comment - They won't pass on the branch – the criterion of being able to release temp. resources is now strict. It'd have to be a (disabled by default) test group so that these tests are not run at all.
          Hide
          Uwe Schindler added a comment -

          I think the most important thing in the new branch is this:

          A patch will follow once I run the tests and ensure I didn't break anything. The patch removes refs to TEMP_DIR and cleans a lot of junk code. By calling TestUtil.* methods the temporary folders/ files are removed after a test class completes. Failure to remove a folder or a directory will cause a test suite failure.

          This gets my big +1. This makes Mark's manual cleanup code obsolete, because once you create a temp folder with the TestUtil method, this is nuked on test shutdown. But as Mark said, if those tests are not easy to fix, we have to think about a workaround.

          Dawid: You said, 11 tests are failing, does this mean in your branch the number of left over files reduced dramatically?

          Show
          Uwe Schindler added a comment - I think the most important thing in the new branch is this: A patch will follow once I run the tests and ensure I didn't break anything. The patch removes refs to TEMP_DIR and cleans a lot of junk code. By calling TestUtil.* methods the temporary folders/ files are removed after a test class completes. Failure to remove a folder or a directory will cause a test suite failure. This gets my big +1. This makes Mark's manual cleanup code obsolete, because once you create a temp folder with the TestUtil method, this is nuked on test shutdown. But as Mark said, if those tests are not easy to fix, we have to think about a workaround. Dawid: You said, 11 tests are failing, does this mean in your branch the number of left over files reduced dramatically?
          Hide
          Dawid Weiss added a comment -

          Yep. I think so. Try it.

          Show
          Dawid Weiss added a comment - Yep. I think so. Try it.
          Hide
          Uwe Schindler added a comment -

          we should add deleteOnExit to forbidden APIs

          +1. I think we should disallow it globally. I was thinking first about "test" group only, but it also makes no sense to have it in our main code!

          Show
          Uwe Schindler added a comment - we should add deleteOnExit to forbidden APIs +1. I think we should disallow it globally. I was thinking first about "test" group only, but it also makes no sense to have it in our main code!
          Hide
          Mark Miller added a comment -

          It looks better now, but its still generating > 2 GB data while running solr-core tests, so not everything is covered by the cleanup

          Yeah, so it looks like we are just trying to clean up the dataDir sub folder - instead we need to clean up the whole TEMP_DIR - some more things to fix to make that possible it looks.

          Show
          Mark Miller added a comment - It looks better now, but its still generating > 2 GB data while running solr-core tests, so not everything is covered by the cleanup Yeah, so it looks like we are just trying to clean up the dataDir sub folder - instead we need to clean up the whole TEMP_DIR - some more things to fix to make that possible it looks.
          Hide
          Uwe Schindler added a comment - - edited

          Yeah, so it looks like we are just trying to clean up the dataDir sub folder - instead we need to clean up the whole TEMP_DIR - some more things to fix to make that possible it looks.

          I think the branch created by Dawid covers this. Nuking the TEMP_DIR global evilness is a good step forward. Because TestUtil.createTemp* is already there to take care of cleanup.

          Show
          Uwe Schindler added a comment - - edited Yeah, so it looks like we are just trying to clean up the dataDir sub folder - instead we need to clean up the whole TEMP_DIR - some more things to fix to make that possible it looks. I think the branch created by Dawid covers this. Nuking the TEMP_DIR global evilness is a good step forward. Because TestUtil.createTemp* is already there to take care of cleanup.
          Hide
          Mark Miller added a comment -

          Yeah, I'm fine with David's work as a longer term step - sounds like he calling it quits for now though, and I'm not ready to turn off all the spellcheck tests, so I'm working on a shorter term solution as a first step.

          Show
          Mark Miller added a comment - Yeah, I'm fine with David's work as a longer term step - sounds like he calling it quits for now though, and I'm not ready to turn off all the spellcheck tests, so I'm working on a shorter term solution as a first step.
          Hide
          Uwe Schindler added a comment -

          I would not think thats needed. In his branch only 11 tests were initially not working. If you fix those we are done. The switch in his branch away from TEMP_DIR already fixed 99% of the stuff!

          Show
          Uwe Schindler added a comment - I would not think thats needed. In his branch only 11 tests were initially not working. If you fix those we are done. The switch in his branch away from TEMP_DIR already fixed 99% of the stuff!
          Hide
          Mark Miller added a comment -

          In his branch only 11 tests were initially not working. If you fix those we are done.

          Be my guest on tackling that without just ignoring the tests

          Nothing I'm doing conflicts with Davids work, and I know I can finish it and finish it shortly.

          Things like the spellchecker tests have problems root in apis rooted in years of history. I've got almost no time for this, and so I'd like to get the Solr clean up code in order, which will address this as a major issue in the short term and then we can focus on doing the right thing at the test framework level as a whole as follow up.

          Show
          Mark Miller added a comment - In his branch only 11 tests were initially not working. If you fix those we are done. Be my guest on tackling that without just ignoring the tests Nothing I'm doing conflicts with Davids work, and I know I can finish it and finish it shortly. Things like the spellchecker tests have problems root in apis rooted in years of history. I've got almost no time for this, and so I'd like to get the Solr clean up code in order, which will address this as a major issue in the short term and then we can focus on doing the right thing at the test framework level as a whole as follow up.
          Hide
          Dawid Weiss added a comment -

          > sounds like he calling it quits for now though,

          No, no man – I just had to do some real work and called in for a break. I also don't mean it has to be you in particular to fix those tests; like Uwe said, there are just a bunch of them (perhaps more, if we take a different seed – didn't check) so it's probably a realistic goal to fix these and merge back. If you look at the diff from trunk there were many horrible, horrible temp snippets I nuked. Perhaps I also introduced some regressions, another look from a different person would be definitely good.

          I'll get back to it when I can, obviously.

          Show
          Dawid Weiss added a comment - > sounds like he calling it quits for now though, No, no man – I just had to do some real work and called in for a break. I also don't mean it has to be you in particular to fix those tests; like Uwe said, there are just a bunch of them (perhaps more, if we take a different seed – didn't check) so it's probably a realistic goal to fix these and merge back. If you look at the diff from trunk there were many horrible, horrible temp snippets I nuked. Perhaps I also introduced some regressions, another look from a different person would be definitely good. I'll get back to it when I can, obviously.
          Hide
          ASF subversion and git services added a comment -

          Commit 1582413 from Mark Miller in branch 'dev/trunk'
          [ https://svn.apache.org/r1582413 ]

          SOLR-5914: Solr tests should use dataDir for tmp files.

          Show
          ASF subversion and git services added a comment - Commit 1582413 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1582413 ] SOLR-5914 : Solr tests should use dataDir for tmp files.
          Hide
          Dawid Weiss added a comment -
          -    File tmpdir = File.createTempFile("test", "tmp", TEMP_DIR);
          +    File tmpdir = File.createTempFile("test", "tmp", dataDir);
          

          Mark, it'll make every single file conflict with what I've done on the branch... Seems like we're doubling efforts here.

          Show
          Dawid Weiss added a comment - - File tmpdir = File.createTempFile( "test" , "tmp" , TEMP_DIR); + File tmpdir = File.createTempFile( "test" , "tmp" , dataDir); Mark, it'll make every single file conflict with what I've done on the branch... Seems like we're doubling efforts here.
          Hide
          Mark Miller added a comment -

          I'm moving the reference to TEMP_DIR to one spot - so all those changes of your should just become unnecessary.

          Show
          Mark Miller added a comment - I'm moving the reference to TEMP_DIR to one spot - so all those changes of your should just become unnecessary.
          Hide
          Mark Miller added a comment - - edited

          Seems like we're doubling efforts here.

          I'm not sure - I do know that it took me about 5 min to make that change, so it sounds like you spent most of your time on something else. I know your solution attempts to deal with TEMP_DIR and requires looking at 11 tests, some of which won't clean up properly anytime soon. My cleanup of Solr code to do what it was supposed to do to begin with already works with all tests.

          I look at what you are doing as a larger fix that is needed for the Lucene/Solr test framework as a whole. I'm happy to help with that later. I'm simply making the Solr cleanup code consistent with itself.

          Show
          Mark Miller added a comment - - edited Seems like we're doubling efforts here. I'm not sure - I do know that it took me about 5 min to make that change, so it sounds like you spent most of your time on something else. I know your solution attempts to deal with TEMP_DIR and requires looking at 11 tests, some of which won't clean up properly anytime soon. My cleanup of Solr code to do what it was supposed to do to begin with already works with all tests. I look at what you are doing as a larger fix that is needed for the Lucene/Solr test framework as a whole. I'm happy to help with that later. I'm simply making the Solr cleanup code consistent with itself.
          Hide
          Dawid Weiss added a comment -

          I think my patch has benefits over the previous code. It's more structured (uses test class names for temp dirs instead of arbitrary strings, in many cases copy-pasted incorrectly), it's not using timestamps (which is awkward), it relies on a single point of creating temporary folders and files (which we can use for enforcing stuff), each of which is tracked separately (so that you will know what code allocated a particular folder which caused problems).

          I honestly think the notion of "dataDir" in Solr's base test class is flawed – it just creates another sub-temp folder that becomes a dump for other temporary files, etc. Besides there's a lot of duplication too, for instance:

          +    dfsCluster = HdfsTestUtil.setupClass(new File(dataDir,
                   HdfsCollectionsAPIDistributedZkTest.class.getName() + "_"
                       + System.currentTimeMillis()).getAbsolutePath());
          

          just became a single call to:

              dfsCluster = HdfsTestUtil.setupClass();
          

          because the temp file is created bases on the current context. How are these changes unnecessary compared to what you've done?

          Show
          Dawid Weiss added a comment - I think my patch has benefits over the previous code. It's more structured (uses test class names for temp dirs instead of arbitrary strings, in many cases copy-pasted incorrectly), it's not using timestamps (which is awkward), it relies on a single point of creating temporary folders and files (which we can use for enforcing stuff), each of which is tracked separately (so that you will know what code allocated a particular folder which caused problems). I honestly think the notion of "dataDir" in Solr's base test class is flawed – it just creates another sub-temp folder that becomes a dump for other temporary files, etc. Besides there's a lot of duplication too, for instance: + dfsCluster = HdfsTestUtil.setupClass( new File(dataDir, HdfsCollectionsAPIDistributedZkTest.class.getName() + "_" + System .currentTimeMillis()).getAbsolutePath()); just became a single call to: dfsCluster = HdfsTestUtil.setupClass(); because the temp file is created bases on the current context. How are these changes unnecessary compared to what you've done?
          Hide
          Dawid Weiss added a comment -

          > I'm not sure - I do know that it took me about 5 min to make that change,

          Yeah... it took me over three hours to review and change those snippets which were using TEMP_DIR and now your commit will make me go through this again. Not fun.

          Show
          Dawid Weiss added a comment - > I'm not sure - I do know that it took me about 5 min to make that change, Yeah... it took me over three hours to review and change those snippets which were using TEMP_DIR and now your commit will make me go through this again. Not fun.
          Hide
          Dawid Weiss added a comment -

          Also: I can easily make those 11 tests still leave their leftover files behind (without causing a failure). I just deliberately chose not to because I thought we'd polish the patch before reintegrating.

          Perhaps it's still doable by reverting your commit (later on when the patch is ready) and then applying the changes made to the branch. Don't know if SVN can handle this well.

          Show
          Dawid Weiss added a comment - Also: I can easily make those 11 tests still leave their leftover files behind (without causing a failure). I just deliberately chose not to because I thought we'd polish the patch before reintegrating. Perhaps it's still doable by reverting your commit (later on when the patch is ready) and then applying the changes made to the branch. Don't know if SVN can handle this well.
          Hide
          Mark Miller added a comment -

          We can just merge up the branch - it's pretty easy.

          Show
          Mark Miller added a comment - We can just merge up the branch - it's pretty easy.
          Hide
          ASF subversion and git services added a comment -

          Commit 1582427 from Mark Miller in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1582427 ]

          SOLR-5914: Solr tests should use dataDir for tmp files.

          Show
          ASF subversion and git services added a comment - Commit 1582427 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1582427 ] SOLR-5914 : Solr tests should use dataDir for tmp files.
          Hide
          Mark Miller added a comment -

          I've got a meeting or two - give me a bit of time. Don't worry, this won't be any extra work for you.

          Show
          Mark Miller added a comment - I've got a meeting or two - give me a bit of time. Don't worry, this won't be any extra work for you.
          Hide
          Dawid Weiss added a comment -

          I don't. But I don't see how you intend to keep your changes together with mine (and I preferred my version, to be honest .

          Show
          Dawid Weiss added a comment - I don't. But I don't see how you intend to keep your changes together with mine (and I preferred my version, to be honest .
          Hide
          Mark Miller added a comment -

          (and I preferred my version, to be honest) .

          Your version is wrong IMO You attempted to address the use of TEMP_DIR at each place - but the Solr tests should not even be using TEMP_DIR like this - they should use dataDir as the cleanup code expects and as the sys prop solr.test.leavedatadir expects to work properly.

          All Solr test files should already be created under a tmp directory specified in SolrTestCaseJ4 - they just started leaking out at some point.

          You should only be dealing with this TEMP_DIR thing in one spot in Solr code.

          Show
          Mark Miller added a comment - (and I preferred my version, to be honest) . Your version is wrong IMO You attempted to address the use of TEMP_DIR at each place - but the Solr tests should not even be using TEMP_DIR like this - they should use dataDir as the cleanup code expects and as the sys prop solr.test.leavedatadir expects to work properly. All Solr test files should already be created under a tmp directory specified in SolrTestCaseJ4 - they just started leaking out at some point. You should only be dealing with this TEMP_DIR thing in one spot in Solr code.
          Hide
          Dawid Weiss added a comment -

          You see it depends on what you consider "wrong".

          Is 'dataDir' embedded in some form of hierarchy (i.e., does it require a parent structure of folders)? I don't think so (based on the fact that most tests pass with flying colors – they don't "depend" on dataDir). The "cleanup code" present in Solr is in my opinion an unnecessary duplication and the notion of "dataDir" can lead to problems. I removed everything related to creating temporary folders and files and moved it to a single place. One clear evidence how broken it was is how many sections of the code tried to either create timestamp-based temporary folders or delete-recreate folders with a fixed name. This just sucked. If a test needs a temporary folder (initially empty) or a temporary file then it should ask for one.

          Having one "dataDir" that one suite can inherit from another sounds "wrong" to me, especially if you allow certain suites to leave some of the files in those directories...

          So I still argue that my commit was a better cleanup than yours. I don't work so much on Solr code though, so I won't authoritatively commit it back to the trunk without consensus.

          Show
          Dawid Weiss added a comment - You see it depends on what you consider "wrong". Is 'dataDir' embedded in some form of hierarchy (i.e., does it require a parent structure of folders)? I don't think so (based on the fact that most tests pass with flying colors – they don't "depend" on dataDir). The "cleanup code" present in Solr is in my opinion an unnecessary duplication and the notion of "dataDir" can lead to problems. I removed everything related to creating temporary folders and files and moved it to a single place. One clear evidence how broken it was is how many sections of the code tried to either create timestamp-based temporary folders or delete-recreate folders with a fixed name. This just sucked. If a test needs a temporary folder (initially empty) or a temporary file then it should ask for one. Having one "dataDir" that one suite can inherit from another sounds "wrong" to me, especially if you allow certain suites to leave some of the files in those directories... So I still argue that my commit was a better cleanup than yours. I don't work so much on Solr code though, so I won't authoritatively commit it back to the trunk without consensus.
          Hide
          Mark Miller added a comment -

          So I still argue that my commit was a better cleanup than yours.

          I don't agree Mine fixes the issue and doesn't do contentious things like remove the dataDir or the system property that controls cleaning it up. Your also is not finished - you state above that your stopping your work and that you sunk more than 3 hours into it.

          My changes fix things to work as currently designed and took me less than 30 minutes.

          The difference that you have fallen in love with is simply called TestUtil.createTmpDir vs using dataDir - I can't find it in myself to argue about that, but it seems totally unrelated anyway.

          You have a path that you have spent hours on and still needs work and wants to do contentious things. I have a path that took me less than 30 min and is done.

          Great, now I don't have to worry about lots of data not getting cleaned up, we can look at your slower path

          Merging up your branch won't take me any time at all, and we can properly discuss how this might be handled going forward. I won't make you go and make 3 hours of changes again

          Show
          Mark Miller added a comment - So I still argue that my commit was a better cleanup than yours. I don't agree Mine fixes the issue and doesn't do contentious things like remove the dataDir or the system property that controls cleaning it up. Your also is not finished - you state above that your stopping your work and that you sunk more than 3 hours into it. My changes fix things to work as currently designed and took me less than 30 minutes. The difference that you have fallen in love with is simply called TestUtil.createTmpDir vs using dataDir - I can't find it in myself to argue about that, but it seems totally unrelated anyway. You have a path that you have spent hours on and still needs work and wants to do contentious things. I have a path that took me less than 30 min and is done. Great, now I don't have to worry about lots of data not getting cleaned up, we can look at your slower path Merging up your branch won't take me any time at all, and we can properly discuss how this might be handled going forward. I won't make you go and make 3 hours of changes again
          Hide
          Mark Miller added a comment -
          One clear evidence how broken it was is how many sections of the code tried to either create timestamp-based temporary folders or delete-recreate folders with a fixed name. This just sucked. If a test needs a temporary folder (initially empty) or a temporary file then it should ask for one. 
          

          Your conflating things - fixing this issue and improvements are two different things. I fixed the issue - according to the current rules. It sounds like you want to talk about changing the rules and adding improvements. Fine - but this is a burning issue - we leave gigs around on win on every run

          What you have done is just not even competition for what I have done.

          It's something to talk about and work on as a normal issue.

          The only valid complaint I can see you might have is some work on merging was dump on you - which I've said I'll happily do.

          Show
          Mark Miller added a comment - One clear evidence how broken it was is how many sections of the code tried to either create timestamp-based temporary folders or delete-recreate folders with a fixed name. This just sucked. If a test needs a temporary folder (initially empty) or a temporary file then it should ask for one. Your conflating things - fixing this issue and improvements are two different things. I fixed the issue - according to the current rules. It sounds like you want to talk about changing the rules and adding improvements. Fine - but this is a burning issue - we leave gigs around on win on every run What you have done is just not even competition for what I have done. It's something to talk about and work on as a normal issue. The only valid complaint I can see you might have is some work on merging was dump on you - which I've said I'll happily do.
          Hide
          Mark Miller added a comment -
          One clear evidence how broken it was is how many sections of the code tried to either create timestamp-based temporary folders or delete-recreate folders with a fixed name. This just sucked.

          It wasn't even necessary - it was either a wrong or outdated idea - same with the attempts to delete and then mkdir or deleteOnExit. That's all stuff waiting for improvement. But that is just sugar - and I'll take sugar man Load it on.

          I do have issues with how your branch does not deal with the borked dataDir concept, I don't like that it requires that special util method call everywhere. I really think what you have done actually simply compliments the fix, I would just do a few things a little differently. I'll show you how I would merge it up.

          Show
          Mark Miller added a comment - One clear evidence how broken it was is how many sections of the code tried to either create timestamp-based temporary folders or delete-recreate folders with a fixed name. This just sucked. It wasn't even necessary - it was either a wrong or outdated idea - same with the attempts to delete and then mkdir or deleteOnExit. That's all stuff waiting for improvement. But that is just sugar - and I'll take sugar man Load it on. I do have issues with how your branch does not deal with the borked dataDir concept, I don't like that it requires that special util method call everywhere. I really think what you have done actually simply compliments the fix, I would just do a few things a little differently. I'll show you how I would merge it up.
          Hide
          Mark Miller added a comment -

          You see it depends on what you consider "wrong".

          Let's also come to agreement here. SolrjTestCase4j has a temporary directory that it tries to clean after the test and that you can set a special system property to prevent cleaning. This is obviously where Solr tests should be creating their temporary files - SolrjTestCase4j is the root of all Solr tests (or is intended to be). So clearly, this working haphazardly is wrong.

          I've been part of that happening - LuceneTestCase#TEMP_DIR was just too tempting - I remember it's allure and using it. It got to the point where a ton of stuff was no longer under the cleaned up tmp dir and we got into this situation. It was not always like this - we had much, much less leakage.

          So I have fixed that. I didn't fix that the dataDir is conflated hopelessly between two worlds, I didn't fix any sugar api's or code, and I didn't address any other systemic issue. I just fixed what has clearly been borked and was supposed to work for eons now. If you set the right solr sys prop, you dont less any tmp files. When the test is over, it cleans up. That is back to working.

          If we can agree on that, perhaps we can start on the path of improvement. I just started integrating into your branch. Let's see what I come up with and push forward together from there.

          Show
          Mark Miller added a comment - You see it depends on what you consider "wrong". Let's also come to agreement here. SolrjTestCase4j has a temporary directory that it tries to clean after the test and that you can set a special system property to prevent cleaning. This is obviously where Solr tests should be creating their temporary files - SolrjTestCase4j is the root of all Solr tests (or is intended to be). So clearly, this working haphazardly is wrong. I've been part of that happening - LuceneTestCase#TEMP_DIR was just too tempting - I remember it's allure and using it. It got to the point where a ton of stuff was no longer under the cleaned up tmp dir and we got into this situation. It was not always like this - we had much, much less leakage. So I have fixed that. I didn't fix that the dataDir is conflated hopelessly between two worlds, I didn't fix any sugar api's or code, and I didn't address any other systemic issue. I just fixed what has clearly been borked and was supposed to work for eons now. If you set the right solr sys prop, you dont less any tmp files. When the test is over, it cleans up. That is back to working. If we can agree on that, perhaps we can start on the path of improvement. I just started integrating into your branch. Let's see what I come up with and push forward together from there.
          Hide
          Mark Miller added a comment -

          Oh yeah, I also fixed some other stuff that was confusing and silly - like trying to delete global test resources in tearDown and not just afterClass and other such garbage.

          Show
          Mark Miller added a comment - Oh yeah, I also fixed some other stuff that was confusing and silly - like trying to delete global test resources in tearDown and not just afterClass and other such garbage.
          Hide
          Uwe Schindler added a comment - - edited

          Hi,

          the last Jenkins run was successful. solr-core only had the well known SpellChecker tests leaving folders in the worker dir.

          We had one failure in solrj (http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Windows/3901/)

             [junit4] Suite: org.apache.solr.common.util.ContentStreamTest
             [junit4]   2> Creating dataDir: C:\Users\JenkinsSlave\workspace\Lucene-Solr-trunk-Windows\solr\build\solr-solrj\test\J0\.\solrtest-ContentStreamTest-1395962448800
             [junit4]   2> 68449 T207 oas.SolrTestCaseJ4.buildSSLConfig Randomized ssl (true) and clientAuth (false)
             [junit4]   2> 68452 T207 oas.SolrTestCaseJ4.setUp ###Starting testURLStream
             [junit4]   2> 68453 T207 oasc.SolrResourceLoader.locateSolrHome JNDI not configured for solr (NoInitialContextEx)
             [junit4]   2> 68453 T207 oasc.SolrResourceLoader.locateSolrHome solr home defaulted to 'solr/' (could not find system property or JNDI)
             [junit4]   2> 68453 T207 oasc.SolrResourceLoader.<init> new SolrResourceLoader for deduced Solr Home: 'solr/'
             [junit4]   2> 68554 T207 oas.SolrTestCaseJ4.tearDown ###Ending testURLStream
             [junit4]   2> 68565 T207 oas.SolrTestCaseJ4.setUp ###Starting testFileStream
             [junit4]   2> 68566 T207 oasc.SolrResourceLoader.locateSolrHome JNDI not configured for solr (NoInitialContextEx)
             [junit4]   2> 68566 T207 oasc.SolrResourceLoader.locateSolrHome solr home defaulted to 'solr/' (could not find system property or JNDI)
             [junit4]   2> 68567 T207 oasc.SolrResourceLoader.<init> new SolrResourceLoader for deduced Solr Home: 'solr/'
             [junit4]   2> 68615 T207 oas.SolrTestCaseJ4.tearDown ###Ending testFileStream
             [junit4]   2> 68622 T207 oas.SolrTestCaseJ4.setUp ###Starting testStringStream
             [junit4]   2> 68623 T207 oas.SolrTestCaseJ4.tearDown ###Ending testStringStream
             [junit4]   2> 68624 T207 oas.SolrTestCaseJ4.deleteCore ###deleteCore
             [junit4]   2> !!!! WARNING: best effort to remove C:\Users\JenkinsSlave\workspace\Lucene-Solr-trunk-Windows\solr\build\solr-solrj\test\J0\.\solrtest-ContentStreamTest-1395962448800\README FAILED !!!!!
             [junit4]   2> NOTE: test params are: codec=FastCompressingStoredFields(storedFieldsFormat=CompressingStoredFieldsFormat(compressionMode=FAST, chunkSize=271), termVectorsFormat=CompressingTermVectorsFormat(compressionMode=FAST, chunkSize=271)), sim=DefaultSimilarity, locale=en_IE, timezone=America/Vancouver
             [junit4]   2> NOTE: Windows 7 6.1 x86/Oracle Corporation 1.7.0_51 (32-bit)/cpus=2,threads=1,free=17354576,total=84934656
             [junit4]   2> NOTE: All tests run in this JVM: [TestXMLEscaping, JettyWebappTest, CloudSolrServerTest, LargeVolumeJettyTest, TestHash, SolrExampleStreamingTest, IteratorChainTest, TestFastInputStream, ContentStreamTest]
             [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=ContentStreamTest -Dtests.seed=32A8B44CEE4187EC -Dtests.slow=true -Dtests.locale=en_IE -Dtests.timezone=America/Vancouver -Dtests.file.encoding=UTF-8
             [junit4] ERROR   0.00s | ContentStreamTest (suite) <<<
             [junit4]    > Throwable #1: java.lang.AssertionError: !!!! WARNING: best effort to remove C:\Users\JenkinsSlave\workspace\Lucene-Solr-trunk-Windows\solr\build\solr-solrj\test\J0\.\solrtest-ContentStreamTest-1395962448800 FAILED !!!!!
             [junit4]    > 	at __randomizedtesting.SeedInfo.seed([32A8B44CEE4187EC]:0)
             [junit4]    > 	at org.apache.solr.SolrTestCaseJ4.afterClass(SolrTestCaseJ4.java:217)
             [junit4]    > 	at java.lang.Thread.run(Thread.java:744)
             [junit4] Completed in 0.41s, 3 tests, 1 failure <<< FAILURES!
          

          I would also change the message to no longer say "!!! WARNING !!!" -> we should only print this with the annotation, otheriwse it should be a standard assertion Error without "WARNING" included. The current message is a bit confusing.

          Otherwise: Thanks Mark, that was fast!

          Dawid: I agree with you that we should fix the whole stuff globally on the suite level. We should:

          • remove the TEMP_DIR constant completely!
          • forbid the File#deleteOnExit stuff

          Uwe

          Show
          Uwe Schindler added a comment - - edited Hi, the last Jenkins run was successful. solr-core only had the well known SpellChecker tests leaving folders in the worker dir. We had one failure in solrj ( http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Windows/3901/ ) [junit4] Suite: org.apache.solr.common.util.ContentStreamTest [junit4] 2> Creating dataDir: C:\Users\JenkinsSlave\workspace\Lucene-Solr-trunk-Windows\solr\build\solr-solrj\test\J0\.\solrtest-ContentStreamTest-1395962448800 [junit4] 2> 68449 T207 oas.SolrTestCaseJ4.buildSSLConfig Randomized ssl (true) and clientAuth (false) [junit4] 2> 68452 T207 oas.SolrTestCaseJ4.setUp ###Starting testURLStream [junit4] 2> 68453 T207 oasc.SolrResourceLoader.locateSolrHome JNDI not configured for solr (NoInitialContextEx) [junit4] 2> 68453 T207 oasc.SolrResourceLoader.locateSolrHome solr home defaulted to 'solr/' (could not find system property or JNDI) [junit4] 2> 68453 T207 oasc.SolrResourceLoader.<init> new SolrResourceLoader for deduced Solr Home: 'solr/' [junit4] 2> 68554 T207 oas.SolrTestCaseJ4.tearDown ###Ending testURLStream [junit4] 2> 68565 T207 oas.SolrTestCaseJ4.setUp ###Starting testFileStream [junit4] 2> 68566 T207 oasc.SolrResourceLoader.locateSolrHome JNDI not configured for solr (NoInitialContextEx) [junit4] 2> 68566 T207 oasc.SolrResourceLoader.locateSolrHome solr home defaulted to 'solr/' (could not find system property or JNDI) [junit4] 2> 68567 T207 oasc.SolrResourceLoader.<init> new SolrResourceLoader for deduced Solr Home: 'solr/' [junit4] 2> 68615 T207 oas.SolrTestCaseJ4.tearDown ###Ending testFileStream [junit4] 2> 68622 T207 oas.SolrTestCaseJ4.setUp ###Starting testStringStream [junit4] 2> 68623 T207 oas.SolrTestCaseJ4.tearDown ###Ending testStringStream [junit4] 2> 68624 T207 oas.SolrTestCaseJ4.deleteCore ###deleteCore [junit4] 2> !!!! WARNING: best effort to remove C:\Users\JenkinsSlave\workspace\Lucene-Solr-trunk-Windows\solr\build\solr-solrj\test\J0\.\solrtest-ContentStreamTest-1395962448800\README FAILED !!!!! [junit4] 2> NOTE: test params are: codec=FastCompressingStoredFields(storedFieldsFormat=CompressingStoredFieldsFormat(compressionMode=FAST, chunkSize=271), termVectorsFormat=CompressingTermVectorsFormat(compressionMode=FAST, chunkSize=271)), sim=DefaultSimilarity, locale=en_IE, timezone=America/Vancouver [junit4] 2> NOTE: Windows 7 6.1 x86/Oracle Corporation 1.7.0_51 (32-bit)/cpus=2,threads=1,free=17354576,total=84934656 [junit4] 2> NOTE: All tests run in this JVM: [TestXMLEscaping, JettyWebappTest, CloudSolrServerTest, LargeVolumeJettyTest, TestHash, SolrExampleStreamingTest, IteratorChainTest, TestFastInputStream, ContentStreamTest] [junit4] 2> NOTE: reproduce with: ant test -Dtestcase=ContentStreamTest -Dtests.seed=32A8B44CEE4187EC -Dtests.slow=true -Dtests.locale=en_IE -Dtests.timezone=America/Vancouver -Dtests.file.encoding=UTF-8 [junit4] ERROR 0.00s | ContentStreamTest (suite) <<< [junit4] > Throwable #1: java.lang.AssertionError: !!!! WARNING: best effort to remove C:\Users\JenkinsSlave\workspace\Lucene-Solr-trunk-Windows\solr\build\solr-solrj\test\J0\.\solrtest-ContentStreamTest-1395962448800 FAILED !!!!! [junit4] > at __randomizedtesting.SeedInfo.seed([32A8B44CEE4187EC]:0) [junit4] > at org.apache.solr.SolrTestCaseJ4.afterClass(SolrTestCaseJ4.java:217) [junit4] > at java.lang.Thread.run(Thread.java:744) [junit4] Completed in 0.41s, 3 tests, 1 failure <<< FAILURES! I would also change the message to no longer say "!!! WARNING !!!" -> we should only print this with the annotation, otheriwse it should be a standard assertion Error without "WARNING" included. The current message is a bit confusing. Otherwise: Thanks Mark, that was fast! Dawid: I agree with you that we should fix the whole stuff globally on the suite level. We should: remove the TEMP_DIR constant completely! forbid the File#deleteOnExit stuff Uwe
          Hide
          Mark Miller added a comment -

          Thanks - I'll address the solrj test.

          I'll also commit my merge up to the branch soon - we can revert it if there is too much disagreement, but its the only easy way to show the work.

          There will still be some things to tidy up, but I think the merge up has worked out pretty nicely myself.

          Show
          Mark Miller added a comment - Thanks - I'll address the solrj test. I'll also commit my merge up to the branch soon - we can revert it if there is too much disagreement, but its the only easy way to show the work. There will still be some things to tidy up, but I think the merge up has worked out pretty nicely myself.
          Hide
          ASF subversion and git services added a comment -

          Commit 1582549 from Uwe Schindler in branch 'dev/trunk'
          [ https://svn.apache.org/r1582549 ]

          SOLR-5914: Fix missing close on Reader

          Show
          ASF subversion and git services added a comment - Commit 1582549 from Uwe Schindler in branch 'dev/trunk' [ https://svn.apache.org/r1582549 ] SOLR-5914 : Fix missing close on Reader
          Hide
          ASF subversion and git services added a comment -

          Commit 1582550 from Uwe Schindler in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1582550 ]

          Merged revision(s) 1582549 from lucene/dev/trunk:
          SOLR-5914: Fix missing close on Reader

          Show
          ASF subversion and git services added a comment - Commit 1582550 from Uwe Schindler in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1582550 ] Merged revision(s) 1582549 from lucene/dev/trunk: SOLR-5914 : Fix missing close on Reader
          Hide
          Uwe Schindler added a comment -

          I fixed the ContentStreamTest suite (the Reader was not closed in one of the tests).

          Show
          Uwe Schindler added a comment - I fixed the ContentStreamTest suite (the Reader was not closed in one of the tests).
          Hide
          ASF subversion and git services added a comment -

          Commit 1582571 from Mark Miller in branch 'dev/branches/solr5914'
          [ https://svn.apache.org/r1582571 ]

          SOLR-5914: Merge branch up to trunk, make all tests pass, make some other improvements and small changes.

          Show
          ASF subversion and git services added a comment - Commit 1582571 from Mark Miller in branch 'dev/branches/solr5914' [ https://svn.apache.org/r1582571 ] SOLR-5914 : Merge branch up to trunk, make all tests pass, make some other improvements and small changes.
          Hide
          Mark Miller added a comment -

          I would also change the message to no longer say "!!! WARNING !!!" -> we should only print this with the annotation, otheriwse it should be a standard assertion Error without "WARNING" included. The current message is a bit confusing.

          I have not addressed that yet - I've just put a couple TODO's around the area - prob the largest thing left to cleanup.

          Show
          Mark Miller added a comment - I would also change the message to no longer say "!!! WARNING !!!" -> we should only print this with the annotation, otheriwse it should be a standard assertion Error without "WARNING" included. The current message is a bit confusing. I have not addressed that yet - I've just put a couple TODO's around the area - prob the largest thing left to cleanup.
          Hide
          Mark Miller added a comment -

          Okay - good stuff I think.

          If you guys have ideas for further improvements or spot issues, I'm happy to turn your thoughts into code. Or just jump right in.

          Show
          Mark Miller added a comment - Okay - good stuff I think. If you guys have ideas for further improvements or spot issues, I'm happy to turn your thoughts into code. Or just jump right in.
          Hide
          ASF subversion and git services added a comment -

          Commit 1582575 from Mark Miller in branch 'dev/branches/solr5914'
          [ https://svn.apache.org/r1582575 ]

          SOLR-5914: Fix map-reduce contrib tests use of solrhome.

          Show
          ASF subversion and git services added a comment - Commit 1582575 from Mark Miller in branch 'dev/branches/solr5914' [ https://svn.apache.org/r1582575 ] SOLR-5914 : Fix map-reduce contrib tests use of solrhome.
          Hide
          ASF subversion and git services added a comment -

          Commit 1582577 from Mark Miller in branch 'dev/branches/solr5914'
          [ https://svn.apache.org/r1582577 ]

          SOLR-5914: Fix morphlines contrib tests use of solrhome.

          Show
          ASF subversion and git services added a comment - Commit 1582577 from Mark Miller in branch 'dev/branches/solr5914' [ https://svn.apache.org/r1582577 ] SOLR-5914 : Fix morphlines contrib tests use of solrhome.
          Hide
          Dawid Weiss added a comment -

          Hey. I don't know if I'll be able to go back to this today, most likely not. I'll try to merge the changes Mark made to the trunk.

          Show
          Dawid Weiss added a comment - Hey. I don't know if I'll be able to go back to this today, most likely not. I'll try to merge the changes Mark made to the trunk.
          Hide
          Dawid Weiss added a comment -

          Uh, damn, I just noticed you already merged, Mark. Thanks. I'll review when I can.

          Show
          Dawid Weiss added a comment - Uh, damn, I just noticed you already merged, Mark. Thanks. I'll review when I can.
          Hide
          Dawid Weiss added a comment -

          Just a quick follow-up – is there any other reason for dataDir to exist other than to simplify cleanup? Also, what's the rationale for that property that prevents cleaning it up? The utilities in TestUtil have logic that doesn't prevent temporary directories when the test ended in a failure. Would this make that property effectively useless (because I think it's for debugging failed runs)?

          Show
          Dawid Weiss added a comment - Just a quick follow-up – is there any other reason for dataDir to exist other than to simplify cleanup? Also, what's the rationale for that property that prevents cleaning it up? The utilities in TestUtil have logic that doesn't prevent temporary directories when the test ended in a failure. Would this make that property effectively useless (because I think it's for debugging failed runs)?
          Hide
          Mark Miller added a comment -

          is there any other reason for dataDir to exist other than to simplify cleanup?

          Yes - we want to be able to keep around all the files for debugging and development by request of the dev whether it fails or not - and it would be good if all those files for a test where under one root dir named after the test.

          I don't think that's fully happening yet though - I think the children dirs of the root test dir will still be removed - I've still got to look at that.

          Show
          Mark Miller added a comment - is there any other reason for dataDir to exist other than to simplify cleanup? Yes - we want to be able to keep around all the files for debugging and development by request of the dev whether it fails or not - and it would be good if all those files for a test where under one root dir named after the test. I don't think that's fully happening yet though - I think the children dirs of the root test dir will still be removed - I've still got to look at that.
          Hide
          ASF subversion and git services added a comment -

          Commit 1582826 from Mark Miller in branch 'dev/branches/solr5914'
          [ https://svn.apache.org/r1582826 ]

          SOLR-5914: Need to use ensureClosed boolean everywhere in SolrTestCaseJ4.

          Show
          ASF subversion and git services added a comment - Commit 1582826 from Mark Miller in branch 'dev/branches/solr5914' [ https://svn.apache.org/r1582826 ] SOLR-5914 : Need to use ensureClosed boolean everywhere in SolrTestCaseJ4.
          Hide
          Dawid Weiss added a comment -

          I looked at the current state of the branch, Mark, and I strongly disagree with having this in TestUtil:

            public static File createTempDir(String name, File tmpDir, boolean ensureCleanedUp)
          

          It's creating a gateway for bad code to proliferate. A temporary folder WILL be removed after a suite is done, there should be no way to "opt out" from this check. I understand sometimes it's useful to keep temp. files and it should be possible, but NOT AT THE CODE LEVEL (it should be a result of an explicit action of the developer).

          My suggestion is to change SolrTestCaseJ4 and instead of putting the logic to keep temporary folders in there I'd rather:

          • declare a global sys property that would prevent removing temporary folders (placed in TestUtil; but we can keep solr.test.leavetmpdir as an alias). In fact there already is a similar property for the runner itself:
            # Don't remove temporary files under slave directories, even if
            # the test passes.
            ant -Dtests.leaveTemporary=true
            

            so we could just adopt it here too.

          • make an annotation called DirtyHarry (suggestions welcome) to mark suites which are known offenders of the default behavior. Classes annotated with DirtyHarry wouldn't fail if they leave undeletable garbage behind (but would print a warning).

          I also don't quite understand why you insist on things like this:

           rootTmpDir = TestUtil.createTempDir("solrtest-" + cname, null, ensureClosed);
           initCoreDataDir = TestUtil.createTempDir("solrtest-" + cname, rootTmpDir, ensureClosed);
          

          Why 'solrtest-*' prefix? Isn't class name enough? And why create a temporary folder under a temporary folder (if we know rootTmpDir will always be empty, even on a run when previous runs left their temporary folders a new, empty folder uniquely suffixed will be created.

          As for this:

                    // TODO: tmp files should already get cleaned up by the test framework, but
                    // we still do it here as well, so that we clean up as much as we can, even
                    // when a test is the SuppressTempDirCleanUp annotation
          

          it isn't true. The rule to clean up temporary files is fired almost at the very end of processing, after all the after class rules have already been executed. The reason for this is that you don't want to clean up any temporary files for failed tests/ suites and you know this only after everything else has been executed.

          Let me know what you think, I'll make the above changes and make them ready for your review.

          Show
          Dawid Weiss added a comment - I looked at the current state of the branch, Mark, and I strongly disagree with having this in TestUtil: public static File createTempDir( String name, File tmpDir, boolean ensureCleanedUp) It's creating a gateway for bad code to proliferate. A temporary folder WILL be removed after a suite is done, there should be no way to "opt out" from this check. I understand sometimes it's useful to keep temp. files and it should be possible, but NOT AT THE CODE LEVEL (it should be a result of an explicit action of the developer). My suggestion is to change SolrTestCaseJ4 and instead of putting the logic to keep temporary folders in there I'd rather: declare a global sys property that would prevent removing temporary folders (placed in TestUtil; but we can keep solr.test.leavetmpdir as an alias). In fact there already is a similar property for the runner itself: # Don't remove temporary files under slave directories, even if # the test passes. ant -Dtests.leaveTemporary= true so we could just adopt it here too. make an annotation called DirtyHarry (suggestions welcome) to mark suites which are known offenders of the default behavior. Classes annotated with DirtyHarry wouldn't fail if they leave undeletable garbage behind (but would print a warning). I also don't quite understand why you insist on things like this: rootTmpDir = TestUtil.createTempDir( "solrtest-" + cname, null , ensureClosed); initCoreDataDir = TestUtil.createTempDir( "solrtest-" + cname, rootTmpDir, ensureClosed); Why 'solrtest-*' prefix? Isn't class name enough? And why create a temporary folder under a temporary folder (if we know rootTmpDir will always be empty, even on a run when previous runs left their temporary folders a new, empty folder uniquely suffixed will be created. As for this: // TODO: tmp files should already get cleaned up by the test framework, but // we still do it here as well, so that we clean up as much as we can, even // when a test is the SuppressTempDirCleanUp annotation it isn't true. The rule to clean up temporary files is fired almost at the very end of processing, after all the after class rules have already been executed. The reason for this is that you don't want to clean up any temporary files for failed tests/ suites and you know this only after everything else has been executed. Let me know what you think, I'll make the above changes and make them ready for your review.
          Hide
          Dawid Weiss added a comment -

          Just looking at the diff file:

          +    solrHomeDirectory = createTempDir();
          +    FileUtils.deleteDirectory(solrHomeDirectory); // Ensure that a failed test didn't leave something lying around. 
          

          This is not possible. A new temporary folder will always be empty (it is uniquely suffixed if a previous folder with the same prefix exists), no need to clean it.

          You reverted timestamp-based folder creation. I don't see the point of this. Why bother (again, parent will be empty anyway).

          -      File home = TestUtil.createTempDir(getClass().getName());
          +      File home = new File(dataDir, 
          +                           getClass().getName() + "-" + 
          +                           System.currentTimeMillis()); 
          

          Same here:

          +    File indexDir = createTempDir();
          +    if (indexDir.exists())  {
          +      FileUtils.deleteDirectory(indexDir);
          +    }
          +    indexDir.mkdirs(); 
          
          Show
          Dawid Weiss added a comment - Just looking at the diff file: + solrHomeDirectory = createTempDir(); + FileUtils.deleteDirectory(solrHomeDirectory); // Ensure that a failed test didn't leave something lying around. This is not possible. A new temporary folder will always be empty (it is uniquely suffixed if a previous folder with the same prefix exists), no need to clean it. You reverted timestamp-based folder creation. I don't see the point of this. Why bother (again, parent will be empty anyway). - File home = TestUtil.createTempDir(getClass().getName()); + File home = new File(dataDir, + getClass().getName() + "-" + + System .currentTimeMillis()); Same here: + File indexDir = createTempDir(); + if (indexDir.exists()) { + FileUtils.deleteDirectory(indexDir); + } + indexDir.mkdirs();
          Hide
          Mark Miller added a comment - - edited

          I looked at the current state of the branch, Mark, and I strongly disagree with having this in TestUtil: boolean ensureCleanedUp

          I don't really care about that - I left the tension between your clean up method and Solr's because yours is not good enough for our needs yet and Solr's is not making you happy. Like I said, that's the stuff that is left to clean up. I had to put that in now, because the spellcheck tests need to run and pass.

          My suggestion is

          That sounds fine to me - I would prefer first class test framework support for this rather than having it just be a Solr thing.

          I also don't quite understand why you insist on things like this:

          I don't insist - I think that was just already there. Though come to think of it, yes, I'd prefer test was in the folder name rather than just the classname.

          it isn't true.

          My comment wasn't meant to indicate order of deletion. What it meant is that since we prevent the folder from being cleaned up via TestUtil, I still left that recursive delete so that any files that can be deleted still are.

          Like I said, this is the piece that is left to cleanup - and it's what I thought you intended from the beginning. This is what I meant when I said Dawid was working on first class test framework support and I was just doing the fix that made sense in the current world.

          Anyway, we always seem to have been on the same page but it seems you want to insist that we are not. Strange to me, but we will get there. No hurry anymore at least.

          Show
          Mark Miller added a comment - - edited I looked at the current state of the branch, Mark, and I strongly disagree with having this in TestUtil: boolean ensureCleanedUp I don't really care about that - I left the tension between your clean up method and Solr's because yours is not good enough for our needs yet and Solr's is not making you happy. Like I said, that's the stuff that is left to clean up. I had to put that in now, because the spellcheck tests need to run and pass. My suggestion is That sounds fine to me - I would prefer first class test framework support for this rather than having it just be a Solr thing. I also don't quite understand why you insist on things like this: I don't insist - I think that was just already there. Though come to think of it, yes, I'd prefer test was in the folder name rather than just the classname. it isn't true. My comment wasn't meant to indicate order of deletion. What it meant is that since we prevent the folder from being cleaned up via TestUtil, I still left that recursive delete so that any files that can be deleted still are. Like I said, this is the piece that is left to cleanup - and it's what I thought you intended from the beginning. This is what I meant when I said Dawid was working on first class test framework support and I was just doing the fix that made sense in the current world. Anyway, we always seem to have been on the same page but it seems you want to insist that we are not. Strange to me, but we will get there. No hurry anymore at least.
          Hide
          Mark Miller added a comment -

          This is not possible.

          I didn't put that there that I know of - I removed most clean up attempts I saw, but I guess that missed that one. Must have just come in with the merge.

          You reverted timestamp-based folder creation.

          I removed most of them but may have missed one or two.

          I was not 100% thorough on either of those since they don't hurt anything either - were I noticed, I removed them. You'll notice 99% of them are still gone, so they are obviously an oversight.

          There was a lot of TestUtil calls to change, we can vet them before merging back in.

          Show
          Mark Miller added a comment - This is not possible. I didn't put that there that I know of - I removed most clean up attempts I saw, but I guess that missed that one. Must have just come in with the merge. You reverted timestamp-based folder creation. I removed most of them but may have missed one or two. I was not 100% thorough on either of those since they don't hurt anything either - were I noticed, I removed them. You'll notice 99% of them are still gone, so they are obviously an oversight. There was a lot of TestUtil calls to change, we can vet them before merging back in.
          Hide
          Mark Miller added a comment -

          Just to make things simpler, take what I'm looking for and insist on from my comments and look at the branch as a work in progress.

          I'll reiterate what I'm looking for:

          1. We want a root temp directory for a Solr test. All tmp files created by that test are under this directory. Directory should be named after test class. Personally, I'd also prefer Solr and Test where in the name, but thats pretty low priority compared to the rest. I like tmp folders to be very self identifiable.

          2. As a dev, I want to be able to simply pass a sys prop to get that temp folder and all it's contents to stick around. Then I can easily explore the temporary indexes and what not that a test creates.

          3. I'd prefer we didn't have TestUtil calls all over the test code. If you want a temp folder, as you said, you should just have to ask for it - not pass any params. And getting a tmp dir for a test should be easily discoverable rather than a random Util class. Also, there should be no need to import.

          Those are my main sticking points. The rest is malleable.

          Show
          Mark Miller added a comment - Just to make things simpler, take what I'm looking for and insist on from my comments and look at the branch as a work in progress. I'll reiterate what I'm looking for: 1. We want a root temp directory for a Solr test. All tmp files created by that test are under this directory. Directory should be named after test class. Personally, I'd also prefer Solr and Test where in the name, but thats pretty low priority compared to the rest. I like tmp folders to be very self identifiable. 2. As a dev, I want to be able to simply pass a sys prop to get that temp folder and all it's contents to stick around. Then I can easily explore the temporary indexes and what not that a test creates. 3. I'd prefer we didn't have TestUtil calls all over the test code. If you want a temp folder, as you said, you should just have to ask for it - not pass any params. And getting a tmp dir for a test should be easily discoverable rather than a random Util class. Also, there should be no need to import. Those are my main sticking points. The rest is malleable.
          Hide
          Mark Miller added a comment -

          To be explicit about the main work to do on that branch:

          We are still using both delete methods - TestUtil's build in support and Solr's - why? It makes no sense to have both. But we have them because TestUtil is not good enough and we don't plan on staying with Solr. To make them both work the same, I have hacked TestUtil to work in concert with Sol's stuff. So, obviously, we have to resolve this on the branch.

          My preference would be to get first class support for what I want outside of SolrTestCaseJ4 and remove all that cleanup code entirely.

          I suppose my backup would be to continue using what we have in Solr and stop using your TestUtil - but that would defeat a lot of the progress forward.

          Show
          Mark Miller added a comment - To be explicit about the main work to do on that branch: We are still using both delete methods - TestUtil's build in support and Solr's - why? It makes no sense to have both. But we have them because TestUtil is not good enough and we don't plan on staying with Solr. To make them both work the same, I have hacked TestUtil to work in concert with Sol's stuff. So, obviously, we have to resolve this on the branch. My preference would be to get first class support for what I want outside of SolrTestCaseJ4 and remove all that cleanup code entirely. I suppose my backup would be to continue using what we have in Solr and stop using your TestUtil - but that would defeat a lot of the progress forward.
          Hide
          ASF subversion and git services added a comment -

          Commit 1583163 from Mark Miller in branch 'dev/branches/solr5914'
          [ https://svn.apache.org/r1583163 ]

          SOLR-5914: Polish up createTempDir calls.

          Show
          ASF subversion and git services added a comment - Commit 1583163 from Mark Miller in branch 'dev/branches/solr5914' [ https://svn.apache.org/r1583163 ] SOLR-5914 : Polish up createTempDir calls.
          Hide
          Dawid Weiss added a comment -

          > Anyway, we always seem to have been on the same page but it seems you want to insist that we are not.

          We are, I never meant to give you an impression that we're not. Discussion leads progress forward.

          I'll try to address your points above, give me some time though, I think all are addressable. I need a spare minute out of work to handle this.

          Show
          Dawid Weiss added a comment - > Anyway, we always seem to have been on the same page but it seems you want to insist that we are not. We are, I never meant to give you an impression that we're not. Discussion leads progress forward. I'll try to address your points above, give me some time though, I think all are addressable. I need a spare minute out of work to handle this.
          Hide
          Dawid Weiss added a comment -

          I've committed some cleanups to the branch but I have some more on disk, unfinished. Don't bother looking at the branch yet, pls.

          Show
          Dawid Weiss added a comment - I've committed some cleanups to the branch but I have some more on disk, unfinished. Don't bother looking at the branch yet, pls.
          Hide
          Dawid Weiss added a comment -

          I will close this issue because Mark addressed it already with his round of fixes and the temporary-resource refactoring has grown into a bigger deal.

          Show
          Dawid Weiss added a comment - I will close this issue because Mark addressed it already with his round of fixes and the temporary-resource refactoring has grown into a bigger deal.
          Hide
          Uwe Schindler added a comment -

          Close issue after release of 4.8.0

          Show
          Uwe Schindler added a comment - Close issue after release of 4.8.0

            People

            • Assignee:
              Mark Miller
              Reporter:
              Uwe Schindler
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development