Solr
  1. Solr
  2. SOLR-5906

core.properties values may get ignored in some cases when using the Collection API

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.7
    • Fix Version/s: 4.7.1, 4.8, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      SOLR-5208 added the functionality that allows the setting of variables (core.properties) on Collections API CREATE command.

      I wanted to create a collection using the collection API and set a different instanceDir.

      So if I try out the following API call, property.instanceDir will not be used because of the logic in CoreAdminHandler.buildCoreDescriptor()

      http://localhost:8983/solr/admin/collections?action=CREATE&name=foo&numShards=1&property.instanceDir=/foo
      

      There might be other similar cases I guess.

      1. SOLR-5906.patch
        4 kB
        Shalin Shekhar Mangar
      2. SOLR-5906.patch
        4 kB
        Shalin Shekhar Mangar
      3. SOLR-5906.patch
        2 kB
        Varun Thacker

        Activity

        Hide
        Varun Thacker added a comment -

        Patch checks for the value of property.instanceDir when instanceDir param is not present in the call

        Show
        Varun Thacker added a comment - Patch checks for the value of property.instanceDir when instanceDir param is not present in the call
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Varun! I added a test.

        Show
        Shalin Shekhar Mangar added a comment - Thanks Varun! I added a test.
        Hide
        Shalin Shekhar Mangar added a comment -

        Fixed the test to compare absolute path always.

        Show
        Shalin Shekhar Mangar added a comment - Fixed the test to compare absolute path always.
        Hide
        ASF subversion and git services added a comment -

        Commit 1581341 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1581341 ]

        SOLR-5906: Collection create API ignores property.instanceDir parameter

        Show
        ASF subversion and git services added a comment - Commit 1581341 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1581341 ] SOLR-5906 : Collection create API ignores property.instanceDir parameter
        Hide
        ASF subversion and git services added a comment -

        Commit 1581344 from shalin@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1581344 ]

        SOLR-5906: Collection create API ignores property.instanceDir parameter

        Show
        ASF subversion and git services added a comment - Commit 1581344 from shalin@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1581344 ] SOLR-5906 : Collection create API ignores property.instanceDir parameter
        Hide
        ASF subversion and git services added a comment -

        Commit 1581347 from shalin@apache.org in branch 'dev/branches/lucene_solr_4_7'
        [ https://svn.apache.org/r1581347 ]

        SOLR-5906: Collection create API ignores property.instanceDir parameter

        Show
        ASF subversion and git services added a comment - Commit 1581347 from shalin@apache.org in branch 'dev/branches/lucene_solr_4_7' [ https://svn.apache.org/r1581347 ] SOLR-5906 : Collection create API ignores property.instanceDir parameter
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Varun!

        Show
        Shalin Shekhar Mangar added a comment - Thanks Varun!
        Hide
        Steve Rowe added a comment -

        Bulk close 4.7.1 issues

        Show
        Steve Rowe added a comment - Bulk close 4.7.1 issues

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Varun Thacker
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development