[SOLR-5874] Unsafe cast in RouteException

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.6.1
• Fix Version/s: 4.7.1, 4.8, 6.0
• Component/s: clients - java
• Assignee: Mark Miller
• Reporter: David Arthur
• Created: 17/Mar/14 13:47
• Updated: 09/May/16 18:43
• Resolved: 23/Mar/14 17:56

Description

When a non-Exception is thrown somewhere in the CloudSolrServer, I get a "XXX cannot be cast to java.lang.Exception"

java.lang.ClassCastException: java.lang.NoClassDefFoundError cannot be cast to java.lang.Exception
	at org.apache.solr.client.solrj.impl.CloudSolrServer$RouteException.<init>(CloudSolrServer.java:484)
	at org.apache.solr.client.solrj.impl.CloudSolrServer.directUpdate(CloudSolrServer.java:351)
	at org.apache.solr.client.solrj.impl.CloudSolrServer.request(CloudSolrServer.java:510)
	at org.apache.solr.client.solrj.request.AbstractUpdateRequest.process(AbstractUpdateRequest.java:117)

Should probably cast to Throwable, or do a check and wrap non-Exceptions in an Exception first