Solr
  1. Solr
  2. SOLR-5838

Relative SolrHome Path Bug At AbstractFullDistribZkTestBase

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.6.1, 4.7
    • Fix Version/s: 4.8, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      getRelativeSolrHomePath method at AbstractFullDistribZkTestBase has a control like that:

      if (base.startsWith("."));
      base.replaceFirst("\\.", new File(".").getName());
      

      if statement does nothing and result of replaceFirst is ignored.

      1. SOLR-5838.patch
        1 kB
        Furkan KAMACI

        Activity

        Hide
        Furkan KAMACI added a comment -

        I've applied a patch. Also changed that:

        p.append(".." + File.separator);
        

        to this:

        p.append("..").append(File.separator);
        
        Show
        Furkan KAMACI added a comment - I've applied a patch. Also changed that: p.append( ".." + File.separator); to this: p.append( ".." ).append(File.separator);
        Hide
        ASF subversion and git services added a comment -

        Commit 1578089 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1578089 ]

        SOLR-5838: Relative SolrHome Path Bug At AbstractFullDistribZkTestBase

        Show
        ASF subversion and git services added a comment - Commit 1578089 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1578089 ] SOLR-5838 : Relative SolrHome Path Bug At AbstractFullDistribZkTestBase
        Hide
        ASF subversion and git services added a comment -

        Commit 1578090 from shalin@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1578090 ]

        SOLR-5838: Relative SolrHome Path Bug At AbstractFullDistribZkTestBase

        Show
        ASF subversion and git services added a comment - Commit 1578090 from shalin@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1578090 ] SOLR-5838 : Relative SolrHome Path Bug At AbstractFullDistribZkTestBase
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Furkan!

        Show
        Shalin Shekhar Mangar added a comment - Thanks Furkan!
        Hide
        Uwe Schindler added a comment -

        Close issue after release of 4.8.0

        Show
        Uwe Schindler added a comment - Close issue after release of 4.8.0

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Furkan KAMACI
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development