[SOLR-5836] CSVConfig Invalid Check For Equals

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Not A Problem
• Affects Version/s: 4.6.1, 4.7
• Component/s: Response Writers
• Assignee: Unassigned
• Reporter: Furkan Kamaci
• Created: 08/Mar/14 15:33
• Updated: 20/Jul/19 12:54
• Resolved: 20/Jul/19 12:54

Description

When I was checking the source code of Solr I realized that equals method at CSVConfig.java does an unnecessary or invalid checking as follows:

    /**
     * TODO..
     * @see java.lang.Object#equals(java.lang.Object)
     */
    @Override
    public boolean equals(Object obj) {
        if (obj == null && !(obj instanceof CSVConfig)) {
            return false;
        }
        return super.equals(obj);
//        CSVConfig config = (CSVConfig) obj;
//        getFill() == config.getFill()
//        getFields().equals(config.getFields())
    }

if obj is null it can not be an instance of CSVConfig so it is unnecessary. On the other hand it does not make a valid check so I have changed the equals criteria to OR.