Solr
  1. Solr
  2. SOLR-5834

Overseer threads are only being interrupted and not closed.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.7.1, 4.8, 6.0
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      As noticed by Hossman in SOLR-5823, the Overseer is not actually calling close on the runnables that are used to create threads - the treads are only being interrupted in Overseer#close, but not closed.

        Issue Links

          Activity

          Hide
          ASF subversion and git services added a comment -

          Commit 1575476 from Mark Miller in branch 'dev/trunk'
          [ https://svn.apache.org/r1575476 ]

          SOLR-5834: Overseer threads are only being interrupted and not closed.

          Show
          ASF subversion and git services added a comment - Commit 1575476 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1575476 ] SOLR-5834 : Overseer threads are only being interrupted and not closed.
          Hide
          Mark Miller added a comment -

          I'm hoping this has something to do with our Overseer test fail that is somewhat common. It may be that when we did more sleeping, an interrupt was more effective at stopping than thread than it is these days?

          Show
          Mark Miller added a comment - I'm hoping this has something to do with our Overseer test fail that is somewhat common. It may be that when we did more sleeping, an interrupt was more effective at stopping than thread than it is these days?
          Hide
          ASF subversion and git services added a comment -

          Commit 1575477 from Mark Miller in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1575477 ]

          SOLR-5834: Overseer threads are only being interrupted and not closed.

          Show
          ASF subversion and git services added a comment - Commit 1575477 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1575477 ] SOLR-5834 : Overseer threads are only being interrupted and not closed.
          Hide
          Mark Miller added a comment -

          I'm hoping this has something to do with our Overseer test fail

          I guess probably not though This shouldn't actually affect whether or not the zk leader is removed or not.

          Show
          Mark Miller added a comment - I'm hoping this has something to do with our Overseer test fail I guess probably not though This shouldn't actually affect whether or not the zk leader is removed or not.
          Hide
          Steve Rowe added a comment -

          Mark Miller, any reason not to backport this to 4.7.1?

          Show
          Steve Rowe added a comment - Mark Miller , any reason not to backport this to 4.7.1?
          Hide
          ASF subversion and git services added a comment -

          Commit 1581209 from Steve Rowe in branch 'dev/branches/lucene_solr_4_7'
          [ https://svn.apache.org/r1581209 ]

          SOLR-5834: Overseer threads are only being interrupted and not closed. (merged branch_4x r1575477)

          Show
          ASF subversion and git services added a comment - Commit 1581209 from Steve Rowe in branch 'dev/branches/lucene_solr_4_7' [ https://svn.apache.org/r1581209 ] SOLR-5834 : Overseer threads are only being interrupted and not closed. (merged branch_4x r1575477)
          Hide
          ASF subversion and git services added a comment -

          Commit 1581212 from Steve Rowe in branch 'dev/trunk'
          [ https://svn.apache.org/r1581212 ]

          SOLR-5834: move CHANGES.txt entry to 4.7.1 section

          Show
          ASF subversion and git services added a comment - Commit 1581212 from Steve Rowe in branch 'dev/trunk' [ https://svn.apache.org/r1581212 ] SOLR-5834 : move CHANGES.txt entry to 4.7.1 section
          Hide
          ASF subversion and git services added a comment -

          Commit 1581213 from Steve Rowe in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1581213 ]

          SOLR-5834: move CHANGES.txt entry to 4.7.1 section (merged trunk r1581212)

          Show
          ASF subversion and git services added a comment - Commit 1581213 from Steve Rowe in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1581213 ] SOLR-5834 : move CHANGES.txt entry to 4.7.1 section (merged trunk r1581212)
          Hide
          Steve Rowe added a comment -

          Mark, I think this issue can be resolved?

          Show
          Steve Rowe added a comment - Mark, I think this issue can be resolved?
          Hide
          Steve Rowe added a comment -

          Bulk close 4.7.1 issues

          Show
          Steve Rowe added a comment - Bulk close 4.7.1 issues
          Hide
          Shalin Shekhar Mangar added a comment -

          Mark Miller - You remove volatile from the definition of OverseerCollectionProcessor.isClosed. Was that deliberate? I read the discussion on SOLR-5823 but couldn't figure out why that was necessary.

          Show
          Shalin Shekhar Mangar added a comment - Mark Miller - You remove volatile from the definition of OverseerCollectionProcessor.isClosed. Was that deliberate? I read the discussion on SOLR-5823 but couldn't figure out why that was necessary.

            People

            • Assignee:
              Mark Miller
              Reporter:
              Mark Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development