Solr
  1. Solr
  2. SOLR-5741

UpdateShardHandler not setting max connections correctly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.6.1
    • Fix Version/s: 4.7, 6.0
    • Component/s: SolrCloud, update
    • Labels:

      Description

      The following line in UpdateShardHandler.java looks incorrect to me:

      clientConnectionManager.setDefaultMaxPerRoute(cfg.getMaxUpdateConnections());
      

      I think it should be:

      clientConnectionManager.setMaxTotal(cfg.getMaxUpdateConnections());
      
      1. SOLR-5741.patch
        0.7 kB
        Shawn Heisey

        Activity

        Hide
        Shawn Heisey added a comment -

        Patch against trunk.

        Show
        Shawn Heisey added a comment - Patch against trunk.
        Hide
        Shawn Heisey added a comment -

        I'm inclined to go ahead and commit this to 4x and trunk, but I'd like a sanity check. This might explain some recent problems people have been having with sending lots of updates to large clouds.

        Show
        Shawn Heisey added a comment - I'm inclined to go ahead and commit this to 4x and trunk, but I'd like a sanity check. This might explain some recent problems people have been having with sending lots of updates to large clouds.
        Hide
        Mark Miller added a comment -

        +1

        Show
        Mark Miller added a comment - +1
        Hide
        Shawn Heisey added a comment -

        Thanks for the sanity check. I'll go ahead.

        On a related note, I notice that HttpShardHandlerFactory has an option to set the max per host, but not the max total. I don't know how everything interacts, so I don't know if that should also get an update.

        Show
        Shawn Heisey added a comment - Thanks for the sanity check. I'll go ahead. On a related note, I notice that HttpShardHandlerFactory has an option to set the max per host, but not the max total. I don't know how everything interacts, so I don't know if that should also get an update.
        Hide
        ASF subversion and git services added a comment -

        Commit 1569152 from Shawn Heisey in branch 'dev/trunk'
        [ https://svn.apache.org/r1569152 ]

        SOLR-5741: correctly set max total connections on the HttpClient.

        Show
        ASF subversion and git services added a comment - Commit 1569152 from Shawn Heisey in branch 'dev/trunk' [ https://svn.apache.org/r1569152 ] SOLR-5741 : correctly set max total connections on the HttpClient.
        Hide
        ASF subversion and git services added a comment -

        Commit 1569153 from Shawn Heisey in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1569153 ]

        SOLR-5741: correctly set max total connections on the HttpClient. (merge trunk r1569152)

        Show
        ASF subversion and git services added a comment - Commit 1569153 from Shawn Heisey in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1569153 ] SOLR-5741 : correctly set max total connections on the HttpClient. (merge trunk r1569152)

          People

          • Assignee:
            Shawn Heisey
            Reporter:
            Shawn Heisey
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development