[SOLR-5689] On reconnect, ZkController cancels election on first context rather than latest

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.6.1, 4.7, 6.0
• Fix Version/s: 4.7, 6.0
• Assignee: Shalin Shekhar Mangar
• Reporter: Gregory Chanan
• Created: 02/Feb/14 22:34
• Updated: 09/May/16 18:57
• Resolved: 11/Feb/14 11:14

Description

I haven't tested this yet, so I could be wrong, but this is my reading of the code:
During init:

ElectionContext context = new OverseerElectionContext(zkClient, overseer, getNodeName());
overseerElector.setup(context);
overseerElector.joinElection(context, false);

On reconnect:

ElectionContext context = new OverseerElectionContext(zkClient,overseer, getNodeName());
              
ElectionContext prevContext = overseerElector.getContext();
if (prevContext != null) {
  prevContext.cancelElection();
}
              
overseerElector.joinElection(context, true);

setup doesn't appear to be called on reconnect, so the new context is never set and the first context gets cancelled over and over.

A call to overseerElector.setup(context); before joinElection in the reconnect case would address this.