Solr
  1. Solr
  2. SOLR-5682

Make the admin InfoHandler more pluggable / derivable

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.7, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      As of SOLR-5556 a user can specify the class of the admin InfoHandler, but can't easily override the individual handlers that it provides (the PropertiesRequestHandler, LoggingHandler, ThreadDumpHandler, SystemInfoHandler).

      Contrast this with say, the AdminHandlers, where a user can provide his/her own implementations of the underlying request handlers easily.

      I've run into this limitation in the following setup: I use derived versions of the various AdminHandlers, and would like to use the same implementations for the InfoHandler. I can do this by deriving from InfoHandler, but then I'd need to duplicate the handleRequestBody dispatching code. That's doable, but not as nice as what the AdminHandlers provides.

      1. SOLR-5682.patch
        5 kB
        Gregory Chanan
      2. SOLR-5682v2.patch
        5 kB
        Gregory Chanan

        Activity

        Hide
        Gregory Chanan added a comment -

        Here's a patch that provides this functionality along with a unit test.

        Show
        Gregory Chanan added a comment - Here's a patch that provides this functionality along with a unit test.
        Hide
        Gregory Chanan added a comment -

        Corrected patch.

        Show
        Gregory Chanan added a comment - Corrected patch.
        Hide
        Mark Miller added a comment -

        Kind of an interesting interaction here...SolrInfoMBeanTest fails because of the private static classes in InfoHandlerTest.

        I've made those classes public to get that test passing.

        Show
        Mark Miller added a comment - Kind of an interesting interaction here...SolrInfoMBeanTest fails because of the private static classes in InfoHandlerTest. I've made those classes public to get that test passing.
        Hide
        ASF subversion and git services added a comment -

        Commit 1565067 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1565067 ]

        SOLR-5682: Make the admin InfoHandler more pluggable / derivable.

        Show
        ASF subversion and git services added a comment - Commit 1565067 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1565067 ] SOLR-5682 : Make the admin InfoHandler more pluggable / derivable.
        Hide
        ASF subversion and git services added a comment -

        Commit 1565068 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1565068 ]

        SOLR-5682: Make the admin InfoHandler more pluggable / derivable.

        Show
        ASF subversion and git services added a comment - Commit 1565068 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1565068 ] SOLR-5682 : Make the admin InfoHandler more pluggable / derivable.
        Hide
        Mark Miller added a comment -

        Thanks Greg!

        Show
        Mark Miller added a comment - Thanks Greg!

          People

          • Assignee:
            Mark Miller
            Reporter:
            Gregory Chanan
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development