Solr
  1. Solr
  2. SOLR-5317

CoreAdmin API is not persisting data properly

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.5.1, 4.6, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      There is a regression between 4.4 and 4.5 with the CoreAdmin API, the command doesn't save the result on solr.xml at time that is executed.

      The full process is describe here: https://gist.github.com/yriveiro/6883208

      1. SOLR-5317.patch
        13 kB
        Mark Miller

        Activity

        Hide
        Mark Miller added a comment -

        More testing and a fix.

        Show
        Mark Miller added a comment - More testing and a fix.
        Hide
        Mark Miller added a comment -

        Some re-factoring in this area caused this bug - it was only saving the existing clouddescriptors in the corecontainer, and not any new ones - so if a core was created, it would not be persisted, but if you made a second core, the first would end up persisted and so on.

        This only affected the old style solr.xml mode (with cores defined in solr.xml).

        Show
        Mark Miller added a comment - Some re-factoring in this area caused this bug - it was only saving the existing clouddescriptors in the corecontainer, and not any new ones - so if a core was created, it would not be persisted, but if you made a second core, the first would end up persisted and so on. This only affected the old style solr.xml mode (with cores defined in solr.xml).
        Hide
        ASF subversion and git services added a comment -

        Commit 1530856 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1530856 ]

        SOLR-5317: SolrCore persistence bugs if defining SolrCores in solr.xml.

        Show
        ASF subversion and git services added a comment - Commit 1530856 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1530856 ] SOLR-5317 : SolrCore persistence bugs if defining SolrCores in solr.xml.
        Hide
        Mark Miller added a comment -

        Hmm...the clean back port to 4x seems to have an issue - I'll investigate tomorrow.

        Show
        Mark Miller added a comment - Hmm...the clean back port to 4x seems to have an issue - I'll investigate tomorrow.
        Hide
        ASF subversion and git services added a comment -

        Commit 1530982 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1530982 ]

        SOLR-5317: SolrCore persistence bugs if defining SolrCores in solr.xml.

        Show
        ASF subversion and git services added a comment - Commit 1530982 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1530982 ] SOLR-5317 : SolrCore persistence bugs if defining SolrCores in solr.xml.
        Hide
        ASF subversion and git services added a comment -

        Commit 1530993 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1530993 ]

        SOLR-5317: tests: Compare absolute paths

        Show
        ASF subversion and git services added a comment - Commit 1530993 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1530993 ] SOLR-5317 : tests: Compare absolute paths
        Hide
        ASF subversion and git services added a comment -

        Commit 1530995 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1530995 ]

        SOLR-5317: tests: Compare absolute paths

        Show
        ASF subversion and git services added a comment - Commit 1530995 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1530995 ] SOLR-5317 : tests: Compare absolute paths
        Hide
        Mark Miller added a comment -

        I've got a seed that this still fails on.

        Show
        Mark Miller added a comment - I've got a seed that this still fails on.
        Hide
        Mark Miller added a comment -

        Found the issue - I'll commit the fix shortly.

        Show
        Mark Miller added a comment - Found the issue - I'll commit the fix shortly.
        Hide
        ASF subversion and git services added a comment -

        Commit 1531162 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1531162 ]

        SOLR-5317: Fix race when persisting cores in solr.xml

        Show
        ASF subversion and git services added a comment - Commit 1531162 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1531162 ] SOLR-5317 : Fix race when persisting cores in solr.xml
        Hide
        ASF subversion and git services added a comment -

        Commit 1531163 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1531163 ]

        SOLR-5317: Fix race when persisting cores in solr.xml

        Show
        ASF subversion and git services added a comment - Commit 1531163 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1531163 ] SOLR-5317 : Fix race when persisting cores in solr.xml
        Hide
        ASF subversion and git services added a comment -

        Commit 1531171 from Mark Miller in branch 'dev/branches/lucene_solr_4_5'
        [ https://svn.apache.org/r1531171 ]

        SOLR-5317: SolrCore persistence bugs if defining SolrCores in solr.xml
        tests: Compare absolute paths
        Fix race when persisting cores in solr.xml

        Show
        ASF subversion and git services added a comment - Commit 1531171 from Mark Miller in branch 'dev/branches/lucene_solr_4_5' [ https://svn.apache.org/r1531171 ] SOLR-5317 : SolrCore persistence bugs if defining SolrCores in solr.xml tests: Compare absolute paths Fix race when persisting cores in solr.xml
        Hide
        ASF subversion and git services added a comment -

        Commit 1531172 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1531172 ]

        SOLR-5317: remove debug sys errs

        Show
        ASF subversion and git services added a comment - Commit 1531172 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1531172 ] SOLR-5317 : remove debug sys errs
        Hide
        ASF subversion and git services added a comment -

        Commit 1531173 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1531173 ]

        SOLR-5317: remove debug sys errs

        Show
        ASF subversion and git services added a comment - Commit 1531173 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1531173 ] SOLR-5317 : remove debug sys errs
        Hide
        Mark Miller added a comment -

        Thanks Yago!

        Show
        Mark Miller added a comment - Thanks Yago!

          People

          • Assignee:
            Mark Miller
            Reporter:
            Yago Riveiro
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development