Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-5233

admin/collections?action=DELETESHARD broken

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.4
    • Fix Version/s: 4.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      The problem we saw was that deleting a shard did not actually delete it, although it semi-claimed to have done so.

       
      ...
      o.a.s.c.OverseerCollectionProcessor [OverseerCollectionProcessor.java:723]
      Delete shard invoked
      ...
      o.a.s.c.OverseerCollectionProcessor [OverseerCollectionProcessor.java:781]
      Successfully deleted collection collection1, shard: null
      ...
      
      1. SOLR-5233.patch
        6 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        cpoerschke Christine Poerschke added a comment -

        From looking at the code, OverseerCollectionProcessor.java, in deleteShard it's a copy/paste problem and a few of the message.getStr("name") need to be sliceId and sliceId as well as collection needs to be passed as part of the Overseer.REMOVESHARD operation.

        Show
        cpoerschke Christine Poerschke added a comment - From looking at the code, OverseerCollectionProcessor.java, in deleteShard it's a copy/paste problem and a few of the message.getStr("name") need to be sliceId and sliceId as well as collection needs to be passed as part of the Overseer.REMOVESHARD operation.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -
        1. Used constants everywhere to avoid passing wrong parameters.
        2. Fixed logging in OverseerCollectionProcessor

        The deleteshard succeeds even without this patch because a shard is deleted if all cores are unloaded. It can fail without this patch if some cores were down. Also, without this patch, the wait logic in OverseerCollectionProcessor was wrong and didn't actually wait for the cluster state to update.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Used constants everywhere to avoid passing wrong parameters. Fixed logging in OverseerCollectionProcessor The deleteshard succeeds even without this patch because a shard is deleted if all cores are unloaded. It can fail without this patch if some cores were down. Also, without this patch, the wait logic in OverseerCollectionProcessor was wrong and didn't actually wait for the cluster state to update.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1522463 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1522463 ]

        SOLR-5233: The deleteshard collections API doesn't wait for cluster state to update, can fail if some nodes of the deleted shard were down and had incorrect logging.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1522463 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1522463 ] SOLR-5233 : The deleteshard collections API doesn't wait for cluster state to update, can fail if some nodes of the deleted shard were down and had incorrect logging.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1522465 from shalin@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1522465 ]

        SOLR-5233: The deleteshard collections API doesn't wait for cluster state to update, can fail if some nodes of the deleted shard were down and had incorrect logging.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1522465 from shalin@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1522465 ] SOLR-5233 : The deleteshard collections API doesn't wait for cluster state to update, can fail if some nodes of the deleted shard were down and had incorrect logging.
        Hide
        jpountz Adrien Grand added a comment -

        4.5 release -> bulk close

        Show
        jpountz Adrien Grand added a comment - 4.5 release -> bulk close

          People

          • Assignee:
            shalinmangar Shalin Shekhar Mangar
            Reporter:
            cpoerschke Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development