Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-5134

Have HdfsIndexOutput extend BufferedIndexOutput

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.4
    • Fix Version/s: 4.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Upstream Blur has moved HdfsIndexOutput to use BufferedIndexOutput and the simple FS IndexOutput does as well - seems we should do the same.

      1. SOLR-5134.patch
        2 kB
        Mark Miller
      2. SOLR-5134.patch
        2 kB
        Mark Miller

        Activity

        Hide
        jpountz Adrien Grand added a comment -

        4.5 release -> bulk close

        Show
        jpountz Adrien Grand added a comment - 4.5 release -> bulk close
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        Thanks Uwe!

        Show
        markrmiller@gmail.com Mark Miller added a comment - Thanks Uwe!
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1513860 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1513860 ]

        SOLR-5134: Fix CHANGES and close

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1513860 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1513860 ] SOLR-5134 : Fix CHANGES and close
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1513859 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1513859 ]

        SOLR-5134: Fix CHANGES and close

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1513859 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1513859 ] SOLR-5134 : Fix CHANGES and close
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1513843 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1513843 ]

        SOLR-5134: Have HdfsIndexOutput extend BufferedIndexOutput.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1513843 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1513843 ] SOLR-5134 : Have HdfsIndexOutput extend BufferedIndexOutput.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1513825 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1513825 ]

        SOLR-5134: Have HdfsIndexOutput extend BufferedIndexOutput.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1513825 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1513825 ] SOLR-5134 : Have HdfsIndexOutput extend BufferedIndexOutput.
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        Thanks Uwe - new patch attached.

        Show
        markrmiller@gmail.com Mark Miller added a comment - Thanks Uwe - new patch attached.
        Hide
        thetaphi Uwe Schindler added a comment -

        Hi Mark,
        I think for saefty the close() method in the HdfsIndexOutput should be implemented like the one of FSIndexOutput in my recent patch on LUCENE-5164:
        It should use IOUtils.closeWhileHandlingException with the possible IOException of super.close(). Otherwise it might happen that the output is not fully closed if an error on writing the final buffer happens.

        Show
        thetaphi Uwe Schindler added a comment - Hi Mark, I think for saefty the close() method in the HdfsIndexOutput should be implemented like the one of FSIndexOutput in my recent patch on LUCENE-5164 : It should use IOUtils.closeWhileHandlingException with the possible IOException of super.close(). Otherwise it might happen that the output is not fully closed if an error on writing the final buffer happens.

          People

          • Assignee:
            markrmiller@gmail.com Mark Miller
            Reporter:
            markrmiller@gmail.com Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development