[SOLR-4870] RecentUpdates.update() does not increment numUpdates counter inside loop

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.3
• Fix Version/s: 4.3.1
• Assignee: Shalin Shekhar Mangar
• Reporter: Shalin Shekhar Mangar
• Created: 29/May/13 07:54
• Updated: 18/Jun/13 16:52
• Resolved: 30/May/13 15:41

Description

As reported by AlexeyK on solr-user:

http://lucene.472066.n3.nabble.com/Solr-4-3-node-is-seen-as-active-in-Zk-while-in-recovery-mode-endless-recovery-td4065549.html

Speaking about the update log - i have noticed a strange behavior concerning
the replay. The replay is supposed to be done for a predefined number of
log entries, but actually it is always done for the whole last 2 tlogs.
RecentUpdates.update() reads log within while (numUpdates <
numRecordsToKeep), while numUpdates is never incremented, so it exits when
the reader reaches EOF.