Solr
  1. Solr
  2. SOLR-4870

RecentUpdates.update() does not increment numUpdates counter inside loop

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.3
    • Fix Version/s: 4.3.1
    • Component/s: None
    • Labels:
      None

      Description

      As reported by AlexeyK on solr-user:

      http://lucene.472066.n3.nabble.com/Solr-4-3-node-is-seen-as-active-in-Zk-while-in-recovery-mode-endless-recovery-td4065549.html

      Speaking about the update log - i have noticed a strange behavior concerning
      the replay. The replay is supposed to be done for a predefined number of
      log entries, but actually it is always done for the whole last 2 tlogs.
      RecentUpdates.update() reads log within while (numUpdates <
      numRecordsToKeep), while numUpdates is never incremented, so it exits when
      the reader reaches EOF.

        Activity

        Hide
        Shalin Shekhar Mangar added a comment -

        Committed.

        trunk: r1487897
        branch_4x: r1487899
        lucene_solr_4_3: r1487900

        Show
        Shalin Shekhar Mangar added a comment - Committed. trunk: r1487897 branch_4x: r1487899 lucene_solr_4_3: r1487900
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close after 4.3.1 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close after 4.3.1 release

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development