Solr
  1. Solr
  2. SOLR-4855

DistributedUpdateProcessor doesn't check for peer sync

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.3
    • Fix Version/s: 4.3.1, 4.4
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      DistributedUpdateProcessor has the following code:

      boolean isReplayOrPeersync = (cmd.getFlags() & (UpdateCommand.REPLAY | UpdateCommand.REPLAY)) != 0;
      

      It should be replaced by:

      boolean isReplayOrPeersync = (cmd.getFlags() & (UpdateCommand.REPLAY | UpdateCommand.PEER_SYNC)) != 0;
      
      1. SOLR-4855.patch
        2 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        Shalin Shekhar Mangar added a comment -

        Fix attached.

        I don't know how to write a test for this but at least nothing breaks with the fix.

        Show
        Shalin Shekhar Mangar added a comment - Fix attached. I don't know how to write a test for this but at least nothing breaks with the fix.
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed r1487538 on trunk and r1487540 on branch_4x.

        Show
        Shalin Shekhar Mangar added a comment - Committed r1487538 on trunk and r1487540 on branch_4x.
        Hide
        Yonik Seeley added a comment -

        Seems like this should go to the 4.3 branch for 4.3.1 too?

        Show
        Yonik Seeley added a comment - Seems like this should go to the 4.3 branch for 4.3.1 too?
        Hide
        Shalin Shekhar Mangar added a comment -

        I wasn't sure of the consequences of this issue.

        I'll backport it to 4.3.1

        Show
        Shalin Shekhar Mangar added a comment - I wasn't sure of the consequences of this issue. I'll backport it to 4.3.1
        Hide
        Shalin Shekhar Mangar added a comment -

        Backported to 4.3.1 r1487554.

        Show
        Shalin Shekhar Mangar added a comment - Backported to 4.3.1 r1487554.
        Hide
        Shalin Shekhar Mangar added a comment -

        Bulk close after 4.3.1 release

        Show
        Shalin Shekhar Mangar added a comment - Bulk close after 4.3.1 release

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development