Solr
  1. Solr
  2. SOLR-48

an empty query string in the admin interface throws an exception

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0
    • Component/s: web gui
    • Labels:
      None
    • Environment:

      GNU/linux, sun-jdk 1.5.0-07, solr checked out from the read-only svn today

      Description

      If you just click search in the admin interface without entering a query string, the following error is displayed:

      org.apache.solr.core.SolrException: Missing queryString
      at org.apache.solr.request.StandardRequestHandler.handleRequest(StandardRequestHandler.java:104)
      at org.apache.solr.core.SolrCore.execute(SolrCore.java:586)
      at org.apache.solr.servlet.SolrServlet.doGet(SolrServlet.java:91)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:596)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:689)
      at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:428)
      at org.mortbay.jetty.servlet.WebApplicationHandler.dispatch(WebApplicationHandler.java:473)
      at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:568)
      at org.mortbay.http.HttpContext.handle(HttpContext.java:1530)
      at org.mortbay.jetty.servlet.WebApplicationContext.handle(WebApplicationContext.java:633)
      at org.mortbay.http.HttpContext.handle(HttpContext.java:1482)
      at org.mortbay.http.HttpServer.service(HttpServer.java:909)
      at org.mortbay.http.HttpConnection.service(HttpConnection.java:820)
      at org.mortbay.http.HttpConnection.handleNext(HttpConnection.java:986)
      at org.mortbay.http.HttpConnection.handle(HttpConnection.java:837)
      at org.mortbay.http.SocketListener.handleConnection(SocketListener.java:245)
      at org.mortbay.util.ThreadedServer.handle(ThreadedServer.java:357)
      at org.mortbay.util.ThreadPool$PoolThread.run(ThreadPool.java:534)

      A JScript-triggered warning of some sort would be better, or short of that, an automatic return to the query interface with a human-readable error message.

        Activity

        Hide
        Hoss Man added a comment -

        This bug was modified as part of a bulk update using the criteria...

        • Marked ("Resolved" or "Closed") and "Fixed"
        • Had no "Fix Version" versions
        • Was listed in the CHANGES.txt for 1.1

        The Fix Version for all 38 issues found was set to 1.1, email notification
        was suppressed to prevent excessive email.

        For a list of all the issues modified, search jira comments for this
        (hopefully) unique string: 20080415hossman3

        Show
        Hoss Man added a comment - This bug was modified as part of a bulk update using the criteria... Marked ("Resolved" or "Closed") and "Fixed" Had no "Fix Version" versions Was listed in the CHANGES.txt for 1.1 The Fix Version for all 38 issues found was set to 1.1, email notification was suppressed to prevent excessive email. For a list of all the issues modified, search jira comments for this (hopefully) unique string: 20080415hossman3
        Hide
        Bill Au added a comment -

        Patch commited. Thanks for the code.

        Show
        Bill Au added a comment - Patch commited. Thanks for the code.
        Hide
        Tomislav Nakic-Alfirevic added a comment -

        Glad to hear all the good news.

        Show
        Tomislav Nakic-Alfirevic added a comment - Glad to hear all the good news.
        Hide
        Bill Au added a comment -

        FYI, the javascript works for safari too.

        Show
        Bill Au added a comment - FYI, the javascript works for safari too.
        Hide
        Bill Au added a comment -

        patch with fix to solr-48

        Show
        Bill Au added a comment - patch with fix to solr-48
        Hide
        Bill Au added a comment -

        That works for both firefox and IE7. Thanks for the code. I will fix both the admin main page and the "full interface" page.

        Show
        Bill Au added a comment - That works for both firefox and IE7. Thanks for the code. I will fix both the admin main page and the "full interface" page.
        Hide
        Tomislav Nakic-Alfirevic added a comment -

        This should do the trick:

        <form name=f1 method=post>
        Query text: <input type=text name=n>
        <input type=button value='GO' onclick="if(f1.n.value.length==0) alert('no empty queries, please'); else f1.submit();">
        </form>

        Show
        Tomislav Nakic-Alfirevic added a comment - This should do the trick: <form name=f1 method=post> Query text: <input type=text name=n> <input type=button value='GO' onclick="if(f1.n.value.length==0) alert('no empty queries, please'); else f1.submit();"> </form>
        Hide
        Hoss Man added a comment -

        solving this with javascript on the admin page seems like a fine idea .. but i wouldn't want to try and put redirect logic or "pretty" error messages into the request handlers – the expectation is that other code will be hitting the /select urls, the query form on the admin interface is just for convinience.

        if any javascript guru's out there would care to whip up a handy function that works well on the major browsers, i'll happily commit it.

        Show
        Hoss Man added a comment - solving this with javascript on the admin page seems like a fine idea .. but i wouldn't want to try and put redirect logic or "pretty" error messages into the request handlers – the expectation is that other code will be hitting the /select urls, the query form on the admin interface is just for convinience. if any javascript guru's out there would care to whip up a handy function that works well on the major browsers, i'll happily commit it.

          People

          • Assignee:
            Bill Au
            Reporter:
            Tomislav Nakic-Alfirevic
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development