Solr
  1. Solr
  2. SOLR-4798

shard splitting does not respect router (docs with a compositeId may not go to correct shard)

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 4.3
        • Fix Version/s: 4.3.1
        • Component/s: SolrCloud
        • Labels:
          None

          Description

          Lowest level shard splitting code needs to somehow use the router for the collection.

          1. Text File
            SOLR-4798.patch
            9 kB
            Yonik Seeley

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Shalin Shekhar Mangar added a comment -

            I created SOLR-4797 for the same problem.

            Show
            Shalin Shekhar Mangar added a comment - I created SOLR-4797 for the same problem.
            Hide
            Permalink
            Yonik Seeley added a comment -

            Actually, it's related but different.
            This is about the low level index splitting not using the router - hence anything with a "!" will hash incorrectly (using the default compositeId router) and we'll put it in the wrong split.

            Show
            Yonik Seeley added a comment - Actually, it's related but different. This is about the low level index splitting not using the router - hence anything with a "!" will hash incorrectly (using the default compositeId router) and we'll put it in the wrong split.
            Hide
            Permalink
            Yonik Seeley added a comment -

            Draft patch that passes down the router and uses it for hash based routers.

            Show
            Yonik Seeley added a comment - Draft patch that passes down the router and uses it for hash based routers.
            Hide
            Permalink
            Shalin Shekhar Mangar added a comment -

            Thanks Yonik. I changed the ShardSplitTest to add some docs with composite ids as part of SOLR-4797 so I'm marking this issue as fixed.

            Show
            Shalin Shekhar Mangar added a comment - Thanks Yonik. I changed the ShardSplitTest to add some docs with composite ids as part of SOLR-4797 so I'm marking this issue as fixed.
            Hide
            Permalink
            Commit Tag Bot added a comment -

            [lucene_solr_4_3 commit] shalin
            http://svn.apache.org/viewvc?view=revision&revision=1480897

            SOLR-4798: use correct router during index splitting

            Show
            Commit Tag Bot added a comment - [lucene_solr_4_3 commit] shalin http://svn.apache.org/viewvc?view=revision&revision=1480897 SOLR-4798 : use correct router during index splitting
            Hide
            Permalink
            Shalin Shekhar Mangar added a comment -

            Bulk close after 4.3.1 release

            Show
            Shalin Shekhar Mangar added a comment - Bulk close after 4.3.1 release

              People

              • Assignee:
                Yonik Seeley
                Reporter:
                Yonik Seeley
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development