Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4745

Do not pass a SolrCore in ZkController.preRegister()

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.4
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      The shard splitting feature changed the method definition of ZkController#preRegister to accept a SolrCore instead of CoreDescriptor.

      From the comments in SOLR-3755:

      Set update log to buffering mode before it is published (fixes bug with extra doc count on sub-shard)

      Regarding those changes - I'd really like to find another way to do that. The original change around this made preRegister start taking a core rather than a core descriptor. I'd like to work that out so it doesn't need to be the case. That is where the core will find out some of it's properties (shard id, core node name, perhaps more in the future). It would be nice if the core init code had access to this information - so it would be nice if we could call preRegister (or some refactored version) before actually creating the SolrCore.

        Attachments

        1. SOLR-4745.patch
          3 kB
          Mark Miller

          Issue Links

            Activity

              People

              • Assignee:
                markrmiller@gmail.com Mark Miller
                Reporter:
                shalin Shalin Shekhar Mangar
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: