Solr
  1. Solr
  2. SOLR-4708

Enable ClusteringComponent by default

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      In the past, the ClusteringComponent used to rely on 3rd party JARs not available from a Solr distro. This is no longer the case, but the /browse UI and other references still had the clustering component disabled in the example with an awkward system property way to enable it. Let's remove all of that unnecessary stuff and just enable it as it works out of the box now.

      1. SOLR-4708.patch
        10 kB
        Erik Hatcher
      2. SOLR-4708.patch
        5 kB
        Erik Hatcher

        Activity

        Hide
        Dawid Weiss added a comment -

        +1 from me

        Show
        Dawid Weiss added a comment - +1 from me
        Hide
        Erik Hatcher added a comment -

        this patch enables it and removes the mention/use of the system property that previously enabled it.

        running tests now, will then add a CHANGES entry and commit shortly.

        Show
        Erik Hatcher added a comment - this patch enables it and removes the mention/use of the system property that previously enabled it. running tests now, will then add a CHANGES entry and commit shortly.
        Hide
        Yonik Seeley added a comment -

        +1, provided that everything (except clustering) still works if you copy "example" somewhere else.

        Show
        Yonik Seeley added a comment - +1, provided that everything (except clustering) still works if you copy "example" somewhere else.
        Hide
        Erik Hatcher added a comment -

        ... provided that everything (except clustering) still works if you copy "example" somewhere else.

        Hmm, I guess that's the kicker. The uima tests that have the clustering component defined (but disabled by default) fail when this is automatically enabled, so. "copying example" should also imply including all the contrib's that are depended upon (even if lazily), but we know that's not how folks do it. Well, ok, I defer this to another day after the example + contribs situation is made better (having a solr.install.dir reference for the contrib libs would do it, I think, IMO).

        Show
        Erik Hatcher added a comment - ... provided that everything (except clustering) still works if you copy "example" somewhere else. Hmm, I guess that's the kicker. The uima tests that have the clustering component defined (but disabled by default) fail when this is automatically enabled, so. "copying example" should also imply including all the contrib's that are depended upon (even if lazily), but we know that's not how folks do it. Well, ok, I defer this to another day after the example + contribs situation is made better (having a solr.install.dir reference for the contrib libs would do it, I think, IMO).
        Hide
        Erik Hatcher added a comment -

        this patch removes the clustering component references from the two UIMA test solrconfig's since they are needed for testing anything.

        Show
        Erik Hatcher added a comment - this patch removes the clustering component references from the two UIMA test solrconfig's since they are needed for testing anything.
        Hide
        Dawid Weiss added a comment -

        The patch looks good to me. Thanks Erik.

        Show
        Dawid Weiss added a comment - The patch looks good to me. Thanks Erik.
        Hide
        ASF subversion and git services added a comment -

        Commit 1512226 from Dawid Weiss in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1512226 ]

        SOLR-4708: Enable ClusteringComponent by default in collection1 example.
        The solr.clustering.enabled system property is set to 'true' by default.

        Show
        ASF subversion and git services added a comment - Commit 1512226 from Dawid Weiss in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1512226 ] SOLR-4708 : Enable ClusteringComponent by default in collection1 example. The solr.clustering.enabled system property is set to 'true' by default.
        Hide
        ASF subversion and git services added a comment -

        Commit 1512227 from Dawid Weiss in branch 'dev/trunk'
        [ https://svn.apache.org/r1512227 ]

        SOLR-4708: Enable ClusteringComponent by default in collection1 example.
        The solr.clustering.enabled system property is set to 'true' by default.

        Show
        ASF subversion and git services added a comment - Commit 1512227 from Dawid Weiss in branch 'dev/trunk' [ https://svn.apache.org/r1512227 ] SOLR-4708 : Enable ClusteringComponent by default in collection1 example. The solr.clustering.enabled system property is set to 'true' by default.
        Hide
        Dawid Weiss added a comment -

        Thanks for providing the patch, Erik. I pretty much applied it as-is; the only change being that I left the enabled="" attributes, but defaulted them to true (so that if somebody wants to, he or she can disable the clustering component from command-line).

        Show
        Dawid Weiss added a comment - Thanks for providing the patch, Erik. I pretty much applied it as-is; the only change being that I left the enabled="" attributes, but defaulted them to true (so that if somebody wants to, he or she can disable the clustering component from command-line).
        Hide
        ASF subversion and git services added a comment -

        Commit 1512276 from Dawid Weiss in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1512276 ]

        SOLR-4708: a follow-up commit that disables the clustering componeny in tests. This is needed because core tests are executed before the contribs are compiled so certain classes are not yet available (unless you already have them locally). An alternative would be to compile everything before any tests are executed, but it seems that it'd add an extra unnecessary overhead to every build.

        Show
        ASF subversion and git services added a comment - Commit 1512276 from Dawid Weiss in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1512276 ] SOLR-4708 : a follow-up commit that disables the clustering componeny in tests. This is needed because core tests are executed before the contribs are compiled so certain classes are not yet available (unless you already have them locally). An alternative would be to compile everything before any tests are executed, but it seems that it'd add an extra unnecessary overhead to every build.
        Hide
        ASF subversion and git services added a comment -

        Commit 1512278 from Dawid Weiss in branch 'dev/trunk'
        [ https://svn.apache.org/r1512278 ]

        SOLR-4708: a follow-up commit that disables the clustering component in tests. This is needed because core tests are executed before the contribs are compiled so certain classes are not yet available (unless you already have them locally). An alternative would be to compile everything before any tests are executed, but it seems that it'd add an extra unnecessary overhead to every build.

        Show
        ASF subversion and git services added a comment - Commit 1512278 from Dawid Weiss in branch 'dev/trunk' [ https://svn.apache.org/r1512278 ] SOLR-4708 : a follow-up commit that disables the clustering component in tests. This is needed because core tests are executed before the contribs are compiled so certain classes are not yet available (unless you already have them locally). An alternative would be to compile everything before any tests are executed, but it seems that it'd add an extra unnecessary overhead to every build.
        Hide
        ASF subversion and git services added a comment -

        Commit 1512321 from Dawid Weiss in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1512321 ]

        SOLR-4708: one more follow-up to a class that didn't extend from the base Solr test class.

        Show
        ASF subversion and git services added a comment - Commit 1512321 from Dawid Weiss in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1512321 ] SOLR-4708 : one more follow-up to a class that didn't extend from the base Solr test class.
        Hide
        ASF subversion and git services added a comment -

        Commit 1512322 from Dawid Weiss in branch 'dev/trunk'
        [ https://svn.apache.org/r1512322 ]

        SOLR-4708: one more follow-up to a class that didn't extend from the base Solr test class.

        Show
        ASF subversion and git services added a comment - Commit 1512322 from Dawid Weiss in branch 'dev/trunk' [ https://svn.apache.org/r1512322 ] SOLR-4708 : one more follow-up to a class that didn't extend from the base Solr test class.
        Hide
        Adrien Grand added a comment -

        4.5 release -> bulk close

        Show
        Adrien Grand added a comment - 4.5 release -> bulk close
        Hide
        ASF subversion and git services added a comment -

        Commit 1531377 from Dawid Weiss in branch 'dev/trunk'
        [ https://svn.apache.org/r1531377 ]

        SOLR-5323: Disable ClusteringComponent by default in collection1 example. The solr.clustering.enabled system property needs to be set to 'true' to enable the clustering contrib (reverts SOLR-4708). (Dawid Weiss)

        Show
        ASF subversion and git services added a comment - Commit 1531377 from Dawid Weiss in branch 'dev/trunk' [ https://svn.apache.org/r1531377 ] SOLR-5323 : Disable ClusteringComponent by default in collection1 example. The solr.clustering.enabled system property needs to be set to 'true' to enable the clustering contrib (reverts SOLR-4708 ). (Dawid Weiss)
        Hide
        ASF subversion and git services added a comment -

        Commit 1531378 from Dawid Weiss in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1531378 ]

        SOLR-5323: Disable ClusteringComponent by default in collection1 example. The solr.clustering.enabled system property needs to be set to 'true' to enable the clustering contrib (reverts SOLR-4708). (Dawid Weiss)

        Show
        ASF subversion and git services added a comment - Commit 1531378 from Dawid Weiss in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1531378 ] SOLR-5323 : Disable ClusteringComponent by default in collection1 example. The solr.clustering.enabled system property needs to be set to 'true' to enable the clustering contrib (reverts SOLR-4708 ). (Dawid Weiss)
        Hide
        ASF subversion and git services added a comment -

        Commit 1531380 from Dawid Weiss in branch 'dev/branches/lucene_solr_4_5'
        [ https://svn.apache.org/r1531380 ]

        SOLR-5323: Disable ClusteringComponent by default in collection1 example. The solr.clustering.enabled system property needs to be set to 'true' to enable the clustering contrib (reverts SOLR-4708). (Dawid Weiss)

        Show
        ASF subversion and git services added a comment - Commit 1531380 from Dawid Weiss in branch 'dev/branches/lucene_solr_4_5' [ https://svn.apache.org/r1531380 ] SOLR-5323 : Disable ClusteringComponent by default in collection1 example. The solr.clustering.enabled system property needs to be set to 'true' to enable the clustering contrib (reverts SOLR-4708 ). (Dawid Weiss)

          People

          • Assignee:
            Dawid Weiss
            Reporter:
            Erik Hatcher
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development