Solr
  1. Solr
  2. SOLR-468

CapitalizationFilterFactory keep semantics are inconsistent

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3
    • Component/s: None
    • Labels:
      None

      Description

      The CapitlizationFilterFactory keep semantics are inconsistent in regards to case. Currently, the token being tested is not kept when it is in the keep list, instead, the text in the keep list is returned.

      Also, the keep list should be case-sensitive, or at least allow for ignoring case.

      See http://www.mail-archive.com/solr-dev@lucene.apache.org/msg07285.html

      1. SOLR-468.patch
        13 kB
        Grant Ingersoll

        Activity

        Hide
        Grant Ingersoll added a comment -

        Here's a patch that fixes the problem.

        It also converts it to reuse the Token and to take advantage of the char[] array term buffer, per Lucene 2.3

        Show
        Grant Ingersoll added a comment - Here's a patch that fixes the problem. It also converts it to reuse the Token and to take advantage of the char[] array term buffer, per Lucene 2.3
        Hide
        Grant Ingersoll added a comment -

        Committed revision 630572.

        Show
        Grant Ingersoll added a comment - Committed revision 630572.

          People

          • Assignee:
            Grant Ingersoll
            Reporter:
            Grant Ingersoll
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development