Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-4570

Even if an explicit shard id is used, ZkController#preRegister should still wait to see the shard id in it's current ClusterState.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2.1, 4.3, 6.0
    • Component/s: SolrCloud
    • Labels:
      None

      Issue Links

        Activity

        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        tay, I filed SOLR-10491.

        Show
        markrmiller@gmail.com Mark Miller added a comment - tay , I filed SOLR-10491 .
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        You might want to create a new JIRA if you think something needs to be addressed here.

        I've worked to try and make it so you can still simply manually use a new coreNodeName to have a core replace an existing ZK registration entry, but I'm not sure we are looking to support changing other properties that way and even coreNodeName support may go away (and has in recent releases if using legacyCloud=false - I'm re-allowing it for the current autoAddRepliacs support though). We are really looking to make users hit the API's for all of this.

        Show
        markrmiller@gmail.com Mark Miller added a comment - You might want to create a new JIRA if you think something needs to be addressed here. I've worked to try and make it so you can still simply manually use a new coreNodeName to have a core replace an existing ZK registration entry, but I'm not sure we are looking to support changing other properties that way and even coreNodeName support may go away (and has in recent releases if using legacyCloud=false - I'm re-allowing it for the current autoAddRepliacs support though). We are really looking to make users hit the API's for all of this.
        Hide
        zaytay tay added a comment -

        solr 6.0 version´╝îexplicit shard id in core.properties. but where restart,solr use the shard id from clusterstate .not come from croe.preperties.
        find ZkController#preRegister. allways invoke doGetShardIdAndNodeNameProcess method :

        if (cd.getCloudDescriptor().getShardId() == null && needsToBeAssignedShardId(cd, zkStateReader.getClusterState(), coreNodeName))

        { doGetShardIdAndNodeNameProcess(cd); }

        else

        { // still wait till we see us in local state doGetShardIdAndNodeNameProcess(cd); }

        so explicit shard id is not used

        Show
        zaytay tay added a comment - solr 6.0 version´╝îexplicit shard id in core.properties. but where restart,solr use the shard id from clusterstate .not come from croe.preperties. find ZkController#preRegister. allways invoke doGetShardIdAndNodeNameProcess method : if (cd.getCloudDescriptor().getShardId() == null && needsToBeAssignedShardId(cd, zkStateReader.getClusterState(), coreNodeName)) { doGetShardIdAndNodeNameProcess(cd); } else { // still wait till we see us in local state doGetShardIdAndNodeNameProcess(cd); } so explicit shard id is not used
        Hide
        thetaphi Uwe Schindler added a comment -

        Closed after release.

        Show
        thetaphi Uwe Schindler added a comment - Closed after release.
        Hide
        commit-tag-bot Commit Tag Bot added a comment -

        [trunk commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1458115

        SOLR-4570: Move CHANGES entry.

        Show
        commit-tag-bot Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1458115 SOLR-4570 : Move CHANGES entry.
        Hide
        commit-tag-bot Commit Tag Bot added a comment -

        [branch_4x commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1458116

        SOLR-4570: Move CHANGES entry.

        Show
        commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1458116 SOLR-4570 : Move CHANGES entry.
        Hide
        commit-tag-bot Commit Tag Bot added a comment -

        [branch_4x commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1456732

        SOLR-4570: Even if an explicit shard id is used, ZkController#preRegister should still wait to see the shard id in it's current ClusterState.

        Show
        commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1456732 SOLR-4570 : Even if an explicit shard id is used, ZkController#preRegister should still wait to see the shard id in it's current ClusterState.
        Hide
        commit-tag-bot Commit Tag Bot added a comment -

        [trunk commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1456731

        SOLR-4570: Even if an explicit shard id is used, ZkController#preRegister should still wait to see the shard id in it's current ClusterState.

        Show
        commit-tag-bot Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1456731 SOLR-4570 : Even if an explicit shard id is used, ZkController#preRegister should still wait to see the shard id in it's current ClusterState.

          People

          • Assignee:
            markrmiller@gmail.com Mark Miller
            Reporter:
            markrmiller@gmail.com Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development