Solr
  1. Solr
  2. SOLR-4515

OpenExchangeRatesOrgProvider needs to require a ratesFileLocation

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.2, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      OpenExchangeRatesOrgProvider currently defaults the value of the "ratesFileLocation" init param to "http://openexchangerates.org/latest.json" – but that URL currently 301 redirects to a page with the following information...

      Notice: App ID Required
      As per public notices beginning June 2012, an App ID is required to access the Open Exchange Rates API. It's free for personal use, a bargain for your business. You can sign up here »

      ...so we should update the code to require users to be explicit about their URL (including APP_ID) or point to a local file. As things stand right now, anyone who configures this provider w/o explicitly setting ratesFileLocation ges a clean startup, but anytime they attempt to use the fieldtype to do a conversion they get an error that "No available conversion rate from USD to USD. Available rates are []"

        Activity

        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1451818

        SOLR-4515: CurrencyField's OpenExchangeRatesOrgProvider now requires a ratesFileLocation init param, since the previous global default no longer works

        Show
        Commit Tag Bot added a comment - [trunk commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1451818 SOLR-4515 : CurrencyField's OpenExchangeRatesOrgProvider now requires a ratesFileLocation init param, since the previous global default no longer works
        Hide
        Hoss Man added a comment -

        Committed revision 1451818.
        Committed revision 1451821.

        Show
        Hoss Man added a comment - Committed revision 1451818. Committed revision 1451821.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1451821

        SOLR-4515: CurrencyField's OpenExchangeRatesOrgProvider now requires a ratesFileLocation init param, since the previous global default no longer works (merge r1451818)

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1451821 SOLR-4515 : CurrencyField's OpenExchangeRatesOrgProvider now requires a ratesFileLocation init param, since the previous global default no longer works (merge r1451818)
        Hide
        Commit Tag Bot added a comment -
        Show
        Commit Tag Bot added a comment - [trunk commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1451838 SOLR-4515 : typo
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1451839

        SOLR-4515: typo (merge r1451838)

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1451839 SOLR-4515 : typo (merge r1451838)
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1451842

        SOLR-4515: more typos that documentation-lint aparently didn't catch (merge r1451841)

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1451842 SOLR-4515 : more typos that documentation-lint aparently didn't catch (merge r1451841)
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1451841

        SOLR-4515: more typos that documentation-lint aparently didn't catch

        Show
        Commit Tag Bot added a comment - [trunk commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1451841 SOLR-4515 : more typos that documentation-lint aparently didn't catch
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Hoss Man
            Reporter:
            Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development