Solr
  1. Solr
  2. SOLR-45

enable thresholded field compression for certain field types

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0
    • Component/s: update
    • Labels:
      None

      Description

      Adds a CompressableField abstract base class from which fieldtypes may inherit. Fields of these types may specify compressed="true" in the field definition to turn on compression. The field type takes an optional compressThreshold parameter which will only turn on compression for fields whose internal representations of greater or equal to a given size.

      TextField and StrField inherit from CompressableField

      Comments? (my main issue is that it woudl be nice to be able to set compressThreshold at the field level. Since we can't without modifying fields to accept named parameters, perhaps it would be preferrable to only allow compress=true/false to be set at the fieldtype leve)

        Activity

        Hide
        Hoss Man added a comment -

        This bug was modified as part of a bulk update using the criteria...

        • Marked ("Resolved" or "Closed") and "Fixed"
        • Had no "Fix Version" versions
        • Was listed in the CHANGES.txt for 1.1

        The Fix Version for all 38 issues found was set to 1.1, email notification
        was suppressed to prevent excessive email.

        For a list of all the issues modified, search jira comments for this
        (hopefully) unique string: 20080415hossman3

        Show
        Hoss Man added a comment - This bug was modified as part of a bulk update using the criteria... Marked ("Resolved" or "Closed") and "Fixed" Had no "Fix Version" versions Was listed in the CHANGES.txt for 1.1 The Fix Version for all 38 issues found was set to 1.1, email notification was suppressed to prevent excessive email. For a list of all the issues modified, search jira comments for this (hopefully) unique string: 20080415hossman3
        Hide
        Mike Klaas added a comment -

        Commited slightly modified patch in r440837

        Show
        Mike Klaas added a comment - Commited slightly modified patch in r440837
        Hide
        Yonik Seeley added a comment -

        Looks good. I'd leave things as you have them.
        I think allowing compressTheshold at the fieldtype level is better than not allowing it at all.

        If I could re-do Solr, I think I would try to eliminate fieldtype alltogether and substitute it with field inheritance.

        Show
        Yonik Seeley added a comment - Looks good. I'd leave things as you have them. I think allowing compressTheshold at the fieldtype level is better than not allowing it at all. If I could re-do Solr, I think I would try to eliminate fieldtype alltogether and substitute it with field inheritance.

          People

          • Assignee:
            Mike Klaas
            Reporter:
            Mike Klaas
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development