Solr
  1. Solr
  2. SOLR-4400

Rapidly opening and closing cores can lead to deadlock

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.1
    • Fix Version/s: 4.2, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      See the discussion at SOLR-4196. Under ridiculous loads (i.e. every request causes a core to close and another one to open) Solr can lock up. This is only a problem if you are using transient cores (see SOLR-1028) with a limited cache size. Simply lazily loading cores that are NOT transient shouldn't have this problem, you need to be closing cores to get here.

      1. 4x_stack.txt
        153 kB
        Erick Erickson
      2. SOLR-4400.patch
        4 kB
        Mark Miller

        Issue Links

          Activity

          Hide
          Erick Erickson added a comment -

          Attaching jstack output for a fresh (3-Feb) run against 4x, on a very quick look it has the same issue, so I think we can be confident that the same fix needs to go in both places. Won't have time to look at this in detail until later today.

          Show
          Erick Erickson added a comment - Attaching jstack output for a fresh (3-Feb) run against 4x, on a very quick look it has the same issue, so I think we can be confident that the same fix needs to go in both places. Won't have time to look at this in detail until later today.
          Hide
          Mark Miller added a comment -

          Yup, the attached is the commit lock issue.

          Show
          Mark Miller added a comment - Yup, the attached is the commit lock issue.
          Hide
          Mark Miller added a comment -

          Here is how I would like to address this specific deadlock case.

          Show
          Mark Miller added a comment - Here is how I would like to address this specific deadlock case.
          Hide
          Commit Tag Bot added a comment -

          [trunk commit] Mark Robert Miller
          http://svn.apache.org/viewvc?view=revision&revision=1444152

          SOLR-4400: Deadlock can occur in a rare race between committing and closing a SolrIndexWriter.

          Show
          Commit Tag Bot added a comment - [trunk commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1444152 SOLR-4400 : Deadlock can occur in a rare race between committing and closing a SolrIndexWriter.
          Hide
          Mark Miller added a comment -

          Thanks Erick! If you see this same deadlock again, please reopen. If you see a different deadlock case, let's open a new issue for it.

          Show
          Mark Miller added a comment - Thanks Erick! If you see this same deadlock again, please reopen. If you see a different deadlock case, let's open a new issue for it.
          Hide
          Commit Tag Bot added a comment -

          [branch_4x commit] Mark Robert Miller
          http://svn.apache.org/viewvc?view=revision&revision=1444155

          SOLR-4400: Deadlock can occur in a rare race between committing and closing a SolrIndexWriter.

          Show
          Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1444155 SOLR-4400 : Deadlock can occur in a rare race between committing and closing a SolrIndexWriter.
          Hide
          Uwe Schindler added a comment -

          Closed after release.

          Show
          Uwe Schindler added a comment - Closed after release.

            People

            • Assignee:
              Mark Miller
              Reporter:
              Erick Erickson
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development