[SOLR-4327] SolrJ code review indicates potential for leaked HttpClient connections

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0
• Fix Version/s: 4.5.1, 4.6, 6.0
• Assignee: Mark Miller
• Reporter: Karl Wright
• Created: 20/Jan/13 14:53
• Updated: 09/May/16 18:44
• Resolved: 13/Oct/13 00:40

Description

The SolrJ HttpSolrServer implementation does not seem to handle errors properly and seems capable of leaking HttpClient connections. See the request() method in org.apache.solr.client.solrj.impl.HttpSolrServer. The issue is that exceptions thrown from within this method do not necessarily consume the stream when an exception is thrown. There is a try/finally block which reads (in part):

    } finally {
      if (respBody != null && processor!=null) {
        try {
          respBody.close();
        } catch (Throwable t) {} // ignore
      }
    }

But, in order to always guarantee consumption of the stream, it should include:

method.abort();

Issue Links

• is related to: SOLR-8451 We should not call method.abort in HttpSolrClient and HttpSolrCall#remoteQuery should not close streams.