Solr
  1. Solr
  2. SOLR-4225

Term info page under schema browser shows incorrect count of terms

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.2, 5.0
    • Component/s: web gui
    • Labels:
      None
    • Environment:

      chrome (version: Version 22.0.1229.94 m) on a windows 2003 machine

      Description

      The box sizes on the term info page (under Schema Browser), overlaps, due to which the number of terms shown look incorrect. Screenshot attached (TermInfo.png).

      1. luke-terms-elyograg.txt
        4 kB
        Shawn Heisey
      2. schema-browser_histogram.png
        54 kB
        Stefan Matheis (steffkes)
      3. schema-browser_histogram.png
        54 kB
        Stefan Matheis (steffkes)
      4. schemabrowser-termcount-problem.png
        140 kB
        Shawn Heisey
      5. SOLR-4225.patch
        134 kB
        Stefan Matheis (steffkes)
      6. TermInfo.png
        14 kB
        Shreejay

        Issue Links

          Activity

          Hide
          Shreejay added a comment - - edited

          The first box when highlighted shows the correct number. But due to the box not resizing the rest of the counts are wrong.

          Show
          Shreejay added a comment - - edited The first box when highlighted shows the correct number. But due to the box not resizing the rest of the counts are wrong.
          Hide
          Shawn Heisey added a comment -

          Still a problem as of branch_4x checked out yesterday. Screenshot attached.

          solr-impl 4.1-SNAPSHOT 1429996 - ncindex - 2013-01-07 14:09:58

          Show
          Shawn Heisey added a comment - Still a problem as of branch_4x checked out yesterday. Screenshot attached. solr-impl 4.1-SNAPSHOT 1429996 - ncindex - 2013-01-07 14:09:58
          Hide
          Stefan Matheis (steffkes) added a comment -

          Shawn Heisey would you mind attaching the output of /solr/inclive/admin/luke?wt=json&fl=catchall ? that would be very helpful to get some realworld-data. perhaps we should also change the display of the histogram, because that doesn't like pretty good as well?

          Show
          Stefan Matheis (steffkes) added a comment - Shawn Heisey would you mind attaching the output of /solr/inclive/admin/luke?wt=json&fl=catchall ? that would be very helpful to get some realworld-data. perhaps we should also change the display of the histogram, because that doesn't like pretty good as well?
          Hide
          Shawn Heisey added a comment -

          Here's the luke output you requested. This is actually two complete responses - one for the inclive that you requested, and another for one of the large shards - s0live.

          Show
          Shawn Heisey added a comment - Here's the luke output you requested. This is actually two complete responses - one for the inclive that you requested, and another for one of the large shards - s0live.
          Hide
          Stefan Matheis (steffkes) added a comment - - edited

          Attached Screenshot (schema-browser_histogram.png) shows how the new Histograms will look like, using Data from Shawn (the two on top) as well as exampedocs (the two at the bottom)

          Thoughts on this?

          Show
          Stefan Matheis (steffkes) added a comment - - edited Attached Screenshot (schema-browser_histogram.png) shows how the new Histograms will look like, using Data from Shawn (the two on top) as well as exampedocs (the two at the bottom) Thoughts on this?
          Hide
          Hoss Man added a comment -

          +1 ... nice.

          Why are the numbers formated as 8'388'608 instead of 8,388,608 or the more SI recomended 8 388 608? is "\'" a locale based convention i'm not aware of?

          Show
          Hoss Man added a comment - +1 ... nice. Why are the numbers formated as 8'388'608 instead of 8,388,608 or the more SI recomended 8 388 608 ? is "\'" a locale based convention i'm not aware of?
          Hide
          Stefan Matheis (steffkes) added a comment - - edited

          Why are the numbers formated as 8'388'608 instead of 8,388,608 or the more SI recomended 8 388 608? is "\'" a locale based convention i'm not aware of?

          Uhm, that's a good question oO That's the same formatting rule i used for the DIH-Interface, grabbed a short Javascript-Snippet from StackOverflow which included this apostrophe.

          If we change the formatting-character, i'd like to use the , instead of the whitespace - because the whitespace only "works well" if you use mono-space formatting (as you did in your comment), otherwise the space between the digits is so small, that it does not really help while scanning the whole number.

          1. edit

          hmm, maybe .. looks, like it's the swiss formatting rule, but i didn't realize that

          Show
          Stefan Matheis (steffkes) added a comment - - edited Why are the numbers formated as 8'388'608 instead of 8,388,608 or the more SI recomended 8 388 608 ? is "\'" a locale based convention i'm not aware of? Uhm, that's a good question oO That's the same formatting rule i used for the DIH-Interface, grabbed a short Javascript-Snippet from StackOverflow which included this apostrophe. If we change the formatting-character, i'd like to use the , instead of the whitespace - because the whitespace only "works well" if you use mono-space formatting (as you did in your comment), otherwise the space between the digits is so small, that it does not really help while scanning the whole number. edit hmm, maybe .. looks, like it's the swiss formatting rule, but i didn't realize that
          Hide
          Stefan Matheis (steffkes) added a comment -

          Instead of "maybe" .. have a look at your own .. the two samples on top are updated .. the first using whitespace and the second using comma as separator - let me know which one

          Show
          Stefan Matheis (steffkes) added a comment - Instead of "maybe" .. have a look at your own .. the two samples on top are updated .. the first using whitespace and the second using comma as separator - let me know which one
          Hide
          Hoss Man added a comment -

          Well, 16 years of education at US schools has biased me in favor of using comma as the thousand separator – but i appreciate that people smarter then me clam whitespace separation is less confusing when communicating with people from other cultures that have diff conventions. (although i appreciate your point about it mainly being useful in fixed width fonts)

          truthfully i don't really care what we use: i was just surprised by the apostrophes since that's not a convention i'd ever seen before in any locale.

          Show
          Hoss Man added a comment - Well, 16 years of education at US schools has biased me in favor of using comma as the thousand separator – but i appreciate that people smarter then me clam whitespace separation is less confusing when communicating with people from other cultures that have diff conventions. (although i appreciate your point about it mainly being useful in fixed width fonts) truthfully i don't really care what we use: i was just surprised by the apostrophes since that's not a convention i'd ever seen before in any locale.
          Hide
          Commit Tag Bot added a comment -

          [trunk commit] Stefan Matheis
          http://svn.apache.org/viewvc?view=revision&revision=1438900

          SOLR-4225: Term info page under schema browser shows incorrect count of terms

          Show
          Commit Tag Bot added a comment - [trunk commit] Stefan Matheis http://svn.apache.org/viewvc?view=revision&revision=1438900 SOLR-4225 : Term info page under schema browser shows incorrect count of terms
          Hide
          Commit Tag Bot added a comment -

          [branch_4x commit] Stefan Matheis
          http://svn.apache.org/viewvc?view=revision&revision=1438901

          SOLR-4225: Term info page under schema browser shows incorrect count of terms (merge r1438900)

          Show
          Commit Tag Bot added a comment - [branch_4x commit] Stefan Matheis http://svn.apache.org/viewvc?view=revision&revision=1438901 SOLR-4225 : Term info page under schema browser shows incorrect count of terms (merge r1438900)
          Hide
          Commit Tag Bot added a comment -

          [trunk commit] Stefan Matheis
          http://svn.apache.org/viewvc?view=revision&revision=1439368

          SOLR-4225: Admin UI - Schema-Browser, Histogram shouldn't break on whitespaces

          Show
          Commit Tag Bot added a comment - [trunk commit] Stefan Matheis http://svn.apache.org/viewvc?view=revision&revision=1439368 SOLR-4225 : Admin UI - Schema-Browser, Histogram shouldn't break on whitespaces
          Hide
          Commit Tag Bot added a comment -

          [branch_4x commit] Stefan Matheis
          http://svn.apache.org/viewvc?view=revision&revision=1439369

          SOLR-4225: Admin UI - Schema-Browser, Histogram shouldn't break on whitespaces (merge r1439368)

          Show
          Commit Tag Bot added a comment - [branch_4x commit] Stefan Matheis http://svn.apache.org/viewvc?view=revision&revision=1439369 SOLR-4225 : Admin UI - Schema-Browser, Histogram shouldn't break on whitespaces (merge r1439368)
          Hide
          Uwe Schindler added a comment -

          Closed after release.

          Show
          Uwe Schindler added a comment - Closed after release.

            People

            • Assignee:
              Stefan Matheis (steffkes)
              Reporter:
              Shreejay
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development