[SOLR-4189] Fix hanging threads on FreeBSD in JettySolrRunner by making connector configureable through sysprop

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.1, 6.0
• Component/s: Tests
• Assignee: Uwe Schindler
• Reporter: Uwe Schindler
• Created: 14/Dec/12 17:43
• Updated: 09/May/16 18:43
• Resolved: 14/Dec/12 22:22

Description

Currently on FreeBSD we run no Solr tests, because the SelectChannelConnector, recently used for Solr's JettySolrRunner seems to linger threads, which may be caused by the blackhole or more likely a JVM bug.

This patch allows to configure the connector for the testMode Jetty in embedded Solr through a sysprop:

ant test -Dtests.jettyConnector=Socket
ant test -Dtests.jettyConnector=SelectChannel

The default is SelectChannel. On FreeBSD Jenkins I would pass this as property to ANT through Jenkins config (where currently the tests are disabled). On Maven this should also be possible (Steven?).

The patch also binds the test-mode jetty to 127.0.0.1 to prevent windows firewall from popping up all the time, because Solr binds to internet. For tests, the emebedded Jetty should never run on all interfaces (0.0.0.0).