Solr
  1. Solr
  2. SOLR-3970

Admin dashboard shows incomplete java version

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.1, 6.0
    • Component/s: web gui
    • Labels:
      None
    • Environment:

      Description

      The admin dashboard shows the following for "Runtime" under "JVM" but it is incomplete. Unless you are intimately familiar with the correlation between HotSpot version numbers and Java version numbers, you can't look at this and know what version of Oracle Java is being used.

      Java HotSpot(TM) 64-Bit Server VM (23.3-b01)

      The complete version output (from java -version) on this system is this:

      java version "1.7.0_07"
      Java(TM) SE Runtime Environment (build 1.7.0_07-b10)
      Java HotSpot(TM) 64-Bit Server VM (build 23.3-b01, mixed mode)

        Activity

        Hide
        Stefan Matheis (steffkes) added a comment -

        Shawn, nothing easier than this: solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java on Line 214:

        jvm.add( "version", System.getProperty("java.vm.version") );

        but i don't know what makes more sense to show as information at the dashboard?

        Show
        Stefan Matheis (steffkes) added a comment - Shawn, nothing easier than this: solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java on Line 214: jvm.add( "version" , System .getProperty( "java.vm.version" ) ); but i don't know what makes more sense to show as information at the dashboard?
        Hide
        Hoss Man added a comment -

        We can't garuntee that we can return the exact info available from "java -version" (example: on my system that includes info about the ubuntu packaging of the JVM which isn't available from any sysproperty at run time ... that i know of) but the choice of using "java.vm.version" here seems like a long long overlooked mistake.

        this patch leaves the current "name" and "version" output keys in place (for backcompat and the admin UI) but includes more info in their string values, as well as adding sub-maps with more specific values that corrispond one to one with the sys props for the jre version, vm version, and java spec version.

        Show
        Hoss Man added a comment - We can't garuntee that we can return the exact info available from "java -version" (example: on my system that includes info about the ubuntu packaging of the JVM which isn't available from any sysproperty at run time ... that i know of) but the choice of using "java.vm.version" here seems like a long long overlooked mistake. this patch leaves the current "name" and "version" output keys in place (for backcompat and the admin UI) but includes more info in their string values, as well as adding sub-maps with more specific values that corrispond one to one with the sys props for the jre version, vm version, and java spec version.
        Hide
        Commit Tag Bot added a comment -

        [trunk commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1411495

        SOLR-3970: SystemInfoHandler now exposes more details about the JRE/VM/Java version in use

        Show
        Commit Tag Bot added a comment - [trunk commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1411495 SOLR-3970 : SystemInfoHandler now exposes more details about the JRE/VM/Java version in use
        Hide
        Hoss Man added a comment -

        Committed revision 1411495. - trunk
        Committed revision 1411497. - 4x

        Show
        Hoss Man added a comment - Committed revision 1411495. - trunk Committed revision 1411497. - 4x
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1411497

        SOLR-3970: SystemInfoHandler now exposes more details about the JRE/VM/Java version in use (merge r1411495)

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1411497 SOLR-3970 : SystemInfoHandler now exposes more details about the JRE/VM/Java version in use (merge r1411495)
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Chris M. Hostetter
        http://svn.apache.org/viewvc?view=revision&revision=1411497

        SOLR-3970: SystemInfoHandler now exposes more details about the JRE/VM/Java version in use (merge r1411495)

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Chris M. Hostetter http://svn.apache.org/viewvc?view=revision&revision=1411497 SOLR-3970 : SystemInfoHandler now exposes more details about the JRE/VM/Java version in use (merge r1411495)

          People

          • Assignee:
            Hoss Man
            Reporter:
            Shawn Heisey
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development