Solr
  1. Solr
  2. SOLR-3938

prepareCommit command omits commitData

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.1
    • Component/s: None
    • Labels:

      Description

      Solr's prepareCommit doesn't set any commitData, and then when a commit is done, it's too late.

      1. SOLR-3938.patch
        0.8 kB
        Yonik Seeley
      2. SOLR-3938-unit.patch
        8 kB
        Lance Norskog

        Activity

        Hide
        Yonik Seeley added a comment -

        Here's a simple patch that adds the commit data during the prepareCommit command.

        Show
        Yonik Seeley added a comment - Here's a simple patch that adds the commit data during the prepareCommit command.
        Hide
        Yonik Seeley added a comment -

        committed to 4x / trunk

        Show
        Yonik Seeley added a comment - committed to 4x / trunk
        Hide
        Lance Norskog added a comment -

        Add unit test to TestReplicationHandler. This requires solrj support for prepareCommit, and thus includes that.

        Show
        Lance Norskog added a comment - Add unit test to TestReplicationHandler. This requires solrj support for prepareCommit, and thus includes that.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Yonik Seeley
        http://svn.apache.org/viewvc?view=revision&revision=1402374

        SOLR-3938: prepareCommit command omits commitData

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Yonik Seeley http://svn.apache.org/viewvc?view=revision&revision=1402374 SOLR-3938 : prepareCommit command omits commitData

          People

          • Assignee:
            Unassigned
            Reporter:
            Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development