Solr
  1. Solr
  2. SOLR-3892

Inconsistent locking when accessing cache in CachingDirectoryFactory

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0-BETA
    • Fix Version/s: 4.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      CDF is locking on "this" while RAMDirectoryFactory and MockDirectoryFactory are locking on "DirectoryFactory.class".

      1. SOLR-3892.patch
        1 kB
        Patrick Hunt

        Activity

        Hide
        Patrick Hunt added a comment -

        Fixed the two locations I found with inconsistent locking. I couldn't think of a new test to add to verify this, however all existing solr tests passed.

        Show
        Patrick Hunt added a comment - Fixed the two locations I found with inconsistent locking. I couldn't think of a new test to add to verify this, however all existing solr tests passed.
        Hide
        Mark Miller added a comment -

        MockDir is for tests and RAMDirFactory has always been a little bit of a red headed step child - but both are pretty insidious bugs in the wrong situation.

        I'll take care of this.

        Show
        Mark Miller added a comment - MockDir is for tests and RAMDirFactory has always been a little bit of a red headed step child - but both are pretty insidious bugs in the wrong situation. I'll take care of this.
        Hide
        Mark Miller added a comment -

        Thanks Patrick!

        Show
        Mark Miller added a comment - Thanks Patrick!
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1390208

        SOLR-3892: Inconsistent locking when accessing cache in CachingDirectoryFactory from RAMDirectoryFactory and MockDirectoryFactory.

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1390208 SOLR-3892 : Inconsistent locking when accessing cache in CachingDirectoryFactory from RAMDirectoryFactory and MockDirectoryFactory.
        Hide
        Commit Tag Bot added a comment -

        [branch_4x commit] Mark Robert Miller
        http://svn.apache.org/viewvc?view=revision&revision=1390208

        SOLR-3892: Inconsistent locking when accessing cache in CachingDirectoryFactory from RAMDirectoryFactory and MockDirectoryFactory.

        Show
        Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1390208 SOLR-3892 : Inconsistent locking when accessing cache in CachingDirectoryFactory from RAMDirectoryFactory and MockDirectoryFactory.
        Hide
        Uwe Schindler added a comment -

        Closed after release.

        Show
        Uwe Schindler added a comment - Closed after release.

          People

          • Assignee:
            Mark Miller
            Reporter:
            Patrick Hunt
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development