Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-3892

Inconsistent locking when accessing cache in CachingDirectoryFactory

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 4.0-BETA
        • Fix Version/s: 4.0, 6.0
        • Component/s: None
        • Labels:
          None

          Description

          CDF is locking on "this" while RAMDirectoryFactory and MockDirectoryFactory are locking on "DirectoryFactory.class".

          1. Text File
            SOLR-3892.patch
            1 kB
            Patrick Hunt

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            phunt Patrick Hunt added a comment -

            Fixed the two locations I found with inconsistent locking. I couldn't think of a new test to add to verify this, however all existing solr tests passed.

            Show
            phunt Patrick Hunt added a comment - Fixed the two locations I found with inconsistent locking. I couldn't think of a new test to add to verify this, however all existing solr tests passed.
            Hide
            Permalink
            markrmiller@gmail.com Mark Miller added a comment -

            MockDir is for tests and RAMDirFactory has always been a little bit of a red headed step child - but both are pretty insidious bugs in the wrong situation.

            I'll take care of this.

            Show
            markrmiller@gmail.com Mark Miller added a comment - MockDir is for tests and RAMDirFactory has always been a little bit of a red headed step child - but both are pretty insidious bugs in the wrong situation. I'll take care of this.
            Hide
            Permalink
            markrmiller@gmail.com Mark Miller added a comment -

            Thanks Patrick!

            Show
            markrmiller@gmail.com Mark Miller added a comment - Thanks Patrick!
            Hide
            Permalink
            commit-tag-bot Commit Tag Bot added a comment -

            [branch_4x commit] Mark Robert Miller
            http://svn.apache.org/viewvc?view=revision&revision=1390208

            SOLR-3892: Inconsistent locking when accessing cache in CachingDirectoryFactory from RAMDirectoryFactory and MockDirectoryFactory.

            Show
            commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1390208 SOLR-3892 : Inconsistent locking when accessing cache in CachingDirectoryFactory from RAMDirectoryFactory and MockDirectoryFactory.
            Hide
            Permalink
            commit-tag-bot Commit Tag Bot added a comment -

            [branch_4x commit] Mark Robert Miller
            http://svn.apache.org/viewvc?view=revision&revision=1390208

            SOLR-3892: Inconsistent locking when accessing cache in CachingDirectoryFactory from RAMDirectoryFactory and MockDirectoryFactory.

            Show
            commit-tag-bot Commit Tag Bot added a comment - [branch_4x commit] Mark Robert Miller http://svn.apache.org/viewvc?view=revision&revision=1390208 SOLR-3892 : Inconsistent locking when accessing cache in CachingDirectoryFactory from RAMDirectoryFactory and MockDirectoryFactory.
            Hide
            Permalink
            thetaphi Uwe Schindler added a comment -

            Closed after release.

            Show
            thetaphi Uwe Schindler added a comment - Closed after release.

              People

              • Assignee:
                markrmiller@gmail.com Mark Miller
                Reporter:
                phunt Patrick Hunt
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development