Solr
  1. Solr
  2. SOLR-3614

XML parsing in XPathEntityProcessor doesn't respect ENTITY declarations?

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.6, 4.0-BETA
    • Fix Version/s: 4.1, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      As reported by Michael Belenki on solr-user, pointing XPathEntityProcessor at XML files that use DTD "ENTITY" declarations causes XML parse errors of the form...

      org.apache.solr.handler.dataimport.DataImportHandlerException: Parsing failed for xml, url:testdata.xml rows processed:0
      ...
      Caused by: java.lang.RuntimeException: com.ctc.wstx.exc.WstxParsingException: Undeclared general entity "uuml"
      ...
      

      ...even when the entity is specifically declared.

        Issue Links

          Activity

          Hide
          Hoss Man added a comment -

          trivial test patch demonstrating the error.

          Show
          Hoss Man added a comment - trivial test patch demonstrating the error.
          Hide
          Thomas Beckers added a comment -

          I guess this behaviour was introduced with a "fix" for SOLR-964.

          Show
          Thomas Beckers added a comment - I guess this behaviour was introduced with a "fix" for SOLR-964 .
          Hide
          Hoss Man added a comment -

          SOLR-3895 adds an "EmptyEntityResolver" that XPathEntityProcessor might be able to use that might help with this.

          Show
          Hoss Man added a comment - SOLR-3895 adds an "EmptyEntityResolver" that XPathEntityProcessor might be able to use that might help with this.
          Hide
          Uwe Schindler added a comment -

          This will help! I think we should use this also for DIH!

          Show
          Uwe Schindler added a comment - This will help! I think we should use this also for DIH!
          Hide
          Uwe Schindler added a comment -

          This issue will be solved by SOLR-3895

          Show
          Uwe Schindler added a comment - This issue will be solved by SOLR-3895
          Hide
          Uwe Schindler added a comment -

          Committed trunk revision: 1390921
          Committed 4.x revision: 1390924

          Show
          Uwe Schindler added a comment - Committed trunk revision: 1390921 Committed 4.x revision: 1390924
          Hide
          Commit Tag Bot added a comment -

          [branch_4x commit] Uwe Schindler
          http://svn.apache.org/viewvc?view=revision&revision=1390999

          Merged revision(s) 1390991 from lucene/dev/trunk:
          SOLR-3895, SOLR-3614: Fix javadocs

          Show
          Commit Tag Bot added a comment - [branch_4x commit] Uwe Schindler http://svn.apache.org/viewvc?view=revision&revision=1390999 Merged revision(s) 1390991 from lucene/dev/trunk: SOLR-3895 , SOLR-3614 : Fix javadocs
          Hide
          Commit Tag Bot added a comment -

          [branch_4x commit] Uwe Schindler
          http://svn.apache.org/viewvc?view=revision&revision=1390924

          Merged revision(s) 1390921 from lucene/dev/trunk:
          SOLR-3895, SOLR-3614: XML and XSLT UpdateRequestHandler should not try to resolve external entities; fix XML parsing in XPathEntityProcessor to correctly expand named entities, but ignore external entities

          Show
          Commit Tag Bot added a comment - [branch_4x commit] Uwe Schindler http://svn.apache.org/viewvc?view=revision&revision=1390924 Merged revision(s) 1390921 from lucene/dev/trunk: SOLR-3895 , SOLR-3614 : XML and XSLT UpdateRequestHandler should not try to resolve external entities; fix XML parsing in XPathEntityProcessor to correctly expand named entities, but ignore external entities
          Hide
          ASF subversion and git services added a comment -

          Commit 1547011 from Uwe Schindler in branch 'dev/branches/lucene_solr_3_6'
          [ https://svn.apache.org/r1547011 ]

          SOLR-5520: Backports of:

          • SOLR-4881 (Fix DocumentAnalysisRequestHandler to correctly use EmptyEntityResolver to prevent loading of external entities like UpdateRequestHandler does)
          • SOLR-3895 (XML and XSLT UpdateRequestHandler should not try to resolve external entities)
          • SOLR-3614 (Fix XML parsing in XPathEntityProcessor to correctly expand named entities, but ignore external entities)
          Show
          ASF subversion and git services added a comment - Commit 1547011 from Uwe Schindler in branch 'dev/branches/lucene_solr_3_6' [ https://svn.apache.org/r1547011 ] SOLR-5520 : Backports of: SOLR-4881 (Fix DocumentAnalysisRequestHandler to correctly use EmptyEntityResolver to prevent loading of external entities like UpdateRequestHandler does) SOLR-3895 (XML and XSLT UpdateRequestHandler should not try to resolve external entities) SOLR-3614 (Fix XML parsing in XPathEntityProcessor to correctly expand named entities, but ignore external entities)

            People

            • Assignee:
              Uwe Schindler
              Reporter:
              Hoss Man
            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development