[SOLR-3424] PhoneticFilterFactory threadsafety bug

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.6, 4.0-ALPHA
• Fix Version/s: 4.0-ALPHA
• Component/s: Schema and Analysis
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 30/Apr/12 06:25
• Updated: 06/May/12 02:26
• Resolved: 06/May/12 02:26

Description

PhoneticFilterFactory has a static HashMap registry mapping an encoder name to an implementation. There is a ReentrantLock used when the map is modified (when the encoder config specifies a class name). However, this map, which can be accessed by multiple indexing threads, isn't guarded on any of the reads, which isn't just the common path but also the error messages which dump the registry into the error message.

I realize the likelihood of a problem is extremely slim, but a bug's a bug.