Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-3412

ShowFileRequestHandler shouldn't log SEVERE error and stack trace if file not found

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 4.0-ALPHA
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      When I bring up the new Admin UI for the example-DIH solr home, I noticed these obnoxious supposedly SEVERE errors in my Solr log:

      SEVERE: org.apache.solr.common.SolrException: Can not find: admin-extra.menu-top.html [/SmileyDev/Search/lucene-solr_trunk/solr/example/example-DIH/solr/db/conf/admin-extra.menu-top.html]
      at org.apache.solr.handler.admin.ShowFileRequestHandler.showFromFileSystem(ShowFileRequestHandler.java:229)
      ...

      I think this is a warning at most, and it certainly doesn't need the stack trace.

      Perhaps it would be useful to have a parameter to indicate the client will deal with it not being found and thus log at info? I dunno – perhaps that's over-engineering it.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                dsmiley David Smiley
              • Votes:
                2 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 20m
                  20m
                  Remaining:
                  Remaining Estimate - 20m
                  20m
                  Logged:
                  Time Spent - Not Specified
                  Not Specified