Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-3343

Move non-shared utils from solrj to solr core

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      When doing some unrelated refactoring, I found myself making changes to a class in solrj's org.apache.solr.common which surprised me. Under closer examination the class was only used inside Solr core and DIH.

      I think common in solrj should only contain those classes which are shared between solrj and other modules. Anything thats not used by solrj should go into solr core (or whatever other module actually makes use of it).

        Activity

        Hide
        cmale Chris Male added a comment -

        Resolved in trunk.

        Show
        cmale Chris Male added a comment - Resolved in trunk.
        Hide
        cmale Chris Male added a comment -

        Patch for moving the utils I felt should be moved. Since I used svn 1.6 still, the patch must be executed after the following command:

        svn mv solr/solrj/src/java/org/apache/solr/common/util/DOMUtil.java solr/core/src/java/org/apache/solr/util/DOMUtil.java
        svn mv solr/solrj/src/java/org/apache/solr/common/util/FastWriter.java solr/core/src/java/org/apache/solr/util/FastWriter.java
        svn mv solr/solrj/src/java/org/apache/solr/common/util/FileUtils.java solr/core/src/java/org/apache/solr/util/FileUtils.java
        svn mv solr/solrj/src/java/org/apache/solr/common/util/RegexFileFilter.java solr/core/src/java/org/apache/solr/util/RegexFileFilter.java
        svn mv solr/solrj/src/java/org/apache/solr/common/util/RTimer.java solr/core/src/java/org/apache/solr/util/RTimer.java
        svn mv solr/solrj/src/java/org/apache/solr/common/util/SystemIdResolver.java solr/core/src/java/org/apache/solr/util/SystemIdResolver.java
        
        svn mv solr/solrj/src/test/org/apache/solr/common/util/TestSystemIdResolver.java solr/core/src/test/org/apache/solr/util/TestSystemIdResolver.java
        svn mv solr/solrj/src/test/org/apache/solr/common/util/FileUtilsTest.java solr/core/src/test/org/apache/solr/util/FileUtilsTest.java
        svn mv solr/solrj/src/test/org/apache/solr/common/util/DOMUtilTest.java solr/core/src/test/org/apache/solr/util/DOMUtilTest.java
        

        I will commit this soon as I want to get onto some other refactoring.

        Show
        cmale Chris Male added a comment - Patch for moving the utils I felt should be moved. Since I used svn 1.6 still, the patch must be executed after the following command: svn mv solr/solrj/src/java/org/apache/solr/common/util/DOMUtil.java solr/core/src/java/org/apache/solr/util/DOMUtil.java svn mv solr/solrj/src/java/org/apache/solr/common/util/FastWriter.java solr/core/src/java/org/apache/solr/util/FastWriter.java svn mv solr/solrj/src/java/org/apache/solr/common/util/FileUtils.java solr/core/src/java/org/apache/solr/util/FileUtils.java svn mv solr/solrj/src/java/org/apache/solr/common/util/RegexFileFilter.java solr/core/src/java/org/apache/solr/util/RegexFileFilter.java svn mv solr/solrj/src/java/org/apache/solr/common/util/RTimer.java solr/core/src/java/org/apache/solr/util/RTimer.java svn mv solr/solrj/src/java/org/apache/solr/common/util/SystemIdResolver.java solr/core/src/java/org/apache/solr/util/SystemIdResolver.java svn mv solr/solrj/src/test/org/apache/solr/common/util/TestSystemIdResolver.java solr/core/src/test/org/apache/solr/util/TestSystemIdResolver.java svn mv solr/solrj/src/test/org/apache/solr/common/util/FileUtilsTest.java solr/core/src/test/org/apache/solr/util/FileUtilsTest.java svn mv solr/solrj/src/test/org/apache/solr/common/util/DOMUtilTest.java solr/core/src/test/org/apache/solr/util/DOMUtilTest.java I will commit this soon as I want to get onto some other refactoring.

          People

          • Assignee:
            cmale Chris Male
            Reporter:
            cmale Chris Male
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development