Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      The 4.0 admin UI does not use JSP to create its interface (It uses javascript and RequestHandlers)

      We only use JSP to fill in the path to the core in index.jsp – this can be replaced with simple template text

      1. SOLR-3202-no-jsp.patch
        9 kB
        Ryan McKinley
      2. SOLR-3202-no-jsp.patch
        584 kB
        Ryan McKinley

        Issue Links

          Activity

          Hide
          Ryan McKinley added a comment -

          This loads the admin UI with a simple servlet and:

          +      String[] search = new String[] { 
          +          "${contextPath}", 
          +          "${adminPath}" 
          +      };
          +      String[] replace = new String[] {
          +          request.getContextPath(),
          +          cores.getAdminPath()
          +      };
          +      
          +      out.println( StringUtils.replaceEach(html, search, replace) );
          
          Show
          Ryan McKinley added a comment - This loads the admin UI with a simple servlet and: + String [] search = new String [] { + "${contextPath}" , + "${adminPath}" + }; + String [] replace = new String [] { + request.getContextPath(), + cores.getAdminPath() + }; + + out.println( StringUtils.replaceEach(html, search, replace) );
          Hide
          Uwe Schindler added a comment -

          +1

          Except:

          +      String html = IOUtils.toString(new FileReader(f));
          

          Thats a bad idea as it uses default charset. Use IOUtils.toString(new FileInputStream(f), "UTF-8") or like that. Of course it must also set the content-type correctly, including charset before getting the reader.

          Show
          Uwe Schindler added a comment - +1 Except: + String html = IOUtils.toString(new FileReader(f)); Thats a bad idea as it uses default charset. Use IOUtils.toString(new FileInputStream(f), "UTF-8") or like that. Of course it must also set the content-type correctly, including charset before getting the reader.
          Hide
          Ryan McKinley added a comment -

          This is a more complete patch that actually removes the JSP files and dependencies

          Show
          Ryan McKinley added a comment - This is a more complete patch that actually removes the JSP files and dependencies
          Hide
          Ryan McKinley added a comment -

          removed in #1297578

          Show
          Ryan McKinley added a comment - removed in #1297578

            People

            • Assignee:
              Ryan McKinley
              Reporter:
              Ryan McKinley
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development