Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-2382 DIH Cache Improvements
  3. SOLR-2933

DIHCacheSupport ignores left side of where="xid=x.id" attribute

Attach filesAttach ScreenshotVotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      DIHCacheSupport introduced at SOLR-2382 uses new config attributes cachePk and cacheLookup. But support old one where="xid=x.id" is broken by DIHCacheSupport.<init> - it never put where="" sides into the context, but it revealed by SortedMapBackedCache.<init>, which takes just first column as a primary key. That's why all tests are green.

      To reproduce the issue I need just reorder entry at line 219 and make desc first and picked up as a primary key.

      To do that I propose to chose concrete map class randomly for all DIH test cases at createMap().

      I'm attaching test breaking patch and seed.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jdyer James Dyer
            mkhl Mikhail Khludnev
            Votes:
            2 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified

                Slack

                  Issue deployment