[SOLR-2920] Refactor frequent conditional use of DefaultSolrParams into SolrParams.combine(p,d)

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.6, 4.0-ALPHA
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 25/Nov/11 21:09
• Updated: 10/May/13 10:40
• Resolved: 12/Dec/11 22:57

Description

I had a small bug in use of DefaultSolrParams in my code because I didn't check for non-existent defaults. I noticed through the Solr codebase that is code pattern is very common:

    if( defaults != null ) {
      params = new DefaultSolrParams( params, defaults );
    }

Instead, I refactored this logic into a new SolrParams.combine(p,d) method and made it so that nobody refers to DefaultSolrParams. I did similarly for AppendedSolrParams.