Solr
  1. Solr
  2. SOLR-2742

Add commitWithin to convenience signatures for SolrServer.add(..)

    Details

      Description

      Today you need to manually create an UpdateRequest in order to set the commitWithin value.
      We should provide an optional commitWithin parameter on all SolrServer.add(..) methods as a convenience

      1. SOLR-2742.patch
        14 kB
        Jan Høydahl
      2. SOLR-2742.patch
        10 kB
        Jan Høydahl
      3. SOLR-2742.patch
        9 kB
        Jan Høydahl

        Activity

        Hide
        Jan Høydahl added a comment -

        A patch adding extra method signatures for all add() variants in both SolrServer and CommonsHttpSolrServer

        Show
        Jan Høydahl added a comment - A patch adding extra method signatures for all add() variants in both SolrServer and CommonsHttpSolrServer
        Hide
        Jan Høydahl added a comment -

        Added a test. Anyone know of a better way to test this than indexing a doc, waiting a few seconds and then querying? It would be enough to test that the commitWithin variable on the UpdateRequest is set correctly..

        Show
        Jan Høydahl added a comment - Added a test. Anyone know of a better way to test this than indexing a doc, waiting a few seconds and then querying? It would be enough to test that the commitWithin variable on the UpdateRequest is set correctly..
        Hide
        Jan Høydahl added a comment -

        Plan to commit this to both trunk and 3x branch in a couple of days

        Show
        Jan Høydahl added a comment - Plan to commit this to both trunk and 3x branch in a couple of days
        Hide
        Chris Male added a comment -

        Hey Jan,

        Looks great! +1 to committing to trunk and back porting.

        Just one personal nitpick, if we're going to add Javadocs to the SolrServer methods, can we add full javadocs?

        Show
        Chris Male added a comment - Hey Jan, Looks great! +1 to committing to trunk and back porting. Just one personal nitpick, if we're going to add Javadocs to the SolrServer methods, can we add full javadocs?
        Hide
        Jan Høydahl added a comment -

        Made better JavaDocs for all public methods in SolrServer, including @param tags.

        Show
        Jan Høydahl added a comment - Made better JavaDocs for all public methods in SolrServer, including @param tags.
        Hide
        Jan Høydahl added a comment -

        Committed to trunk and 3.x

        Show
        Jan Høydahl added a comment - Committed to trunk and 3.x
        Hide
        Uwe Schindler added a comment -

        Bulk close after 3.5 is released

        Show
        Uwe Schindler added a comment - Bulk close after 3.5 is released

          People

          • Assignee:
            Jan Høydahl
            Reporter:
            Jan Høydahl
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development