Solr
  1. Solr
  2. SOLR-2727

Upgrade httpclient to 4.1.2 (from 3.0.1 )

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      Currently solr depends on commons-httpclient 3.x. EOL has been announced , for some time , for that release line.

      Need to upgrade the same, to httpclient 4.1.x , to begin with. Targeting 4.0 .

      jira logged as per the discussion of "solr - httpclient from 3.x to 4.1.x" thread.

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          2h 11m 1 Aravind Srini 23/Aug/11 17:38
          Resolved Resolved Reopened Reopened
          9h 2m 1 Aravind Srini 24/Aug/11 02:41
          Reopened Reopened Resolved Resolved
          288d 19h 53m 1 Hoss Man 07/Jun/12 22:34
          Resolved Resolved Closed Closed
          336d 13h 6m 1 Uwe Schindler 10/May/13 11:41
          Uwe Schindler made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue depends upon SOLR-2020 [ SOLR-2020 ]
          Gavin made changes -
          Link This issue depends on SOLR-2020 [ SOLR-2020 ]
          Hoss Man made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Assignee Sami Siren [ siren ]
          Resolution Fixed [ 1 ]
          Hide
          Hoss Man added a comment -

          As far as i can tell, httpclient 3.x is no longer used anywhere in Solr's branch_4x, so this seems resolved.

          Sami: if i'm wrong please re-open and clarify.

          Show
          Hoss Man added a comment - As far as i can tell, httpclient 3.x is no longer used anywhere in Solr's branch_4x, so this seems resolved. Sami: if i'm wrong please re-open and clarify.
          Richard Frovarp made changes -
          Link This issue relates to SOLR-3411 [ SOLR-3411 ]
          Hide
          Sami Siren added a comment -

          I suggest that we: ...

          Sounds good to me, I am going to commit SOLR-2020 to trunk soon. After that I can port the client only part to 3.x. unless somebody thinks that's too late to do it because of the 3.x release procedure is going to start soon... If that is the case then I can only deprecate the CommonsHttpSolrServer from trunk

          Show
          Sami Siren added a comment - I suggest that we: ... Sounds good to me, I am going to commit SOLR-2020 to trunk soon. After that I can port the client only part to 3.x. unless somebody thinks that's too late to do it because of the 3.x release procedure is going to start soon... If that is the case then I can only deprecate the CommonsHttpSolrServer from trunk
          Hide
          Ryan McKinley added a comment -

          Any thoughts on how to handle back compatibility? I tried to add the new SolrServer implementation and deprecate CommonsHttpSolrServer, but there are lots of other places that create the HttpClient directly.

          I suggest that we:

          1. add HttpSolrServer from SOLR-2020, deprecate CommonsHttpSolrServer
          2. merge this change to 3.x
          • distributed search will still use CommonsHttpSolrServer
          • Solrj users can switch to using HttpSolrServer
          1. in /trunk only, migrate all httpclient usage to supported stuff

          thoughts?

          Show
          Ryan McKinley added a comment - Any thoughts on how to handle back compatibility? I tried to add the new SolrServer implementation and deprecate CommonsHttpSolrServer, but there are lots of other places that create the HttpClient directly. I suggest that we: add HttpSolrServer from SOLR-2020 , deprecate CommonsHttpSolrServer merge this change to 3.x distributed search will still use CommonsHttpSolrServer Solrj users can switch to using HttpSolrServer in /trunk only, migrate all httpclient usage to supported stuff thoughts?
          Ryan McKinley made changes -
          Link This issue depends on SOLR-2020 [ SOLR-2020 ]
          Hide
          Aravind Srini added a comment -

          For what we are looking at, it is very important to change the API, port to the 'hc' (httpcomponents) world. It probably implies going back and revisiting the rest of the usages as well.

          Show
          Aravind Srini added a comment - For what we are looking at, it is very important to change the API, port to the 'hc' (httpcomponents) world. It probably implies going back and revisiting the rest of the usages as well.
          Aravind Srini made changes -
          Resolution Duplicate [ 3 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          Ryan McKinley added a comment -

          the two issues seem related, but not necessarily a duplicate. It would be great to get someone with httpcomponent-4.x know how to look at how the http client is used thoughout solr.

          In /trunk (4.x) we can change the solr APIs to depend on the newer httpcomponent stuff

          Show
          Ryan McKinley added a comment - the two issues seem related, but not necessarily a duplicate. It would be great to get someone with httpcomponent-4.x know how to look at how the http client is used thoughout solr. In /trunk (4.x) we can change the solr APIs to depend on the newer httpcomponent stuff
          Hide
          Steve Rowe added a comment -

          SOLR-2020 addresses the same.

          Not quite?

          AFAICT, SOLR-2020 doesn't address internal uses of httpclient 3.x - it's only about providing an httpcomponent-4.x-based client.

          Show
          Steve Rowe added a comment - SOLR-2020 addresses the same. Not quite? AFAICT, SOLR-2020 doesn't address internal uses of httpclient 3.x - it's only about providing an httpcomponent-4.x-based client.
          Steve Rowe made changes -
          Link This issue is related to SOLR-861 [ SOLR-861 ]
          Aravind Srini made changes -
          Field Original Value New Value
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Duplicate [ 3 ]
          Hide
          Aravind Srini added a comment -

          SOLR-2020 addresses the same.

          Show
          Aravind Srini added a comment - SOLR-2020 addresses the same.
          Hide
          Steve Rowe added a comment -

          Some of this work has already been done: SOLR-2020.

          Show
          Steve Rowe added a comment - Some of this work has already been done: SOLR-2020 .
          Hide
          Aravind Srini added a comment -

          Initial patch to be worked on, w.r.t trunk ,targeting the 4.x .

          Show
          Aravind Srini added a comment - Initial patch to be worked on, w.r.t trunk ,targeting the 4.x .
          Aravind Srini created issue -

            People

            • Assignee:
              Sami Siren
              Reporter:
              Aravind Srini
            • Votes:
              3 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development