[SOLR-2682] remove addException() from SimpleFacet

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.0, 1.2, 1.3, 1.4.1, 3.1, 3.2, 3.3, 4.0-ALPHA
• Fix Version/s: 3.4, 4.0-ALPHA
• Component/s: search
• Assignee: Koji Sekiguchi
• Reporter: Koji Sekiguchi
• Created: 29/Jul/11 01:35
• Updated: 16/Sep/11 14:48
• Resolved: 30/Jul/11 11:50

Description

addException() which is super historic, pre-apache code, should be removed from SimpleFacet. Hoss described in the mail thread http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201107.mbox/%3Calpine.DEB.2.00.1107281651200.12738@bester%3E

: If I got an exception during faceting (e.g. undefined field), Solr doesn't
: return HTTP 400 but 200 with the exception stack trace in <arr name="exception">
: ...</arr> tag. Why is it implemented so? I checked Solr 1.1 and saw the same behavior.

super historic, pre-apache, code ... the idea at the time was that some
parts of the response (like faceting, highlightin, watever...) would be
"optional" and if there was an error computing that data it wouldn't fail
the main request.

that logic should really be ripped out.