Solr
  1. Solr
  2. SOLR-2671

SchemaField.indexOptions() should return removed to decrease visibility of expert & experimental IndexOptions class

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None

      Description

      LUCENE-2048 introduced a SchemaField.indexOptions method which returns an IndexOptions object based on the omitTermFreqAndPosition and omitPosition boolean properties – but after some consideration it was decided that it was not a good idea to expose that expert level class at this level of the Solr internal APIs, and that SchemaField should instead only expose direct accessors for the specific properties.

        Issue Links

          Activity

          Robert Muir made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hoss Man made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hoss Man made changes -
          Summary SchemaField.indexOptions() should return null if SchemaField.indexed() returns false SchemaField.indexOptions() should return removed to decrease visibility of expert & experimental IndexOptions class
          Assignee Hoss Man [ hossman ]
          Description It doesn't make sense for SchemaField.indexOptions() to return any of the values from the IndexOptions enum if the field is not going to be indexed at all.

          we should return null to prevent missleading any code that calls that method
          LUCENE-2048 introduced a SchemaField.indexOptions method which returns an IndexOptions object based on the omitTermFreqAndPosition and omitPosition boolean properties -- but after some consideration it was decided that it was not a good idea to expose that expert level class at this level of the Solr internal APIs, and that SchemaField should instead only expose direct accessors for the specific properties.
          Hoss Man made changes -
          Link This issue is part of LUCENE-2048 [ LUCENE-2048 ]
          Hoss Man made changes -
          Field Original Value New Value
          Attachment SOLR-2671.patch [ 12487653 ]
          Hoss Man created issue -

            People

            • Assignee:
              Hoss Man
              Reporter:
              Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development