Solr
  1. Solr
  2. SOLR-2655

DIH multi threaded mode does not resolves attributes correctly

    Details

      Description

      DIH multi-threaded mode sometimes fails to resolve entity attributes.

      1. SOLR-2655.patch
        8 kB
        Shalin Shekhar Mangar
      2. SOLR-2655.patch
        11 kB
        Shalin Shekhar Mangar
      3. SOLR-2655-branch_3x.patch
        11 kB
        Shalin Shekhar Mangar
      4. SOLR-2655.patch
        11 kB
        Shalin Shekhar Mangar

        Activity

        Shalin Shekhar Mangar created issue -
        Hide
        Shalin Shekhar Mangar added a comment -

        Patch by Frank Wesemann given in SOLR-2186

        Show
        Shalin Shekhar Mangar added a comment - Patch by Frank Wesemann given in SOLR-2186
        Shalin Shekhar Mangar made changes -
        Field Original Value New Value
        Attachment SOLR-2655.patch [ 12486580 ]
        Hide
        Shalin Shekhar Mangar added a comment -

        The problem affects child entities only. The problem was that EntityProcessor.init was called after ThreadedEntityProcessorWrapper.init which populates rows in the resolver. Therefore the

        1. The first call to EP.init() fails to resolve attributes which depend on the parent row
        2. The subsequent calls to EP.init resolves attributes based on the previous parent row, not the current one.

        Fix is attached.

        Show
        Shalin Shekhar Mangar added a comment - The problem affects child entities only. The problem was that EntityProcessor.init was called after ThreadedEntityProcessorWrapper.init which populates rows in the resolver. Therefore the The first call to EP.init() fails to resolve attributes which depend on the parent row The subsequent calls to EP.init resolves attributes based on the previous parent row, not the current one. Fix is attached.
        Shalin Shekhar Mangar made changes -
        Attachment SOLR-2655.patch [ 12487052 ]
        Hide
        Shalin Shekhar Mangar added a comment -

        Patch for branch_3x

        Show
        Shalin Shekhar Mangar added a comment - Patch for branch_3x
        Shalin Shekhar Mangar made changes -
        Attachment SOLR-2655-branch_3x.patch [ 12487137 ]
        Hide
        Shalin Shekhar Mangar added a comment -

        Cleaned up the tests a bit.

        I'll commit this shortly.

        Show
        Shalin Shekhar Mangar added a comment - Cleaned up the tests a bit. I'll commit this shortly.
        Shalin Shekhar Mangar made changes -
        Attachment SOLR-2655.patch [ 12487283 ]
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 1149108 on trunk and 1149112 on branch_3x.

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 1149108 on trunk and 1149112 on branch_3x.
        Shalin Shekhar Mangar made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Robert Muir added a comment -

        bulk close for 3.4

        Show
        Robert Muir added a comment - bulk close for 3.4
        Robert Muir made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development