Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-2565

Prevent IW#close and cut over to IW#commit

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 4.0-ALPHA
    • 4.0-ALPHA
    • update
    • None

    Description

      Spinnoff from SOLR-2193. We already have a branch to work on this issue here https://svn.apache.org/repos/asf/lucene/dev/branches/solr2193

      The main goal here is to prevent solr from closing the IW and use IW#commit instead. AFAIK the main issues here are:

      The update handler needs an overhaul.

      A few goals I think we might want to look at:

      1. Expose the SolrIndexWriter in the api or add the proper abstractions to get done what we now do with special casing:
      2. Stop closing the IndexWriter and start using commit (still lazy IW init though).
      3. Drop iwAccess, iwCommit locks and sync mostly at the Lucene level.
      4. Address the current issues we face because multiple original/'reloaded' cores can have a different IndexWriter on the same index.

      Eventually this is a preparation for NRT support in Solr which I will create a followup issue for.

      Attachments

        1. SOLR-2565-revert.patch
          5 kB
          Uwe Schindler
        2. SOLR-2565.patch
          154 kB
          Robert Muir
        3. SOLR-2565.patch
          2 kB
          Yonik Seeley
        4. SOLR-2565.patch
          9 kB
          Mark Miller
        5. SOLR-2565__HuperDuperAutoCommitTest.patch
          19 kB
          Chris M. Hostetter
        6. slowtests.txt
          53 kB
          Robert Muir
        7. fix+hossmans-test.patch
          24 kB
          Mark Miller
        8. dump.txt
          9 kB
          Uwe Schindler

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            markrmiller@gmail.com Mark Miller
            simonw Simon Willnauer
            Votes:
            6 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment